Giter Site home page Giter Site logo

cloudposse / terraform-aws-code-deploy Goto Github PK

View Code? Open in Web Editor NEW
14.0 14.0 21.0 1.13 MB

Terraform module to provision AWS Code Deploy app and group.

Home Page: https://cloudposse.com/accelerate

License: Apache License 2.0

Makefile 7.72% HCL 86.55% Go 5.73%
terraform-modules code-deploy terraform aws ecs ecs-task

terraform-aws-code-deploy's People

Contributors

actions-user avatar cloudpossebot avatar dependabot[bot] avatar dylanbannon avatar max-lobur avatar milldr avatar nitrocode avatar osterman avatar renovate[bot] avatar stephentan-tw avatar sweetops avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

terraform-aws-code-deploy's Issues

Perpetual diff for deployment group when not using auto_rollback_configuration

Describe the Bug

When not setting auto_rollback_configuration_events, plan will always show a perpetual diff of

  + auto_rollback_configuration {
      + enabled = false
      + events  = [
          + "",
        ]
    }

Expected Behavior

Plan should not show diff when not setting auto_rollback_configuration.

Steps to Reproduce

auto_rollback_configuration_events not set, = null or =""
Setup required values
Run apply
Run plan
It will show a diff even though nothing is changing

Note: I do not think this is relevant, but we are calling the module using a foreach to make several codedeploy_applications.

Screenshots

image

Environment

  • Terraform Version 1.3.0
  • Module Version 0.2.3

Additional Context

This clutters the plan and also has a side affect of calling UpdateDeploymentGroup api which will add a message to every SQS queue "Subject" : "SUCCESS: AWS CodeDeploy notification setup for trigger {deploymentGroupName}". In our case we have an DeploymentFailure queue setup and this shows as a failed deployment. We are going to work around that issue with a custom subscription with a filter and put in a separate issue to address it in this module's aws_sns_topic_subscription to allow adding filters.

Unable to create an ec2 code-deploy

Found a bug? Maybe our Slack Community can help.

Slack Community

Describe the Bug

I am trying to use your module for the following EC2 deployment. I get an issue when I try to use the ec2_tag_filter variable. When I run the plan, I get:

│ Error: Invalid function argument
│
│   on .terraform/modules/code-deploy-stargate-frontend/main.tf line 179, in resource "aws_codedeploy_deployment_group" "default":
│  179:         key   = lookup(ec2_tag_set.value, "key", null)
│     ├────────────────
│     │ ec2_tag_set.value is list of object with 1 element
│
│ Invalid value for "inputMap" parameter: lookup() requires a map as the first argument.
╵
╷
│ Error: Invalid function argument
│
│   on .terraform/modules/code-deploy-stargate-frontend/main.tf line 180, in resource "aws_codedeploy_deployment_group" "default":
│  180:         type  = lookup(ec2_tag_set.value, "type", null)
│     ├────────────────
│     │ ec2_tag_set.value is list of object with 1 element
│
│ Invalid value for "inputMap" parameter: lookup() requires a map as the first argument.
╵
╷
│ Error: Invalid function argument
│
│   on .terraform/modules/code-deploy-stargate-frontend/main.tf line 181, in resource "aws_codedeploy_deployment_group" "default":
│  181:         value = lookup(ec2_tag_set.value, "value", null)
│     ├────────────────
│     │ ec2_tag_set.value is list of object with 1 element
│
│ Invalid value for "inputMap" parameter: lookup() requires a map as the first argument.
╵

Expected Behavior

I expect the Plan to run!

Steps to Reproduce

Code:

module "code-deploy-stargate-frontend" {
  source    = "cloudposse/code-deploy/aws"
  version   = "0.1.1"
  delimiter = "-"
  deployment_style = {
    deployment_option = "WITHOUT_TRAFFIC_CONTROL"
    deployment_type   = "IN_PLACE"
  }
  ec2_tag_filter = [
    {
      key   = "Service"
      type  = "KEY_AND_VALUE"
      value = "test"
    },
  ]
  enabled          = true
  label_value_case = "upper"
  name             = "test"
  minimum_healthy_hosts = {
    type  = "HOST_COUNT"
    value = "1"
  }
  compute_platform            = "Server"
  service_role_arn            = "code-deploy-test"
  create_default_service_role = true
}

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

  • OS: OSX
  • Version Terraform 1.0.8

Additional Context

Add any other context about the problem here.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

  • WARN: Base branch does not exist - skipping

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

Detected dependencies

terraform
main.tf
  • cloudposse/sns-topic/aws 0.20.1
versions.tf
  • aws >= 2.0
  • local >= 1.2
  • hashicorp/terraform >= 1.0

  • Check this box to trigger a request for Renovate to run again on this repository

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.