cloudslang/score

CloudSlang Orchestration Engine

score's Issues

worker

I am a newbie to Cloudslang.

a) How to configure more workers?
b) How to configure worker to specific queue in order to act on jobs sent to that queue?

Thanks

Fail to compile flow which uses subflows located in the same folder

Let's say we have flow flow_system_properties_subflow.sl in flow_system_properties_subflow.sl which uses simplecp.flows.flow_system_properties_subflow_level1 which located in file simplecp.flows.flow_system_properties_subflow_level1.sl located in the same folder

When executing cli with command

run --f c:/Temp/slang/tests/SimpleCp/flow_system_properties_subflow.sl --cp c:/Temp/slang/tests

We get error

Command failed java.lang.RuntimeException: java.lang.RuntimeException: Reference: 'simplecp.flows.flow_system_properties_subflow_level1' in executable: 'flow_system_properties_subflow', wasn't found in path

When executing command with specifying --cp with flow path

run --f c:/Temp/slang/tests/SimpleCp/flow_system_properties_subflow.sl --cp c:/Temp/slang/tests/SimpleCp

We get error

Command failed java.lang.RuntimeException: java.lang.IllegalArgumentException: Source flow_system_properties_subflow has dependencies but no path was given to the compiler

Reduce code climate issues

https://codeclimate.com/github/CloudSlang/score/issues

and possibly include the badge

modifying the readme to include a "Pre-Reqs" section, that includes things like Maven and "Requires Java 1.7+"

sent from Okita Cat

problem embedding score (from CODAR)

I've embedded the score to standalone application to try it and now I'm trying to embed it to ours.

The first problem was that we have quite old libraries (Spring 3.2.3, Hibernate 3.6.10, Spring data jpa 1.4.1) so I have to adjust that but luckily it did not require any drastic changes and it still works in the standalone application.

Now I think I have problem with the database. During the startup it's creating Worker and saving it to WorkerNodeRepository. The save does not throw any error but the repository stays empty. So it throws exception when looked up by uuid.

If I don't configure any datasource for score it uses the H2 by default? Should I connect it to our datasource? Is it persisting something between the application starts or does the database serve only for current executions?
I am kinda stuck at one place.

Enchancement - API for score / cloudslang only

Hello,

Many customers are requring for an API available for CloudSlang

Can we add this to backlog, is it already planned, i notice 'score-api' folder commited?

Thanks for let me know

Update the corresponding unit test with this case:

default: ${get("input", "")} ... snake_case to camelCase

Check if PythonRuntimeService exec, eval method works properly

sometimes I see Py objects in return values, however IMO they should already be converted to Java objects

Remove unused DB connectors

The db driver dependencies come from score – they are declared with test scope in parent pom:

        <dependency>
            <groupId>net.sourceforge.jtds</groupId>
            <artifactId>jtds</artifactId>
            <version>${jtds.version}</version>
            <scope>test</scope>
        </dependency>

        <dependency>
            <groupId>com.oracle</groupId>
            <artifactId>ojdbc6</artifactId>
            <version>${oracle.version}</version>
            <scope>test</scope>
        </dependency>

        <dependency>
            <groupId>mysql</groupId>
            <artifactId>mysql-connector-java</artifactId>
            <version>${mysql.connector.version}</version>
            <scope>test</scope>
        </dependency>

        <dependency>
            <groupId>postgresql</groupId>
            <artifactId>postgresql</artifactId>
            <version>${postgres.driver.version}</version>
            <scope>test</scope>
        </dependency>

3 out of these 4 are also declared in score-node-impl pom but they are not actually used since the data sources are commented out in https://github.com/CloudSlang/score/blob/master/engine/node/score-node-impl/src/test/resources/META-INF/spring/testContext.xml (H2 is used).

Add a flag to turn GC hack off

Jenkins release fails

from jenkins:

Maven project score

!!!! DependencyServiceTest is failing !!!!

!!!! Running with -DskipTests for now !!!!

!!!! These tests pass matrix, not sure why it fails here… !!!!

Score Finished Event

Score finished event is not synchronous to the execution and therefore we need to re consider if that is the way to listen to the run termination or to the language events.

Update sl syntax in test files

there are 35 occurrences of old sl syntax (action syntax) in language repository, need to check whether they need to be updated and act accordigly (ps.s cool IntelliJ plugin propts for them)

e.g.

  action:
    python_script: 'print "hello world"'

WorkerExecutionMonitorServiceImpl messages contain several typos

This is because the Constant names in the WorkerMonitorInfoEnum are misspelled:
MAX_MOMORY
FREE_MOMORY
WROKER_ID
OUTBUDDER_SIZE_AVERAGE

Rapid running of busyWorkersService

The busyWorkersService seems to run by default at intervals of 200 milli seconds configured in scoreEngineSchedulerContext.xml (from score-all)

This rapid run is adding to load on the database.

Qn 1: Can this interval (safely) be changed to for e.g 5 seconds?
Qn 2: Since its in the XML , teh XML has to be patched into the jar I guess after changing the config? Are there any other options to reconfigure?

Acquire/release lock and semaphore

From @meshipeer on February 15, 2016 6:32

requires mechanism in score...

Copied from original issue: CloudSlang/cs-content#521

Engine datasource dependency

1. Minimize direct dependencies on dataSource (HiloFactoryBean, DataBaseDetector and ExecutionQueueRepositoryImpl)
2. Use @Resource instead of @Autowired
3. Consider supporting custom dataSource name
4. Consider these point for other DB related stuff (jdbcTemplate etc)

hilo is dependant on liquibase

Therefore emf depends liquibase

do we need WorkerQueueStatistics?

UnknownHostException when starting CLI

Exception in thread "main" org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'io.cloudslang.worker.management.WorkerRegistration#0': Invocation of init method failed; nested exception is java.net.UnknownHostException: alonbecker.local: alonbecker.local: nodename nor servname provided, or not known
at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:136)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:407)

might be related to :
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7180557

add pre-persist to QueueListener

Adding worker more than once to the same workers group causes database error

Adding worker more than once to the same workers group causes a database integrity exception due to the fact that the primary key on OO_WORKER_GROUPS is composed of worker_id and group_name

object mapper in worker mbean

@meirwah why do we need objectmapper in workermbean? And why do we initialize it in post construct. It has impact on score load time.

Central worker recovery should not be triggered because of unacknowledged messages

Prolog:

worker recovery is checked every 2 minutes by Central (WorkerRecoveryServiceImpl.java). A worker is deemed to be recovered if
(the worker has not sent a keepalive recently) OR (the queue contains unacknowledged messages for this worker)

What happens:

1. there is only one worker in the RAS_Operator_Path group alias. the worker can connect to central fine...there is no connection issue.
2. queue contains 8 older and unacknowledged messages by the above RAS
3. every 2 minutes, central triggers recovery of this worker, which leads to the triggering of the recovery/restart of the worker itself(due to WRW change)
4. the above process obviously stops all running flows on the worker, slowing all executions down on central.
5. because there is only this worker in the RAS_Operator_Path, and he was already determined as "not alive" by the central recovery mechanism, the unack. messages can't be assigned to this worker(despite him being very much alive).
   this makes it impossible to reassign those 8 messages, and the recovery for this worker will be attempted every 2 minutes, forever...until there will be another worker in the RAS_Operator_Path
6. operations that need more than 2 min, will NEVER complete, and their flows remain stuck

Suggestions:

worker recovery should not be triggered by the presence of unack queue messages. if the worker is alive(has sent keep-alives) and he's the only one in that group, it should be attempted to reassign those messages to him again, and not trigger the recovery process, which will cause all flow runs on that worker to be brutally destroyed.

score compatible with JDK17?

Hi all,
my application embeds both SpringBoot v.2.7.x and score-all v.0.3.280.

I would like to upgrade SpringBoot to v.3.x, that comes with Spring Framework 6.x, targeted for JDK17, and using jakarta.persistence instead of javax.persistence, too.

My question is: is there a chance that a new release of score-all built using jdk17 and jakarta libraries will come soon?

BR,
MR

missing contribution .md - to all repos

Not handling Exceptions properly

... for example if your java content will throw an exception, this RuntimeException will suppress the exception message ( for example if your content will throw a NullPointerException, the execution.log will not tell you that)

Fix: add the exception message to the RuntimeException message

need to add tests requirements to CONTRIBUTING.md

Update score version in master to be 0.3x

Need to update the version of score artifacts in the master branch to be 0.3x

flow start over after finish

I get this exception in the log file:
java.lang.RuntimeException: Failed to serialize execution plan. Error:

H2 db name : 'testdb' ????

In the logs it appers that the H2 DB name is : testdb .... :
EmbeddedDatabaseFactory - Creating embedded database 'testdb'

Java file headers

They should appear in normal Java block comments first thing before package declaration

missing Spring dependency information on Getting started guide

i'm expecting to see on getting started guide as part of the Spring section how to add the Spring dependency.

need to remove nexus url - from all projects!!

Score-content + slang + score : pom.xml contains:

nexus-repository nexus repository http://mydphdb0166.hpswlabs.adapps.hp.com:8081/nexus/content/repositories/releases/ nexus-snapshot-repository nexus snapshots repository http://mydphdb0166.hpswlabs.adapps.hp.com:8081/nexus/content/repositories/snapshots/ http://mydphdb0166.hpswlabs.adapps.hp.com:8081/nexus/content/repositories/releases/

should be removed

automation to MC releases

EventBusImpl methods should be mutually exclusive

as per CloudSlang/cloud-slang#593

some requests.

score seems very interesting to be used in several use cases. in order to ease the use, I would like to ask a few requests to make it easier to work with :

1. add compile command to CLI – so one can have a “dry run” on the yaml flow file.
2. visual EP tool for slang, a way to see your flow from a slang file.
3. Parallel feature is important. ant like structure is a good example.
4. docs for content (Java + Yaml). you are lacking content docs, both on the Yaml flows/operations and on Java actions.

privacy issues

score Critical Privacy Violation worker/worker-manager/score-worker-manager-impl/src/main/java/io/cloudslang/worker/management/WorkerRegistration.java
score High Log Forging engine/queue/score-queue-impl/src/main/java/io/cloudslang/engine/queue/services/QueueListenerImpl.java
score High Log Forging engine/queue/score-queue-impl/src/main/java/io/cloudslang/engine/queue/services/QueueListenerImpl.java
score High Privacy Violation score-samples/hello-score/src/main/java/io/cloudslang/samples/HelloScore.java