cloudworkz/kafka-minion-helm-chart

Helm chart for deployment of Kafka Minion

kafka-minion-helm-chart's Issues

Feature: TLS support

values.yml shows tls hash but this doesn't translate to configuration

containerPort does not map to telemetry port value in deployment template

In the deployment template, the http containerPort does not match the telemetry port in the value file - it's just statically set to 80, which causes the probes to endlessly fail:

            - name: http
              containerPort: 80
              protocol: TCP

I think it should be

            - name: http
              containerPort: {{ .Values.telemetry.port }}
              protocol: TCP

Helm install fails

Incorrect check in sasl-secret.yaml based on default values.yaml.

Current check
{{- if and (.Values.sasl.enabled) (not .Values.sasl.existingCredentialsSecret) -}}

should be

{{- if and (.Values.kafka.sasl.enabled) (not .Values.kafka.sasl.existingCredentialsSecret) -}}

Question: Custom Metrics

Hey all 👋

I'm kinda new to this so I'm not sure if this question will make sense, sorry if it doesn't.

I'm looking to integrate specific metrics on HPA (Horizontal Pod Autoscaler) from K8s, but since these metrics expose all topics/groups/etc/etc together it won't fit very well.
Is there a way to create/query custom metrics?

minReplicas: 1 maxReplicas: 3 metrics: - type: Pods pods: metricName: CONSUMER_LAG_FROM_GROUP_ID_METRIC targetAverageValue: 100

Scaling up based on consumer lag from specific group id

Is this looking possible?

Thank you.

Using only TLS cert without username/password

I am trying to use minions with TLS enabled without key & password. I see below error message. Looks like we cannot just provide key. Please let me know.

helm install kafka-minion kafka-minion/kafka-minion --set kafka.tls.enabled=true --set kafka.brokers="{brokers list}" --set kafka.tls.certificates.ca="$(cat ./kafka.client.truststore.jks)"

kafka-minion/templates/tls-secret.yaml:17:51: executing "kafka-minion/templates/tls-secret.yaml" at <b64enc>: invalid value; expected string

"kafka-minion.tlsSecretName" has the same value as "kafka-minion.saslSecretName"

Hello,

Can you fix the helpers.tpl file please ?

{{/*
Create the name for the TLS credentials secret.
*/}}
{{- define "kafka-minion.tlsSecretName" -}}
{{- if .Values.kafka.tls.existingSecret -}}
{{- .Values.kafka.tls.existingSecret -}}
{{- else -}}
{{- template "kafka-minion.fullname" . -}}-sasl
{{- end -}}
{{- end -}}

instead of :

{{/*
Create the name for the TLS credentials secret.
*/}}
{{- define "kafka-minion.tlsSecretName" -}}
{{- if .Values.kafka.tls.existingSecret -}}
{{- .Values.kafka.tls.existingSecret -}}
{{- else -}}
{{- template "kafka-minion.fullname" . -}}-tls
{{- end -}}
{{- end -}}

ServiceMonitor is broken

the chart-generated servicemonitor has a selection label of:

  Selector:
    Match Labels:
      App:  kafka-minion

but the actual service generated by the chart has labels:

Labels:            app.kubernetes.io/instance=km
                   app.kubernetes.io/managed-by=Tiller
                   app.kubernetes.io/name=kafka-minion

so no match, and no target, and no discovery.

My workaround:
manually creating the service monitor with:

  selector:
    matchLabels:
      app.kubernetes.io/name: kafka-minion