cm45t3r/candlestick

Candlestick patterns detection.

candlestick's Issues

Pinbar Bearish and Bullish Candles

Do these functions serve the purpose of detecting Pinbar Bearish and Bullish Candles? i.e. isBullishHammer & isBearishHammer.

Some Patterns return undefined

When examining series some return empty arrays, and other several undefined values. Is this to be expected?

Non installation fix & possible script error on test?

Let me start by saying that this is exactly what I had been looking for, and was quite surprised that there weren't more projects of this type on here.

Okay now the issue(s)

1. Easy fix . . . following download and running install, install was rejected due to the project name being the same as one the dependencies in the Package.Json file. - fixed by Capitalising the name of the project in this file and running npm install Candlestick instead of candlestick.

2. Issue on test (which I'm not going to need, but ran anyway) throwing up

mocha --check-leaks --use_strict

error. May be something in the script?

isEngulfed function

First of all, thank's for sharing this code.
I'm not a python developer but I think there's an issue with isEngulfed function.

Shortest candlestick is engulfed by a longest if the body of longest which completely overlaps or engulfs the body of the shortest

1. Math.max(shortest.open, shortest.close) < Math.max(longest .open, longest .close)
2. Math.min(shortest.open, shortest.close) > Math.min(longest .open, longest .close)

if this two conditions are true so bodyLen(shortest) < bodyLen(longest)

Thank's

Cannot chain the patterns

The essential value of pattern recognition is in constructing a chain of patterns from an array of candles, i.e. taking an array of candles, and producing an array of [pattern1, pattern2, pattern3,...], so it is possible to use such data to evaluate data predicted by the pattern versus the actual data, which in turn provides evaluation of patterns accuracy/reliance within any given data set.

Currently, the library does not let you construct such pattern chain at all.

So this is a proposed improvement 😉

Merge Conflicts in Your Package.json

Had issues installing directly from trunk. Saw you had some leftovers from a merge

<<<<<<< HEAD
=======

Should detect Doji patterns.

Currently library functions don't if a candlestick has Doji pattern. This feature needs to be included. It would be better if different versions of Doji pattern i.e. standard, gravestone or dragonfly Doji can be detected.