cmb69/calendar_xh

Event calendars for CMSimple_XH

calendar_xh's Issues

Make past_events stylable through a row class

0001-make-past_events-stylable-through-a-row-class.zip

More flexible date/time formats

Calendar has a rather minimalistic approach to date/time formatting: for dates, the separator character can be chosen (., - or /), but the order of the components is fixed (day, month, year). For times the format is hard coded. This is unsuitable for representing date/times for a lot of languages; e.g. in American English the month usually preceedes the day, and times are usually expressed in 12-hour format.

This needs to be more flexible.

Store dates in ISO 8061 format

ISO dates are easy to grasp and to process, and there is really no need to allow for different date component separators in the event file. An additional bonus: the event files could easily be sorted, if so desired.

typo in German tooltips and help file

Einstellung der resultierende Beite der Eintragstabelle

Use flexible layout for event form

The possibility to choose between narrow, medium and wide appears to be clumsy, and doesn't fit to responsive templates.

Use FontAwesome instead of custom icons

Allow HTML in event, location and link text fields

At least for some users being able to mark up the event, location and link text fields seems to be desireable. As it may not be ideal for all users, a config option appears to be sensible.

See https://cmsimpleforum.com/viewtopic.php?f=16&t=13290#p64846, item 2, and the following discussion.

PS: Caveat: a config option might require dynamic conversion.

Replace datepicker

The datepicker that is used by Calendar_XH appears to be unmaintained (last commit was on 2014-11-28), and since its move to Gihub (on 2011-10-02) there hasn't been tagged any release. It might be best to replace it, before it finally breaks.

Can't link to https://

All external links are automatically prefixed by http:// so it is not possible to link to any https:// page (or other protocol for that matter).

Support VALUE param for DTSTART and DTEND

See https://cmsimpleforum.com/viewtopic.php?f=16&t=13290#p64836.

Concurrent access to eventfile is not properly handled

Besides that there is no online locking in place, even worse no offline locking is employed, so multiple users may mutually overwrite their modifications.

event() fatals as of PHP 7.1

The documentation states that {{{event()}}} displays the next event marquee, but calling event() without all four required parameters fatals as of PHP 7.1.0.

Birthday events for future years ignored in nextevent()

nextevent() ignores birthday events for all but the current year.

Support recurring events

Ajaxify event management

Scrolling text horizontal (marquee)

If you want to make the scrolling text horizontal (which works well with CSS), the hardcoded <br> in the source text disturbs considerably.
<div class="nextevent_date">... <br>...</div>

Is that not possible somehow differently? Without?

I have a dream.
Configuration option for the scrolling text: vertical or horizontal.
But that would be luxury and not mandatory ;-)

Provide proper CRUD user interface for event management

CSRF protection is missing

Protect PHP files from direct access

Document details of Link field

See https://cmsimpleforum.com/viewtopic.php?f=16&t=13290&p=64857#p64850.

Support multiple calendars

If we support multiple calendars, we could get rid of special multi-language support.

Add basic import of .ics files

iCalendar is a widely supported standard format for exchange of calendaring information. Therefore, facilitating the import of .ics files appears to be appropriate.

Lots of event cause multiple issues

The plugin is currently unsuited for lots of events (say, several hundred), because the edit events form becomes unwieldy (no pagination), saving the events may fail (due to max_input_vars etc.), and there may be overall performance issues.

Use proper CSV format

Presently, calendar.csv doesn't permit semicolons, since these are used as field separators, and quoted fields are not yet supported.

Type config options

This feature is available as of CMSimple_XH 1.6, and is a nice improvement especially regarding boolean configuration options.

Require PHP7

If we don't do this for Calendar_XH 2.0, we may need to support PHP 5 for years.

Drop support for CMSimple_XH 1.6

CMSimple_XH 1.7.0 has been released in July 2017, so users are supposed to have been updated already; otherwise, let's push them. :)

Replace headings with table captions

<h2> as headings for calendar sections are probably fine in most cases - but not always. They might interfere with the page structure. Especially the month selection for the calendar itself as <h2> is very inconvenient.

Maybe no heading tag should be used there at all? About the CSS they are well designable.
Or selectable in the configuration?

Small typo in de.php

$plugin_tx['calendar']['next_button_title']="Nachster Monat";
We are allowed to use german umlauts here -> "Nächster".
;-)

Drop JS enhancements for pre ES6 browsers

It's just not worth the effort anymore. Users of old browsers (such as IE11) need to live without the enhancements.

Add structured Event markup

See https://developers.google.com/search/docs/data-types/events.

That would require to have an own URL for each event, and possibly also an exact location.

Ignore empty lines in calendar.csv

These may be deliberately or inadvertently be inserted by the user or a tool – simply ignoring them shouldn't do any harm. See https://cmsimpleforum.com/viewtopic.php?f=16&t=13290#p64846, item 3.

editevents() throws fatal error

If editevents() is called without argument (like described in the user manual), it throws a fatal error under PHP ≥ 7.1.0:

Uncaught ArgumentCountError: Too few arguments to function editevents(), 0 passed in ...

vCalendar/iCalendar support

Not sure in which way exactly (maybe via QR codes), but it would certainly make sense to offer visitors the possibility to integrate single or all events in their calendars, and maybe it would also make sense for the webmaster to be able to import vCalendar/iCalendar info into Calendar_XH.

Store calendar data in general content folder

This folder is already protected against HTTP access, and this way all data are stored in one place.

Work around PHP's broken CSV escaping

Raise CMSimple_XH and PHP version requirements

It does not make sense to support old CMSimple_XH and PHP versions; instead we should aim to keep the code simple and comprehensible by using more recently introduced features where appropriate.

It appears to be reasonable to require CMSimple_XH ≥ 1.6.3 and PHP ≥ 5.5.0.

Remove closing ?> markers from language files

These are not bad per se, but unnecessary and may cause issues if there are followed by "too much" whitespace (as in sk.php).

Clean structure of event files

Originally, the event files have been pure CSV files, but because enhancements have been made in a backward compatible way, the purity has been sacrificed. This is rather unfortunate as it makes it harder to process the files with other tools.

ics import fails

First: Many thanks for version 2.0

Unfortunately, attempts to import complex ics files failed with the following message (white page):

Uncaught TypeError: Argument 1 passed to Calendar\Event::create() must be of the type string, null given, called in \plugins\calendar\classes\ICalendarReader.php on line 95 and defined in \plugins\calendar\classes\Event.php:72
Stack trace:
#0 \plugins\calendar\classes\ICalendarReader.php(95): Calendar\Event::create(NULL, NULL, NULL, NULL, 'Neujahr in Deut...', '', '', NULL)
#1 \plugins\calendar\classes\ICalendarReader.php(58): Calendar\ICalendarReader->parse()
#2 \plugins\calendar\classes\IcalImportController.php(82): Calendar\ICalendarReader->read()
#3 \plugins\calendar\classes\Plugin.php(129): Calendar\IcalImportController->importAction()
#4 \plugins\calendar\classes\Event.php on line 72

With simpler files, however, the import works without problems.

(Example of a complex failed file:
https://www.ferienwiki.de/exports/de -> "Feiertage gesamt"

marquee shows the location as ### for birthdays

See the heading.

Ajaxify calendar "pagination"

Simplify default styles

The default styles of a plugin should not be demonstration of what is possible, but rather minimal, to be a good fit for all (sensible) templates.

Use CSS instead of <marquee>

Birthday events are shown as normal events

The 0. birthday (i.e. the actual date of birth) is shown as normal event (i.e. with location ###) in the calendar, the event list and the next event marquee.

Add System Check

Use ext/calendar?

Since we do not really need date-time calculations, it might be preferable to use ext/calendar instead of ext/date. This would also drastically increase the support range of dates.

Set focus to added event

If an event is added, it is added to the end of the list, so the user has to scroll down to fill out the fields. At the very least, the focus should be set to the added event.

Don't require Fa_XH

That is just a mess, unfortunately.

XH 1.7: Plugin administration is not available

Again, due to cmsimple-xh/cmsimple-xh#21.