cmdotcom/text-sdk-javascript

Javascript SDK to send messages with CM.com

text-sdk-javascript's Issues

Axios is vulnerable

Can you bump axios to fix this vulnerability? GHSA-wf5p-g6vw-rhxx

Generic test issue

Customgrouping 1 is accidently used for SDK value

See https://github.com/cmdotcom/text-sdk-java/issues/25 for the same issue.

Telegram is not added as an available medium

Looking at this code: Array of channels

You can notice Telegram is missing while its added to other sdk's.

Support for newer Node.js versions, and moving away from request dependency

We've got a report, that in newer version of node.js, http doesn't contain the ClientResponse anymore.

See this issue for extra information:
request/request#678

Request is also used as dependency, which is out-of-service for a while now.

Calling sendTextMessage after sending MMS causes message to be incorrectly sent as MMS

Expected result:
Message should be sent as SMS anytime you call sendTextMessage. I'm seeing in the console that the message is being sent as an MMS.

I think the cause is that I previously sent an MMS and CM is somewhere remembering that my allowedChannels is ["MMS"].

I'll submit a pull request shortly.

request is deprecated and vulnerable

This package depends on request which

• has been deprecated request/request#3142
• has a vulnerability GHSA-p8p7-x288-28g6

request should be replaced by an alternative.

Throwing response instead of error

The SDK is throwing the response when a request fails, while an error is expected.

const send = async () => {
  try {
    const client = new CM.MessageApiClient('token')

    const result = await client.createMessage().send()
  } catch (e) {
    console.log(e) // this is a http response

    throw new Error(e.body.messages[0].messageErrorCode, e.body.messages[0].messageDetails)
  }
}

why WhatsApp interactive not implemented?

why WhatsApp interactive not implemented?