cmsgov/ato-blueprint

ato-blueprint's Issues

Exception Thrown Selecting FISMA Impact Level to Edit

Describe the bug as a Story

As a system owner, in order to properly categorize my system with a FIPS-199-styled review and select the relevant controls and potentially tailor them, I would like to select the impact level of my system (even if it already is low) and review that to adjust it accordingly.

Using 22c6106, I try to create a new system with "General IT System ATO for 800-53 (low) " startpack. When selecting the gear next to FISMA Impact Level: Undetermined, the service throwns an exception and presents a stacktrace.

To Reproduce
Steps to reproduce the behavior:

1. Checkout current develop branch at revision 22c6106
2. Login with dynamically generated admin credentials
3. Create a new system from the "General IT System ATO for 800-53 (low) "
4. Click the gear next to FISMA Impact Level
5. Get a stack trace

Django stack trace in copy-paste mode

Environment:


Request Method: GET
Request URL: http://localhost:8000/projects/2/general-it-system-ato-for-800-53-low-2/settings

Django Version: 3.2.5
Python Version: 3.8.10
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.staticfiles',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.messages',
 'django.contrib.humanize',
 'django.contrib.admindocs',
 'django.contrib.postgres',
 'session_security',
 'bootstrap3',
 'allauth',
 'allauth.account',
 'allauth.socialaccount',
 'simple_history',
 'rest_framework',
 'django_json_widget',
 'debug_toolbar',
 'django_extensions',
 'htmlemailer',
 'notifications',
 'dbstorage',
 'guardian',
 'siteapp',
 'guidedmodules',
 'discussion',
 'controls',
 'system_settings',
 'loadtesting',
 'nplusone.ext.django']
Installed Middleware:
['querycount.middleware.QueryCountMiddleware',
 'nplusone.ext.django.NPlusOneMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'whitenoise.middleware.WhiteNoiseMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'siteapp.middleware.HealthCheckMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'simple_history.middleware.HistoryRequestMiddleware',
 'session_security.middleware.SessionSecurityMiddleware',
 'debug_toolbar.middleware.DebugToolbarMiddleware',
 'siteapp.middleware.ContentSecurityPolicyMiddleware',
 'guidedmodules.middleware.InstrumentQuestionPageLoadTimes']



Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/dist-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.8/dist-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/usr/src/app/siteapp/views.py", line 886, in g
    return f(request, project)
  File "/usr/src/app/siteapp/views.py", line 1174, in project_settings
    'system_info_edit': system_info_edit,

Exception Type: UnboundLocalError at /projects/2/general-it-system-ato-for-800-53-low-2/settings
Exception Value: local variable 'system_info_edit' referenced before assignment

Expected behavior
I want to be able to edit the impact level of the system.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10
• Browser Firefox (Updated prior to testing and bug report)
• Version [e.g. 22]
• Virtual Machine? Kind of, WSL, Docker-Desktop, and docker-compose

Developer hints

TBD, I will investigate further later.