cmtrounce/swurl

Lightweight and customisable async image loading in SwiftUI. Supports on-disk storage, placeholders and more!

swurl's Issues

Image not loading on beta 5

Hi,

here's pretty much how I use your lib: https://gist.github.com/benclanet/a5a02e613c344d0af888859c42a16001

What happens is a blank view. When I activate the logs, I do see Image successfully retrieved from url:...

Any idea what could be wrong?

Thank you!

Result url not present in handleDownload

Here is the view:

var body: some View { VStack(alignment: .center, spacing: 16, content: { Spacer() HStack { Spacer() RemoteImageView(url: contact.iconUrl(), placeholderImage: Image.init("ministry_logo"), transition: .custom(transition: .opacity, animation: .easeOut(duration: 0.5))).frame(width: 100, height: 100, alignment: .center) Spacer() } }) }

When enabling logging, this is the message I get: "Result url not present in handleDownload" which obviously is not obvious at all. What I am missing here?

Image download progress indication

Aspect Ratio?

How to control aspect ratio of final image?
Do I need "monkey-patch" TransitioningImage?

Update to beta 6

Update to compile / run on beta 6

Problem of : Argument labels '(_:)' do not match any available overloads

Hello ! I just installed the library and created an image but i received this error :
Argument labels '(_:)' do not match any available overloads
This is my code :

import SwiftUI
import SwURL

struct ContentView: View {
    var body: some View {
        VStack {
            Text("Hello World")
            RemoteImageView(url: URL("https://placeholder.com/150")) // the error appears here
        }
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

Crash in RemoteImage.swift

I've got around 100 crashed last week on:
Fatal error: Attempted to read an unowned reference but object 0x281a63d90 was already deallocated2019-09-09 12:53:13.434243+0300[14534:1447031] Fatal error: Attempted to read an unowned reference but object
on 34 String in RemoteImage.string

Prefetch images?

It’s often the case that in the case of a long list we want to start pre-fetching images so users don’t have to see the placeholder view. It would be great to have an imperative way to do that and cache them to the configured cache.

RemoteImageView Bug in 0.4.1

When attempting to use RemoteImageView with 0.4.1 I got the following error, “Static method 'buildBlock' requires that 'SwURL' conform to 'View'”. When I changed to 0.4.0 the error message went away.

Persistent storage restricted to URL lastPathComponent only

Hi,

Thanks for the project. this is not a bug but since i have the same name of images from the network from difference server locations, persistent storage seems to show the same image over. If there can be a way to specify the directory also, it would be helpful.

Like in the file Cache ->PersistentImageCache.swift

   private extension PersistentImageCache {  
       func storageURL(for imageURL: URL) throws -> URL {
           return FileManager
               .cachesDir()
               .appendingPathComponent(imageURL.lastPathComponent)
       }
   }

to include the directory component also from the URL.

Is there a way to return a view instead of an Image as the placeholder

To add something like a progression animation circle as a placeholder

Loading 100+ images causes exc_bad_access sometimes

I'm showing 100 + images in a List and sometimes getting this error. What could be the problem? Can you help me please?
Tested on simulator iPhone 12 (iOS 14.5) and device iPhone 12 Mini (iOS 14.6).

Code is similar to this format

List{
                ForEach((0..<500), id: \.self) {
                  index in
                  HStack{
                    RemoteImageView(url: URL(string:"https://picsum.photos/200/300")!)
                    RemoteImageView(url: URL(string:"https://picsum.photos/200/300")!)

                  }

                }
              }

Are you considering disk cache to be a feature?

Image not displaying correctly inside a Navigation item

If you use the image inside a navigation item it displays as a blue rectangle. The following modifier is required on the image to prevent this issue .renderingMode(.original),

An example is shown below

TransitioningImage.init(placeholder: placeholderImage?.resizable().renderingMode(.original),
finalImage: remoteImage.load(url: url).image?.resizable().renderingMode(.original),
transitionType: transitionType)
}