codam-coding-college/42-typos

Ticketing repo to track and report issues for subjects, evaluation sheets, ... For now this repo only focuses on Codam's cursus.

42-typos's Issues

Add table to state allowed functions for ft_malcom

Project Name
ft_malcom

What is the issue
It displays everything, like #21 using bullet points instead of a nice table

Expectation
Use a table instead.

get_next_line libft authorization should be displayed nicer

Project Name
get_next_line

What is the issue
get_next_line should add a table entry that libft is not authorised instead of writing a bullet point.

Expectation
Have it a nice table to be more obvious and have all the info in one place.

Bombermans description is french

** NOTE: PLEASE ACTUALLY FILL THIS IN AND DON'T JUST DISCARD IT**

Project Name
Bomberman

What is the issue
bomberman's description is in french, holygraph included.

Expectation
Get rid of the french.

Minitalk displays a bunch bullet points instead of a nice table

Project Name
Minitalk

What is the issue
Some projects give a nice table stating what is allowed and what isn't for libft these are just bullet points ?

This includes libft authorization.

Expectation
Make sure throughout core we use a table to display properly what is allowed and so on.

Hypertube mentions an author file

Project Name
Hypertube

What is the issue
hypertube mentions an author file.

Expectation
Old stuff from long before, yeet it

Broken link for total-perspective-vortex

Project Name
total-perspective-vortex

What is the issue
The link of where to get the EGK data is just broken and leads to a 404, big oof.

Expectation
Find the EKG data and add it to the attachments instead.

Typos in Libft subject

Project Name
Libft

What is the issue

• On page 5 under the fifth bullet point it says "every .c files", this should be "every .c file".

• On page 6 in the informational section it says "It is therefore forbidden to include it in your own prototypes ...", this should be "It is therefore forbidden to include in your own prototypes ...".

• On page 7 under the ft_strjoin description it says "Allocates (with malloc(3)) and returns a new string, which is the result of the concatenation of ’s1’ and ’s2’.", this should be "Allocates (with malloc(3)) and returns a new string which is the result of the concatenation of ’s1’ and ’s2’."

• On top of page 11 it says "Functions to manipulate memory and strings is very useful.", this should be "Functions to manipulate memory and strings are very useful."

• At the bottom of page 11 it says the following about linked lists: "next: The address of the next node, or NULL if the next node is the last one.", if I understand the concept of a linked list correctly this should be "next: The address of the next node, or NULL if this node is the last one."

• On page 12 in the description of ft_lstadd_front it says "The address of a pointer to the node to be added to the list.", but the corresponding argument is *new, so this should say "A pointer to the node to be added to the list."

• On page 13 in the description of ft_lstadd_back the same problem happens as with ft_lstadd_front.

• On page 13 in the description of ft_lstdelone it says this: "Takes as a parameter a node and frees the memory of the node’s content using the function ’del’ given
  as a parameter and free the node. The memory of 'next’ must not be freed.", I find this a bit confusing, I would suggest rewriting it as "Takes a node as parameter and frees the memory of
  the node’s content using the function ’del’ given
  as a parameter and free's the node. The memory of
  ’next’ must not be freed."

• On page 13 in the description of ft_lstclear it says about the first argument "The address of a pointer to a node.", shouldn't this be "The address of a pointer to the first node."?

• On page 14 in the description of ft_lstiter it says "The address of the function used to iterate on
  the list.", this should be "The address of the function used to iterate over the list."

• On page 14 in the description of ft_lstiter it says "Iterates the list ’lst’ and applies the function
  ’f’ on the content of each node.", this should be "Iterates the list ’lst’ and applies the function
  ’f’ to the content of each node."

• On page 14 in the description of ft_lstmap there are the same typos as in ft_lstiter.

Expectation
See the section above

Additional context
I have nothing more to say

42Typos Typos

Project Name
Not applicable.

What is the issue

In the FAQ section under "I found a typo!".
I think "stumble upon an issue", instead "stumble on an issue", is a nicer way of wording that sentence.

In the FAQ section under "I have a question rather than an issue?".
"A: Then ask you peers instead, this just for actual issues that can be seen on either the PDFs or Evaluation sheets."

"you" and "just", should probably be "your" and "is".

Expectation
"A: Then ask your peers instead, this is for actual issues, that can be seen on either the PDFs or Evaluation sheets."

Additional context

You could probably, also add a few commas in the description of the repo, to make it more readable.

doom_nukem issues

Project Name
doom_nukem

What is the issue

• It mentions an author file
• Has a typo and grammar issue: 'PLenty' & 'You can play in network with other players'
• References to wolf3d from old cursus

Expectation
Be more up to date.

OpenProject's description is in french

Project Name
OpenProject

What is the issue
Its all French...

Expectation
No french :)

Small typo in shaderpixel

Project Name
shaderpixel

What is the issue
Typo in this sentence: "and really work in the space of the graphic card."

Expectation
Instead: "... and really work in the space of the graphics card."

Typo in Libft subject

Project Name
Libft

What the issue
On page 3 under the ninth bullet point it says defence, this should be defense

Expectation
See above section

One of minitalk's bonus is utterly useless

Project Name
Minitalk

What is the issue
Minitalk's unicode bonus is not bonus worthy because the way the project is solved automatically solves the bonus (The bytes are sent bit by bit which also works for unicode)

Expectation
Come up with a new bonus, due to how minitalk is solved the bonus is automatically completed.

miniRT subject says to "return" a string when an error is encountered

Project Name
miniRT

What is the issue
On page 6 the subject seems to suggest that when an error is encountered when parsing the scene file the program should "return" the string "Error\n"

Expectation
Returning a string makes no sense in this context, it should instead say to print or write the string "Error\n" and possibly further specify the appropriate output stream to write the string to.

Additional context
None

Issues in ft_containers

Project Name
ft_containers

What is the issue

• 'iterators_traits' should be 'iterator_traits'
• a main.cpp is given, and there's a line with "should be constant with the same seed". On my machine this always returns 0, and that's not what's supposed to happen. It should give a seed-dependent number, and it should also be dependent on a functioning insert and access.
• Containers is too much to evaluate thoroughly. The user can supply tests, but then you have to check if the tests cover everything. It needs to have something like a moulinette or be split up in multiple projects.

Expectation
Fix the existing typos.
Somehow make the evaluation easier.

CPP PDF & Evaluation sheet issues

This is a pinned issue to track and discuss all the issues regarding the CPP evaluation sheets.

Simply state below what is bad or needs to be addressed!

Issues:

• CPP 02, EX02: Moulinette does not test for values from 91 - 96, letting you pass if you simply check if the char is between 65 and 123
• CPP 05, Page 8: Stupid typo "... higher or egal ...". Should be 'equal' not 'egal'
• CPP 07 EX01: the subject says 'The third one is a function that will be call on every element of the array.' it's unclear what the exact type of that function should be. Should it return something? Should it be able to change an element in place?

Project typo in Zappy

Project Name
Zappy

What is the issue
Zappy's subject says "A server developped in C on the school dump will have to manager the world and its population", clearly a typo ...

Expectation
manager -> manage

Webserv external functions in subject pdf

Project Name
Webserv

What is the issue
Page 4, table section "External functs."
Lists a few functions, but not everything that is needed. For example, for generating directory listing, you'll need readdir and opendir and for cgi you'll probably need something from the exec family, but none of those are mentioned.

Expectation
The list should be updated with at least:

readdir, opendir, execv/excecve

Or the whole section could be removed? (maybe better, see "additional context")

Additional context
A lot of people seem to be under the understanding that in any c++ projects you can ignore the "external functions" section and use all from standard C library (see this thread for example, but I've heard it before multiple times)

Dir root is actually an alias - webserv

Project Name
webserv

What is the issue

Expectation
What the line refers to as "rooting" is actually a different directive calling "aliasing"

Additional context
Reported by mjiam

Typo in Common Instructions

Project Name
Libft

What is the issue
On page 3 under the seventh bullet point it says librairies.

Expectation
This should be libraries.

42run's details are all in french

Project Name
42run

What is the issue
42run's description is in french, including its objectives (subject page).

Expectation
Yeet the french, again ...

Webserv configuration file section

Project Name
Webserv

What is the issue
Unclear requirements in section III.3 Configuration file

Expectation (-s)
Change 2nd bulled point:

• Setup the server_names or not

to:

• Setup server_names

Since the "you should be able to" line that introduces this list already makes everything listed optional from the config file perspective (as in, you have to implement it, but not every config file has to have it)
The "or not" makes it ambiguous whether you have to implement this at all or not...

---

Change 4th bullet point:

• Setup default error pages

to:

• Setup custom error pages

Since the "default error pages" are already set in section III.1 Requirements

Additional context

Internship 1 eval sheet error.

Project Name
Internship I https://projects.intra.42.fr/scale_teams/4629895/edit

What is the issue
Header: Highlight of the qualities

The whole second paragraph under this header is unclear to me, and contains some grammar and general logical mistakes.

Expectation
I'm not even sure what it's supposed to say, so no.

Additional context

The formulation of camagru's description needs to be improved

Project Name
Camagru

What is the issue
camagru's description could be formulated slightly better, its also missing a period at the end.

Expectation
E.G:
This project is a warmup for the web. You will need to realize a small instagram-like website allowing its users to create and share photomontages. You will, from scratch of course, implement basic functionalities used by any website with a user base.

Subject PDF for xv has a line that overflows

Project Name
xv

What is the issue
Some text is overflowing beyond the bounds of the pdf

Expectation
Shorten it or add a newline

miniRT example scene has an invalid camera orientation

Project Name
miniRT

What is the issue
On page 8 an example scene file is provided

And on page 6 the expected format for the camera description is specified

It says the third column should contain a normalized (with a magnitude of 1) camera orientation vector. But the orientation vector from the example scene file has a magnitude of 0 and is thus not facing in any direction.

Expectation
The camera in the example scene should have an orientation vector with a magnitude of 1, for example 1.0,0.0,0.0

Additional context
The fact that the vector has to be normalized makes it difficult to specify anything except for orthogonal vectors, as most other vectors will require irrational numbers that cannot be specified with a finite number of digits. Even for the vectors that can be represented using a finite number of digits any check to see if their magnitude is exactly equal to 1 could fail due to floating point rounding errors. Perhaps the subject should be more lenient in what to allow for the orientation vector.

rt's description is outdated

Project Name
rt

What is the issue
rt's description references rtv1 which is part of the old 42 cursus

Expectation
Maybe change to miniRT instead?

French style typo in Philosophers ("Your(s)")

Project Name
Philosophers

What is the issue
Page 6, second point: "Your(s) program(s) should take the following arguments: ... "
The '(s)' behind 'Your' should not be there. It's not French.

Expectation
"Your program(s) should take the following arguments: ... "

Additional context
Just a French smell again.

Electroencephalographic in Total Perspective Vortex

ADVANCED
Total Perspective Vortex in AI & ML branch

On the front page -> summary: electoencephalographic needs to be electroencephalographic

MiniRT typo functionnal (core) (subject)

Project Name
miniRT

What is the issue
Page 2 of subject pdf, text underneath the photos: it says 'functionnal'. That's one n too much.

Expectation
Should be functional instead of functionnal.

Additional context
Minor issue but I smell a French vibe around this word.

Allow typescript in camagru

Project Name
camagru

What is the issue
camagru should also allow typescript as an alternative to javascript (still javascript, with a few extra steps)

Expectation
Allow typescript, depends on 42 Pedago if they agree (they honestly should)

Internship II's description has a typo

Project Name
Internship II

What is the issue
Internship II's description has a typo: "Your 42 training should ends (<- here) on a professional..."

Expectation
It should be: "Your 42 training should end on a professional ... "

Typos in guidelines on eval sheet

Project Name
This issue is a collection of typos in the guidelines section on libft's eval sheet, but I think the guidelines are pretty similar for every eval sheet in the core

What is the issue

• Under guidelines: "... work that was turned in the Git ..." -> "that was turned in in the Git".

• Under guidelines, third point: "... no malicious aliases was used ..." -> "... no malicious aliases were used ..."

• Under guidlines, fourth point: move the word togehter to the end -> "... the grading (scripts for testing or automation) together."

• Under guidelines, ninth point: Also move together at the end of the sentence -> "... are strongly encouraged to review the work that was turned in together."

Expectation
See the section above

Additional context
None

ft_newton's description is pretty bad

Project Name
ft_newton

What is the issue
The description seems like its been written at 4am

Expectation
E.G:

"Let’s make things fall to the ground! In this project you will program a basic physics engine complete with motion, gravity and collisions"

getnameinfo not allowed in ft_ping

Project Name
ft_ping

What is the issue
page 3, the allowed functions do not include getnameinfo, which is needed to get the host name of the ip address you are contacting.

Expectation
getnameinfo in the list of allowed functions.

Additional context
Try ping www.google.com on a linux system, which is required by the subject, the output will be in terms of 64 bytes from ams17s10-in-f14.1e100.net (142.250.179.142), the ams17s10-in-f14.1e100.net part is gotten through use of getnameinfo. This is not required to make the rest of the ping work, just for more informative output, just like the real ping :) also this function does not circumvent other parts of the project (as far as I am aware...).

NetPractice: typo and vague/double instruction in subject pdf

Project Name
NetPractice

What is the issue
Two issues:

• Typo: page 8, line of text before last pink block: "During defense, you will have to succeed 3 random levels as mentionned on the training platform."-> Should be mentioned instead of mentionned.
• Page 6, halfway the page where the buttons are being described: "Get my config to download your configuration whenever you need to. It will be useful to turn in your assignment." Later on that page, it says you NEED these configurations. A.k.a., it is not "useful" as mentioned, it's necessary when turning in your project.

Expectation

• Mentionned should be mentioned.
• "It will be useful to..." should be "You need this configuration in your Git repository when you turn in your project" (or something like that.)

Additional context

mesured in Total Perspective Vortex

ADVANCED
Total Perspective Vortex in AI & ML branch

Page 5, General Instructions
Line 2: The data was mesured

Expectation
The data was measured

Minishell evalsheet regarding exit test

Project Name
Minishell

What is the issue
The evalsheet asks the evaluator to test the exit builtin with and without arguments, while the command explicitly asks to implement it without arguments.

Expectation
Remove the confliction between what is required in this case.

Typo in Libft subject

Project Name
Libft

What is the issue
On page 6 on the top of the page it says behaviors/

Expectation
I think this should be behaviours, I prefer British English.

Unecessary page for pdf due to instructions

Project Name
All of them (mostly core)

What is the issue
The common instructions are just ever so slightly too long causing the pdfs to have a whole new page with literally just like a sentence on it.

Expectation
Somehow reduce or simplify sentences to fix this.

doom_nukem's description is in french as well as its objectives.

Project Name
doom_nukem

What is the issue
More french stuff, ew.

Expectation
Write it in english.

ft_linux's packages are all bullet points

Project Name
ft_linux

What is the issue
ft_linux's packages to install list should be a table with two entries instead of a giant bullet point list.

Expectation
Insert the entries into a nice table

Additional context
Add anything else you have to say about this issue.

Projects with missing periods in their description.

• nibbler
• snow-crash
• strace (Typo: "First step in a serie of projects ...")
• ft_ping
• ft_malcom
• particle-system
• ft_turing
• lem_in
• ft_linux
• process-and-memory
• kfs-4
• ft_hangouts

matt-daemon's description could be improved

Project Name
matt-daemon

What is the issue
matt-daemon's description could be improved:

Expectation
E.G:
A Unix project whose goal is to create a server type daemon. This server will then listen on a given port and interpret a list of commands.

Internship eval sheet assumes the content is a video instead of presentation

Project Name
Internship I

What is the issue
Internship eval sheet assumes the content is a video instead of presentation.

Expectation
Assume its a video instead

darkly's description is entirely in french

Project Name
darkly

What is the issue
darkly's entire description (including skills and objectives) is in french.

Expectation
You know the drill, yeet the french.

typos and general style flaws in C piscine exam g_diam

** I ACTUALLY FILLED IT IN **

Project Name
C Piscine Final exam

What is the issue
1: Write a programe that takes a string.
2: For exemple, if there is a link between nodes ... as "2-3" or "3-2"

Expectation

1. Replace programe with program (and not programme, because later on it says program)
2. Replace exemple with example

Additional context
Please just rewrite the exercise Leon, fixing the typos will not fix the shitty writing

Unclear testing for inception bonus in eval

Project Name
Inception

What is the issue
The bonus part of the inception evaluation has almost nothing in it.

Expectation
It should for example give you a clue about how to test that the ftp server is set up correctly. The subject itself is also very minimal. Should the ftp server do anything else than point at a volume?

Woody eval sheet typo

Project Name
Woody

What is the issue
Woody's evaluation sheet says 'choice of alorithm'

Expectation
Add the missing 'g'

Typos in libft eval sheet

Project Name
Libft

What is the issue
• In the mandatory part evaluation it says "LibC".

Expectation
It should be "Libc"

Additional context
None