code42/pg_sequencer

Create and dump postgres sequences in your Rails app!

pg_sequencer's Issues

PostgreSQLAdapter#sequences does not respect namespace

We have sequences that are in the public and in bdr namespace. All of them are listed with the query

sequence_names = select_all("SELECT c.relname FROM pg_class c WHERE c.relkind = 'S' order by c.relname asc").map { |row| row['relname'] }

(From https://github.com/code42/pg_sequencer/blob/master/lib/pg_sequencer/connection_adapters/postgresql_adapter.rb#L71)

This causes the subsequent query

row = select_one("SELECT * FROM #{sequence_name}")

to fail for the sequences that are not in public

IMHO the first query should be extended to include the namespace

sequence_names = select_all("SELECT c.relname, n.nspname FROM pg_class c inner join pg_namespace n on c.relnamespace = n.oid WHERE c.relkind = 'S' order by c.relname asc").map { |row| "#{row['nspname']}.#{row['relname']}" }

Feedback?

Adds duplicate sequences to schema.rb

When using pg_sequencer, the primary key sequences are also added to schema.rb, but they are automatically created as part of create_table. Running rake:db:setup fails because Rails tries to create sequences foo_id_seq that already exist.

Indicate that this project is unmaintained

As maintainers have moved on, we are no longer providing support for this project. Add a note in the README.md for potential viewers to see.