Giter Site home page Giter Site logo

typecov's Issues

Comparison should use rounded values

Currently the comparison used for success/failure compares the unrounded values before they are formatted for display:

https://github.com/codechecks/typecov/blob/master/src/index.ts#L47

As a result, situations are possible where the rendered percentages are the same but the check fails.

Example:

### Current type coverage: 95.00%

Minimum acceptable type coverage: 95.00% โ€” ๐Ÿ”ด

atLeast: 95
headTypeCoverage: 94.999

Another example:

### Current type coverage: 40.63%
Minimum acceptable type coverage: 40.63% โ€”ย ๐Ÿ”ด

correctCount: 26
totalCount: 64
headTypeCoverage: 40.625

Typecov warns on try/catch error

Hey,

Typecov warns on the catch(e)

try {
 throw new Error()
} catch(e) {
  console.log(e);
}

But Typescript warns with this Catch clause variable cannot have a type annotation

Typecov should ignore catch

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.