coderacademy-bri/ruby-challenges

ruby-challenges's Issues

Review comments for time_and_bar challenge

You did a great job with your solutions to this challenge. I'll just give some feedback here.

I like your solution with arrays - it was unexpected for me. I wouldn't have thought to solve it by creating arrays with a number of items that match the number of drinks ordered. It would get to be an expensive solution with large amounts of data, but it is creative :)

Your solution with a Drink class is really nice. You demonstrated you can use classes, and there is just one piece of feedback I have to help you grow in understanding. You defined drinklog as an instance variable in your class but you don't use it, instead you actually keep track of it in your main program. One thing to consider is whether or not you should keep track of a drink order in the drink class, and the answer is really that you shouldn't. You could create another class called DrinkOrder, and use it to keep track of the order, including what drinks are in the order and cost, price, and profit.

We can chat about it if it doesn't make sense :)