codesandbox/codesandbox-importers

All importers & exporters for CodeSandbox

codesandbox-importers's Issues

Latest version: No matching version found for codesandbox-import-util-types@^2.1.15

A full log: https://dev.azure.com/ng-alain/delon/_build/results?buildId=722&view=logs&j=55c92ae3-580a-5925-0d87-c675b0db0713&t=dfea2e9c-fac5-59f6-6794-f56d969b636e&l=6713

grcov = "0.5.15"

Originally posted by @roundnutz14 in microsoft/AADConnectConfigDocumenter#30

posibility of a 2.2.4 release with updated axios

Hi, @CompuIves @sbinlondon,

Issue Description

I noticed that a vulnerability is introduced in [email protected]:
Vulnerability CVE-2020-28168 affects package axios (versions:<0.21.1): https://snyk.io/vuln/SNYK-JS-AXIOS-1038255
The above vulnerable package is referenced by [email protected] via:
[email protected] ➔ [email protected]

Since [email protected] (3,338 downloads per week) is referenced by 93 downstream projects (e.g., @patternfly/react-docs 4.21.35 (latest version), trafimage-maps 1.5.36 (latest version), @antv/gatsby-theme-antv 1.1.8 (latest version), storybook-addon-preview 2.1.2 (latest version), mobility-toolbox-js 1.3.5 (latest version)), the vulnerability CVE-2020-28168 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1)@antv/[email protected] ➔ [email protected] ➔ [email protected]
(2) @pxwlab/[email protected] ➔ [email protected] ➔ [email protected]
......

If [email protected].* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from [email protected] ?

Fixing suggestions

In [email protected], maybe you can kindly try to perform the following upgrade(not crossing major version) :
axios ^0.18.1 ➔ ^0.21.1;

Note:
[email protected](>=0.21.1) has fixed the vulnerability CVE-2020-28168.

Thank you for your attention to this issue.

Best regards,
^_^

https://produto.mercadolivre.com.br/MLB-1162243173-oculos-de-sol-redondo-abre-e-fecha-duas-camadas-unissex-_JM?searchVariation=31682119409#searchVariation=31682119409&position=2&search_layout=grid&type=item&tracking_id=aa204bca-459e-48de-bbb2-c8c570980f13

1982t.me

codesandbox-importers/packages/types/index.d.ts

Lines 24 to 39 in ad37601

	shortid: string;
	title: string;
	directoryShortid: string | undefined | null;
	}
	export type ITemplate =
	| "adonis"
	| "vue-cli"
	| "preact-cli"
	| "svelte"
	| "create-react-app-typescript"
	| "create-react-app"
	| "angular-cli"
	| "parcel"
	| "@dojo/cli-create-app"
	| "cxjs"

_Originally posted by @roundnutz14 in https://github.com/microsoft/AADConnectConfigDocumenter/issues/30_

Originally posted by @roundnutz14 in microsoft/AADConnectConfigDocumenter#30

Originally posted by @roundnutz14 in #82

`getParameters` method in define API requires file content to be a `string` in TypeScript

The getParameters method currently requires the value under content (which is a property of a file) to be a string:

codesandbox-importers/packages/import-utils/src/api/define.ts

Line 6 in e68dcdd

content: string;

But in the docs, it's specified that content under package.json can be an object.

Either the documentation or the type signature on getParameters should be updated accordingly. I currently can't use an object in TS.

Please support HTTP proxy settings

codesandbox doesn't seem to support HTTP proxies. For those of us behind corporate networks, this can be painful.

Ideally, codesandbox would look at the following environment variables in order to determine proxy settings:

FTP_PROXY
HTTP_PROXY
HTTPS_PROXY
ftp_proxy
http_proxy
https_proxy
no_proxy
NODE_TLS_REJECT_UNAUTHORIZED

Additionally, command-line parameters to control proxy behavior would also be useful.

CLI fails to deploy on Windows because of backward slashes in file paths

The path methods in Node output \ paths on Windows, so the directory modules object will end-up looking like this for a just created create-react-app project:

[ 'public\\index.html',
  'public\\manifest.json',
  'src\\App.css',
  'src\\App.js',
  'src\\App.test.js',
  'src\\index.css',
  'src\\index.js',
  'src\\registerServiceWorker.js',
  '.gitignore',
  'README.md',
  'package.json',
  'yarn.lock',
  'src\\logo.svg',
  'public\\favicon.ico' ]

This is a problem because the rest of the code has hard-coded Unix paths with forward slashes, so when it tries to find the default main file of 'src/index.js` it will fail. A minimal solution could be as simple as this:

diff --git a/packages/import-utils/src/create-sandbox/index.ts b/packages/import-utils/src/create-sandbox/index.ts
index 4f41c0a..8282178 100644
--- a/packages/import-utils/src/create-sandbox/index.ts
+++ b/packages/import-utils/src/create-sandbox/index.ts
@@ -67,7 +67,8 @@ export default async function createSandbox(
   const packageJsonPackage = JSON.parse(packageJson.content);
 
   const template = getTemplate(packageJsonPackage, directory);
-  const mainFile = findMainFile(directory, packageJsonPackage.main, template);
+  const mainFileUnix = findMainFile(directory, packageJsonPackage.main, template);
+  const mainFile = process.platform === "win32" ? mainFileUnix.replace(/\//g, "\\") : mainFileUnix;
 
   if (!directory[mainFile]) {
     throw new Error(

I'll push a PR so that we can take the technical discussion there.

Also, when it fails because of this it does throw an Error, but the console message Uploading files to CodeSandbox keeps going, giving the false impression that the process can still continue, when it is actually hanged.

(apparently no one is using the CLI on Windows? 😅 )

Separate pull request info endpoint

Per this message thread: https://codesandboxapp.slack.com/archives/CHM6FA0TA/p1619782410183900?thread_ts=1619780139.183000&cid=CHM6FA0TA

• make pullInfo a separate endpoint in the importer, so we call /pullInfo/:username/:repo/pull/:pullNumber instead of /info/:username/:repo/pull/:pullNumber and we'll prevent conflicts with the import sandbox endpoint

Additionally, we do want to be able to import a specific PR's files as a sandbox, so work should be done on the server afterwards to make sure this is happening.

Can't import this Github repository

If I use the CodeSandbox importer directly by visiting https://codesandbox.io/s/github and pasting in https://github.com/miquelvir/centrifuga4, it fails.

"Something went wrong. Unable to import sandbox at the moment. Please try again later."

original issue: dferber90/githubbox#9 (comment)

Blue is undefined

When trying to deploy my directory via

yarn global add codesandbox
codesandbox ./

I am receiving this error:

/Users/sam/.config/yarn/global/node_modules/codesandbox/lib/utils/log.js:10
    console.log("  " + chalk_1["default"].blue.bold("Code") + chalk_1["default"].yellow.bold("Sandbox") + " " + chalk_1["default"].bold("CLI"));
                                          ^

TypeError: Cannot read property 'blue' of undefined
    at Object.logCodeSandbox (/Users/sam/.config/yarn/global/node_modules/codesandbox/lib/utils/log.js:10:43)

Using node v10.7.0 (npm v6.2.0)

Cli fails to wait for user to input token on WSL

On Windows Bash (WSL), after clicking yes to "We will open CodeSandbox" and then yes to "We will open CodeSandbox to finish the login process", it shows a link to the login but the browser doesn't load. It also doesn't work manually as the program exits before allowing the user to input a token.

The browser probably isn't launching because on WSL, windows apps must have .exe appended like chome.exe. I'm able to click on the provided link, log into Github and get a token, but unfortunately I can't input it because the program has already exited.

Ability to set entry file name

By default, the entry file needs to be named index.js however others might name it main.js or even index.jsx (different extension name). Would it be possible to specify the full file name in an input field for the entry file?

Just a feature to be considered. I love the project and the site and am really looking forward to seeing it grow as a platform.

CLI says project to big, then fails to stop.

Hi,

I'm using the CLI and it gave me this error trying to import my project:

[error] This project is too big, it contains 595 files which is more than the max of 120.

And it then continues to show

Uploading files to CodeSandbox

That seems to be a bug in the CLI.

I've also become a patron to lift limits. Granted, I've chosen the lowest payment ($5 a month) and I'm still stuck with the same hurdles to get my code uploaded to CodeSandbox. Are there different levels of patronage? Are different limits lifted with different patron contributions? Needless to say, if there is, it is all less than transparent. That also needs fixing.

Scott

Upgrade update-notifier to v6.02 to fix a vulnerability

got: missing verification of requested URLs allows redirects to UNIX sockets [services-management-platform-default] fixed in sindresorhus/got#2047

Can't import github repository to codesandbox

When I try to import subdirectory from github it says the package.json file doesn't exist. But directory has package.json

Is is possible to update existing Sandbox with the CLI?

I'd like to put some example code to CodeSandbox but I do edit and maintain it with vscode and git and just to deploy it to CodeSandbox. Is is possible to do that without generating new CodeSandbox URL? Thanks.

[Feature Request] Add a means of indicating a "node" project

Currently, when the template of a project cannot be inferred via a big stack of conditions, create-react-app is chosen as a default.

https://github.com/codesandbox-app/codesandbox-importers/blob/079f9528017b2a73739f42ba29571f9f049c8119/packages/import-utils/src/create-sandbox/index.ts#L64

Particularly with the new server-side evaluation support, this may not be a reasonable or safe default anymore. Perhaps node should be the new default, with create-react-app being only reasonable in the presence of react or cra as a (dev)dependency?

Github Import bringing folders out of the path into files

I opened this issue on the client but maybe I should do it here as well:

Description of the problem

When trying to create a sandbox from a Github repo, and in a specific path, instead of only bringing files from the path, it's randomly bringing a folder that is on a directory above the specified path.

The folder marked below should not have been imported (It's in the upper directory):

How has this issue affected you? What are you trying to accomplish?

I'm trying to embed a working example in our guides but the sandbox will not work because of this additional unwanted folder.

To Reproduce

Create a new sandbox using Github import from this path:
https://github.com/Basis-Theory/basis-theory-js-examples/tree/master/collect-cards-with-individual-elements

Link to sandbox: link (optional)

Your Environment

Software	Name/Version
Сodesandbox	Web
Browser	Brave/1.39.111
Operating System	MacOS 12.4

(cli): Misleading usage information

Presently, the usage information that shows up along with the help text is as below:-

Usage: Usage: codesandbox [options] [command]

Expected

Usage: codesandbox [command] [options]

codesandbox-cli import to private project?

Is it possible to import to a private project with the codesandbox-cli?

Is the git-extractor API hosted anywhere?

I was wondering if there's a publicly accessible API based on the git-extractor package?

Seems there's the Define API but it's a bit limited. I'm more interested in being able to hit the /define/git/github/:username/:repo/:branch/commit/:commitSha* endpoint.

Any ideas?

Dev dependencies was not installed as expected

I have a project on github https://github.com/edkalina/jsx-decorator-sandbox. It is ejected creater-react-app project with replaced babel config (It doesn't use create-react-app preset). Also it has patched babel packages in dependencies, specified this way:

{
    "@babel/helper-builder-react-jsx": "https://github.com/edkalina/babel#babel-helper-builder-react-jsx",
    "@babel/parser": "https://github.com/edkalina/babel#babel-parser"
}

Locally it works as expected: patched babel packages are installed and project builds correctly.
But after importing it to codesandbox I can see parsing errors (looks like original babel was used).

Is it a bug? Is my case unsupported?

Is there a way to upload assets in post request without using a URL?

Hello.

I would like to create a CodeSandbox with some assets that are not hosted anywhere using define api.
So I want to use something like Uint8Array and datauri.
As follows.

const parameters = getParameters({
  files: {
    "package.json": {
      content: {
        dependencies: {
          react: "latest",
          "react-dom": "latest",
        },
      },
    } as any,
    "fromDataURI.png": {
      content:
        "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==",
      isBinary: true, // something else
    },
    "fromBuffer.jpg": {
      content: someUint8Array,
      isBinary: true,
    },
  },
});

Is there plan to realize these or any ways which we can be replicated?

RFC: Add Koa to the list of Server Templates

• I was thinking that adding Koa to the templates would be a nice addition to the Server side templates.

• I would personally look into this if there is some interest. It would give me something to get my hands dirty in OSS code for the first time.

Thank you everyone ahead of time.

Gives this error in ubuntu while installing codesandbox cli

CLI Feature request: ignore files

Population of external URLs via define API

Hi,

Is there a way to populate External URL enries via the /define API call as if it was populated in the area in the screenshot?

Thanks in advance?

Respect gitignore when publishing

I often publish a local version of an example I have so that I can revert the changes, but there's some files commonly ignored that I need to remove from the final sandbox, or even prevent the publish if I don't remove them first. A couple examples are:

• dist
• .next

I could see even .env, which would be even more problematic.

When gathering the files to publish, it should first check git to list any files that are ignored in the current repo and not publish those.

I'm happy to do a PR if it's clear where to add these checks + will be approved.

Thanks!

similar issue: #67

Publish Cloud sandbox

Hey there,

I was wondering if there could be an option to publish a sandbox as cloud sandbox.

As far as I can tell, there is only the possibility to publish browser sandboxes. However, via the API it is possible to publish a cloud sandbox (by passing v2: true).

Maybe this could be a configuration in the sandbox.config.json file or maybe as a command flag.

Create sandbox from input stream

fetch('./super.tar')
.then(response => response.body)
.then(body => body.pipeThrough(unpack).pipeTo(createSandbox))

This removes the overhead of writing to file system, by streaming in memory. It also adds flexibility to the API and performance gains.

Thanks for the excellent work @CompuIves and team. Kindly share your thoughts.

Ability to import a sandbox in a team

I can't find any documentation on how to do it

Export via CLI

It would be super helpful to have the ability to not only import, but to export sandbox locally (a la git clone) by running codesandbox <sandboxName> <destination>

The term 'codesandbox' is not recognized as the name of a cmdlet

In windows 10, once I installed codesandbox globally I get the following error

or

Is it possible to specify external dependencies using the Define API

I can see it is possible to add node module dependencies, but is it also possible to add external (non-npm) dependencies when creating sandboxes dynamically via the API?

Issue found

Hello!

@CompuIves We may have found a bug in your repository.

This bug was found while issuing the following command:

curl -D- http://localhost:2000/git/github/info/user/%1F/tree/branch/path

Making this call resulted in the following response:

HTTP/1.1 500 Internal Server Error
Content-Type: application/json; charset=utf-8
Content-Length: 54
Date: Thu, 30 Apr 2020 10:50:44 GMT
Connection: keep-alive

{"error":"Request path contains unescaped characters"}

Making this call resulted in the following stack trace:

TypeError [ERR_UNESCAPED_CHARACTERS]:
Request path contains unescaped characters
    at new ClientRequest (_http_client.js:127:13)
    at Object.request (http.js:38:10
    at Object.request (/src/node_modules/@sentry/node/dist/integrations/http.js:65:18)
    at RedirectableRequest._performRequest (/src/node_modules/axios/node_modules/follow-redirects/index.js:128:24)
    at new RedirectableRequest (/src/node_modules/axios/node_modules/follow-redirects/index.js:54:8)
    at Object.wrappedProtocol.request (/src/node_modules/axios/node_modules/follow-redirects/index.js:252:14)
    at dispatchHttpRequest (/src/node_modules/axios/lib/adapters/http.js:131:25)
    at new Promise (<anonymous>)
    at httpAdapter (/src/node_modules/axios/lib/adapters/http.js:18:10)
    at dispatchRequest (/src/node_modules/axios/lib/core/dispatchRequest.js

To resolve this issue, we recommend URL encoding all paths and queries before making HTTP calls.

Update an existing sandbox

Is there a way to update a specific sandbox with code from my local machine? It looks like the Codesandbox CLI always creates a new sandbox. And the APIs don't seem to have a way to do the same.

Is there a POST https://codesandbox.io/api/v1/sandboxes/:sandbox-id or something?

Thanks!