codesandbox/dependency-packager

dependency-packager's Issues

cannot yarn install on linux

Hi,

I'm the maintainer of Ember Twiddle and I was looking for a way to support dependencies from npm rather than CDNs which work but require packages to be built in UMD. I came across this project and was hoping to see if it worked for us.

Anyway, I cloned it and tried to yarn install and get this error message:

yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The platform "linux" is incompatible with this module.
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

As I understand it, fs-events should be made an optional dependency because it is not needed on non Mac platforms.

Using Ubuntu 18.04, node 12, and yarn 1.22.4

GitHub Dependency: prepare script ignored

I'm trying to use CodeSandbox to verify a fix by installing a dependency directly from a GitHub branch. I've traced the error back to this project:

Could not fetch dependencies, please try again in a couple seconds: Something went wrong while packaging the dependency griddle-react@GriddleGriddle/Griddle#my-branch: ENOENT: no such file or directory, scandir '/tmp/1532470022/node_modules/griddle-react/dist/module'

The package's prepare script is not being executed, probably due to --ignore-scripts?

https://github.com/codesandbox-app/dependency-packager/blob/544b6357c8ac60f6bcb3084527015ade2dafe7a2/functions/packager/dependencies/install-dependencies.ts#L16

I'm wondering if --ignore-scripts is necessary, or perhaps should be avoided for Git/GitHub versions?

Support for tarball URLs?

I have a URL to an npm tarball. I can install it with yarn:

yarn add https://react-canaries-3adg6ifso.now.sh/13886/react

And it also works if I add it to a local package.json file:

"react": "https://react-canaries-3adg6ifso.now.sh/13886/react"

But it doesn't work in CodeSandbox: https://codesandbox.io/s/pmy0470zj7

readme or basic description of how to test/use?

Great work! After reading the article https://hackernoon.com/how-we-make-npm-packages-work-in-the-browser-announcing-the-new-packager-6ce16aa4cee6 I got really inspired and I wanted to dig into this!

I'm currently reading through the codebase, and after attempting to put it all together without context I decided it may be worth a shot just seeing if a simple readme may help to describe parts of what's going on the in the codebase.

Cheers!