codeschool-projects/codebreakerproject

Code Breaker: Challenge Friends with a Game Written using Javascript

codebreakerproject's Issues

! [rejected]

failed to push some refs to gh-pages (non-fast-forward)

Task 11 - why is the first line there?

The first line of task 11 is In our guess function set a variable for the value of the user-guess input., but that input variable is already declared for us in the guess() function.

Markdown doesn't render in task names

First Task Instructions unclear

For the "Create setHiddenFields Function" the instructions are:

Our application uses the answer hidden input to store the answer to the game. Our setHiddenFields method should not use any parameters, but needs to set the awnser hidden input to a randomly generated number between 0 and 9999.

This doesn't specifically say anything about what a student is supposed to do for this step. I recommend something like this:

Create a function named `setHiddenFields` that sets the `answer` variable equal to a randomly generated number between 0 and 9999.

Website instructions don't match GitHub instructions

Instructions on the website (https://www.codeschool.com/projects/build-a-code-breaker-game-with-javascript/build) do not match the instructions on the GitHub README.md (particularly Step 11 and Step 12). The website instructions are wrong and need to be replaced with the repo instructions.

small typo on instructions

small typo on source code comment

Should be implement

https://github.com/codeschool-projects/CodeBreakerProject/blob/master/src/assets/main.js#L9

add quotes to strings in the instructions

Task 8 issue

In the task "Only set the "answer" and "attempt" hidden inputs when they aren't already set", it starts with:

"When we go to call the setHiddenFields functions in our guess function, we should only update our hidden inputs when they're not set."

Should that instead be something like:

"Call the setHiddenFields() function in the body of the guess() function, but also write some logic so that it's only called when answer and attempt haven't already been set."

Typos in most of the failure messages

"function" is written as "fuction"

Formatting issues in some tasks.

Task 11 for example is missing some commas. Also some contraction issues and places where apostrophes are used and shouldn't be.

Website

De

gh-pages instructions: Need to delete branch in your fork first

In the project complete notes it mentions publishing the finished project to GitHub Pages.

In order for

git subtree push --prefix src origin gh-pages

to work, you'll need to delete the gh-pages branch from the initial clone first.

Steps I took:

git checkout -b "gh-pages"
tried to execute subtree push, but was given an error about current tip being behind remote
deleted gh-pages branch in browser
git subtree push --prefix src origin gh-pages

Success!

Success class name for showAnswer function gives false error

I keep getting the following error on submitting my project:

but my code shows that the class name was added:

window.reload() on clicking Play again? button

In index.html file window.reload() function should be called with true attribute, to pull the site from the server, because otherwise it preserves the values of answer, attempt and user-guess inputs.

copy edit on instructions

How about: if validateInput returns false, then use return false to stop execution...

Getting an ES2015-related syntax error when running npm test

CodeBreaker :

Error: Uncaught [SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode]
    at reportException (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:58:24)
    at processJavaScript (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/HTMLScriptElement-impl.js:130:7)
    at HTMLScriptElementImpl._eval (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/HTMLScriptElement-impl.js:65:7)
    at /Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/browser/resource-loader.js:31:22
    at Object.check (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/Document-impl.js:88:11)
    at Object.check (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/Document-impl.js:91:23)
    at Object.check (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/Document-impl.js:91:23)
    at /Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/living/nodes/Document-impl.js:107:12
    at wrappedEnqueued (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/browser/resource-loader.js:255:16)
    at Request._callback (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/lib/jsdom/browser/resource-loader.js:203:9)
    at Request.self.callback (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/node_modules/request/request.js:186:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/node_modules/request/request.js:1081:10)
    at emitOne (events.js:77:13)
    at Request.emit (events.js:169:7)
    at Gunzip.<anonymous> (/Users/jonfriskics/Desktop/CodeBreakerProject/node_modules/jsdom/node_modules/request/request.js:1001:12)
    at Gunzip.g (events.js:260:16)
    at emitNone (events.js:72:20)
    at Gunzip.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:905:12)
    at doNTCallback2 (node.js:441:9)
    at process._tickCallback (node.js:355:17) [SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode]
    setHiddenFields()