codesmithllc/cs-bin-solutions

Solution code to CS Bin Challenges

CS Bin Challenge Solutions

Files

1. callbacks.js (http://csbin.io/callbacks)
2. closures.js (http://csbin.io/closures)
3. oop.js (http://csbin.io/oop)
4. async.js (http://csbin.io/async)
5. functional.js (http://csbin.io/functional)
6. recursion.js (http://csbin.io/recursion)

cs-bin-solutions's Issues

Some error in solutions

// Challenge 7
const intersection = (arrays) => {
return arrays.reduce((acc, curr) => {
return curr.filter(el => acc.includes(el));
});
};

// console.log(intersection([5, 10, 15, 20], [15, 88, 1, 5, 7], [1, 10, 15, 5, 20]));
Uncaught TypeError: curr.filter is not a function

Should be:
const intersection = (...arrays) => {
return arrays.reduce((acc, curr) => {
return curr.filter(el => acc.includes(el));
});
};

and similar error downside :)

Add solution to challenge closure

Hi @WillSen CodesmithLLC

I'm @hendridg ✋, I make this course in frontendmasters.com, and I want to contribute to the solutions of challenges closures.js 🥺

Objects created by userFactory can access sharePublicMessage method

cs-bin-solutions/oop.js

Lines 181 to 188 in 20de7d4

	function adminFactory(name, score) {
	const admin = new userFactory(name, score);
	admin.type = 'Admin';
	return admin;
	}
	/* Put code here for a method called sharePublicMessage*/
	userFunctionStore.sharePublicMessage = () => console.log('Welcome users!');

Above issue is with respect to Extension Question for - http://csbin.io/oop
The code does not prevent userFactory to access sharePublicMessage method.. Instead the solution should be to use Object.create in adminFactory function:

function adminFactory(name, score) {
  // Put code here
  let newAdminObj = userFactory(name,score);
  newAdminObj = Object.create(adminFunctionStore);
  newAdminObj.type = "Admin";
  return newAdminObj;
}

// Put code here for a method called sharePublicMessage

adminFunctionStore.sharePublicMessage = () => console.log("Welcome users!")

potential bug in the comments of the intersection function from challenge 7

Hello,

I started following your course and correct me if I'm wrong but the function intersection expects one parameter arrays which should be of type array.

However in your comment written just below the challenge 7, you pass in 3 arguments.

cs-bin-solutions/functional.js

Line 74 in 20de7d4

// console.log(intersection([5, 10, 15, 20], [15, 88, 1, 5, 7], [1, 10, 15, 5, 20]));

**

I think you might have intended to write:

// console.log(intersection([[5, 10, 15, 20], [15, 88, 1, 5, 7], [1, 10, 15, 5, 20]]));

On a side not, thanks, I quite enjoy the course so far.

missing solutions

Some of the solutions to the challenges are missing.

The solutions that are missing are:

• async.js misses exercises 8,9,10
• callback.js misses 12 up to 24
• closures.js misses 8 up to 19

Not missing anything:

• functional.js doesn't miss anything
• oop.js doesn't miss anything