codeyourfuture / javascript-core-1-coursework-week1 Goto Github PK

JavaScript 100.00%

javascript-core-1-coursework-week1's Introduction

Coursework

Like learning a musical instrument, programming requires daily practice.

The exercises are split into two folders: mandatory and extra. All homework in the mandatory section must be completed for homework by the following lesson.

The extra folder contains exercises that you can complete to challenge yourself, but are not required for the following lesson.

If you think you need to do more practice with the basics, then you can find some more exercises listed in resources.md. These exercises are not mandatory and won't be assigned as part of your coursework for the week.

Setting up your code editor

There are some tools that will help you to write code. One of these, Prettier, formats your code, making it easier for you and others to read.

1. Install prettier

In Visual Studio open the extensions panel (see https://code.visualstudio.com/docs/editor/extension-gallery#_browse-and-install-extensions)
Search for Prettier - Code formatter
Click install on the top result

2. Enable formatting on save

In Visual Studio open the settings file (see https://code.visualstudio.com/docs/getstarted/settings#_creating-user-and-workspace-settings)
Search for editor format
Set editor.formatOnSave and editor.formatOnPaste to true

Running the code/tests

The files for the mandatory/extra exercises are intended to be run as jest tests.

Once you have cloned the repository, run npm install once in the terminal to install jest (and any necessary dependencies).
To run the tests for all mandatory/extra exercises, run npm test
To run only the tests for the mandatory exercises, run npm test -- --selectProjects mandatory
To run only the tests for the extra exercises, run npm test -- --selectProjects extra
To run a single exercise/test (for example mandatory/1-writer.js), run npm test -- --testPathPattern mandatory/1-writer.js (Remember, you can use tab-completion to get files relative to the current directory, so mTab ↹/1-Tab ↹ will autocomplete get you the test file starting with 1-)

For more information about tests, look here:

https://syllabus.codeyourfuture.io/guides/intro-to-tests

Try out variant way of running tests:

npm test -> run all mandatory and extra tests
npm test -- --selectProjects mandatory -> run only mandatory tests
npm test -- --testPathPattern mandatory/1-syntax-errors.js -> run single test

Solutions

The solutions for this coursework can be found here:

https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1-Solution

This is a private repository. Please request access from your Teachers, Buddy or City Coordinator after the start of your next lesson.

Instructions for submission

For your homework, we'll be using tests to check your answers. The tests will assert that your functions behave in the correct way. A failing test ❌ indicates that a function is not behaving correctly; a passing test ✅ indicates that your function is behaving correctly.

Complete the challenges in each file and save it once you're happy with your changes
Run the script to check the results against the tests - all tests should read PASSED if you completed the challenges correctly. If a test reads FAILED, find the associated test to identify which function failed and fix it.
Raise a PR once you're happy with the quality of your code

javascript-core-1-coursework-week1's People

Contributors

Stargazers

Watchers

Forkers

pat-on scarabeo7 mikinet adepeju18 ironkamosi jk1320 lish-dev nirmeet-baweja cbaggini moniqueking57 know-thyself senaitekubai samia-pk jip1984 fatimohkuforiji1 atedy jwillson2020 aaokunade alsafi25 kos0606 liewteh remidoukmak sozchi kwthr8 adamali07 mame-baba markfarmiloe benyamworku khaya56 kudahshambare msumba-art ntshembo-hlongwane1 sinopungula brettscheepers joshuabalfe andile-coder bradleymubenga777 ullie2298 cyf-projects askinekincihf jarrodben yunusfirat adam-alagoz itrip23 npelvin ybayraktutan muratdemirtas2001 negindn dibakarimi laura-tm tanikadev omarsharif-gr itsmesonia hozan94 oksygenn bisioolajide thetrainman abdulazizalhasan jontas77 aishak05 domenico-cyf ryans-cpt alinosratipour lawrencebaatjies douglasvdm sirpfaira ahmadjanah mulindierick samuelkau soraiya bigbaby01 rodriguendzana rfloresram serialcarkey rynofourieza danghanbari aslandeniz russmahn ramla199 bahia369 natalinegn aashiqabrahams123 crustyburger julienkode dharmaguadeloupe maziarmajd sharm-dev myaskylar texx45 gulnihaln anza-azam musayuksel omerffaruk maham511 humailhasankhan seyedsharifi12 neil0696 konikalily allosaurus1 alibvr

javascript-core-1-coursework-week1's Issues

Tests need to be reviewed on mandatory folder - exercise 4-tax

On the first function, it asks you to calculate the tax (e.g. if you want to put a 20% sales tax on top of a coat priced at £80, the sales tax is £16), but the tests are expecting you to provide the full price: original price plus sales tax (e.g. 80 + 16 = 96). The second function then asks you to utilise the information from the calculate tax function to get the full price (original price plus tax to be added on top).

Minor tweaks to instructions

Update to the directory needed to cd into for the Hello World exercise
Update the test commands needed to run some of the extra exercises in the repo

Record playlist JS1 Week 1

Assignees can add a plan here!

toBeOneOf in extra 3-magic-8-ball test not working

I've found a problem with the test toBeOneOf I've added see the screenshot

File missing in Exercises L-functions-nested

There is a file missing in JS Exercises L-functions-nested. The file exercise.js is actually exercise2.js.

extra 8 ball jest test have error

I believe there is something wrong with the extra 8 ball test part.
when I run it with the same code in a separate file with out jest test it runs fine and gave me the four moods ( very positive, positive , ... ) but with the jest test on the file it prints out the log file with numbers instead of the moods.

npm WARN config global --global, --local are deprecated. Use --location=global instead.

[email protected] test
jest "--testPathPattern" ".\extra\3-magic-8-ball.js"

FAIL extra extra/3-magic-8-ball.js
× whole magic 8 ball sequence (21 ms)
√ magic 8 ball returns different values each time (23 ms)
× checkAnswer works for It is decidedly so. (3 ms)
× checkAnswer works for My reply is no. (2 ms)

● whole magic 8 ball sequence

expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 3

  130 |   expect(typeof answer).toEqual("string");
  131 |
> 132 |   expect(consoleLogSpy).toHaveBeenCalledTimes(1);
      |                         ^
  133 |   expect(consoleLogSpy).toHaveBeenLastCalledWith("The ball has shaken!");
  134 |
  135 |   expect(checkAnswer(answer)).toBeOneOf([

  at Object.<anonymous> (extra/3-magic-8-ball.js:132:25)

● checkAnswer works for It is decidedly so.

expect(received).toEqual(expected) // deep equality

Expected: "very positive"
Received: "l"

  163 |
  164 | test("checkAnswer works for `It is decidedly so.`", () => {
> 165 |   expect(checkAnswer("It is decidedly so.")).toEqual("very positive");
      |                                              ^
  166 | });
  167 |
  168 | test("checkAnswer works for `My reply is no.`", () => {

  at Object.<anonymous> (extra/3-magic-8-ball.js:165:46)

● checkAnswer works for My reply is no.

expect(received).toEqual(expected) // deep equality

Expected: "very negative"
Received: " "

  167 |
  168 | test("checkAnswer works for `My reply is no.`", () => {
> 169 |   expect(checkAnswer("My reply is no.")).toEqual("very negative");
      |                                          ^
  170 | });
  171 |

  at Object.<anonymous> (extra/3-magic-8-ball.js:169:42)