coding-blocks/cbonlineapp

😎⚡️Android App for Coding Blocks Online Courses

cbonlineapp's Issues

implement search functionality in all courses page

Setup gradle play publisher

Update gradle to 3.4.1

Describe
Update gradle version to 3.4.1

Would you like to work on the issue?

• Yes
• No

arrow should revert when the list expands in course activity

Describe the bug
If the list is expanded in course activity, the position of arrow does not change
To Reproduce

1. Go to 'course activity'
2. Click on 'one of the item of what will you learn'
3. If the list is expanded, the direction of arrow does not revert

Expected behavior
If the list is expanded, the direction of arrow should revert

Screenshots

Smartphone Info:

Device	<Lenovo k8 note
Android Version	Oreo 8.0

Would you like to work on the issue?

• Yes
• No
• Other:

Show documents in the course contents

The documents should be shown alongside the videos in course contents

bottom start trial button in course activity not working

Describe the bug
The bottom start trial button in the course activity is not working.

To Reproduce

1. Go to 'course activity'
2. Scroll down to 'batches'
3. click on start trail button, nothing happens there o click

Expected behavior
it should enroll user to that particular batch and lead to my course section

Screenrecording

Smartphone Info:

Device	Lenovo K8 Note
Android Version	Oreo 8.1

Would you like to work on the issue?

• Yes
• No
• Other:

show marked question in quiz sheet

Describe the feature you'd like
Show marked items in the quiz bottom similar to web

Crash while initializing youtube player

Go to all courses and click on a course, the app crashes with the following log :

2018-12-13 16:03:53.144 20965-20965/? E/ActivityThread: Service com.google.android.youtube.api.service.YouTubeService has leaked IntentReceiver aeqv@b4c57ea that was originally registered here. Are you missing a call to unregisterReceiver()?
    android.app.IntentReceiverLeaked: Service com.google.android.youtube.api.service.YouTubeService has leaked IntentReceiver aeqv@b4c57ea that was originally registered here. Are you missing a call to unregisterReceiver()?
        at android.app.LoadedApk$ReceiverDispatcher.<init>(LoadedApk.java:1383)
        at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:1153)
        at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1422)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1395)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1383)
        at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:604)
        at aghx.<init>(SourceFile:38)
        at agip.a(SourceFile:27)
        at agip.get(SourceFile:53)
        at aupc.get(SourceFile:9)
        at les.B(SourceFile:268)
        at aepr.a(SourceFile:6)
        at aepr.get(SourceFile:9)
        at aupc.get(SourceFile:9)
        at lex.a(SourceFile:6)
        at ldp.<init>(SourceFile:11)
        at com.google.android.apps.youtube.embeddedplayer.service.service.jar.ApiPlayerService.<init>(SourceFile:46)
        at com.google.android.apps.youtube.embeddedplayer.service.service.jar.ApiPlayerFactoryService$1.run(SourceFile:4)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6809)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

bug in viewpager in home fragment

In home fragment in viewpager, the after completing one cycle the view pager goes to second item instead of first
To Reproduce

1. Go to 'Home Fragment'
2. wait for completing one cycle of viewpager, after that it will go to second position instead of first

Expected behavior
After one cycle of viewpager, it should go to first position instead of second

Smartphone Info:

Device	Lenovo k8 note
Android Version	Oreo 8.0

Would you like to work on the issue?

• Yes
• No
• Other:

Bugs/Improvements List

• Show Quiz Result on quiz submission
• show marked/unmarked status in quiz bottom question sheet
• bottom sheet gets dismissed completed on swiping down[Bug]
• show small rating bar in anko course card layout

turn font to Cabin light

looks too bold

make a library for svg rendering using glide

Looper.prepare crash

CBOnlineApp/app/src/main/java/com/codingblocks/cbonlineapp/activities/MyCourseActivity.kt

Line 134 in 0c089e1

content.contentable.equals("video") -> content.video?.let { contentVideo = ContentVideo(it.id!!, it.name!!, it.duration!!, it.description!!, it.url!!, content.section_content?.id!!, it.updatedAt!!) }

support for POST request using jsonapi

Use Image assets from here

https://github.com/coding-blocks/codingblocks.online.projectx/tree/master/public/images

Issues in Contact Us

Describe the bug
Contact US On Navigation Drawer has following error

1. Toolbar Back press not working
2. Toolbar name is wrong
3. Toll free number is not cliclacble
4. Address has for some text issues, where characters cant be displayed
5. I think it needs update for all the centres of CB

To Reproduce

1. Go to Contact us from nav drawer

Expected behavior
The above should not be their

Would you like to work on the issue?

• Yes
• No
• Other:

use Arraylist to create Relationship

@championswimmer bhaiya should we use ArrayList as an embedded object to create relationships among different classes rather creating this relationship manually as we are getting a nested object structure and from the api call straight forward and relationship are required when we need to manually create relationship between two seperate classes @the-dagger bhaiya your thoughts on this ?

No intent is set for viewpager in the homefragment.

Describe the bug

On clicking the viewpager view nothing happens.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Homefragment'
2. Click on 'viewpager that swipes on definite interval'
3. Bug -> No response on click .

Expected behavior
On clicking the viewpager a new page should open up.

1. For the first three slides respective course activity should open up.
2. For the 'Share success story ' , the coding block website should open up.

Would you like to work on the issue?

• [✔ ] Yes
• No
• Other:

turn oneauth login into a library

Create Quiz Result Screen

References

Refactor the whole code

Describe the bug
The app is currently not following standards of dimens, string, colors and constants. Need to refactor it according to the standards.

Expected behavior
It should be following it.

Would you like to work on the issue?

• Yes
• No
• Other:

Integrate Koin

Integrate Koin With api for retrofit calls,common for shared preferences and other system related thing and database module for dao's

Crash while initializing youtube player

Go to all courses and click on a course, the app crashes with the following log :

2018-12-13 16:03:53.144 20965-20965/? E/ActivityThread: Service com.google.android.youtube.api.service.YouTubeService has leaked IntentReceiver aeqv@b4c57ea that was originally registered here. Are you missing a call to unregisterReceiver()?
    android.app.IntentReceiverLeaked: Service com.google.android.youtube.api.service.YouTubeService has leaked IntentReceiver aeqv@b4c57ea that was originally registered here. Are you missing a call to unregisterReceiver()?
        at android.app.LoadedApk$ReceiverDispatcher.<init>(LoadedApk.java:1383)
        at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:1153)
        at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1422)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1395)
        at android.app.ContextImpl.registerReceiver(ContextImpl.java:1383)
        at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:604)
        at aghx.<init>(SourceFile:38)
        at agip.a(SourceFile:27)
        at agip.get(SourceFile:53)
        at aupc.get(SourceFile:9)
        at les.B(SourceFile:268)
        at aepr.a(SourceFile:6)
        at aepr.get(SourceFile:9)
        at aupc.get(SourceFile:9)
        at lex.a(SourceFile:6)
        at ldp.<init>(SourceFile:11)
        at com.google.android.apps.youtube.embeddedplayer.service.service.jar.ApiPlayerService.<init>(SourceFile:46)
        at com.google.android.apps.youtube.embeddedplayer.service.service.jar.ApiPlayerFactoryService$1.run(SourceFile:4)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6809)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Implement ViewModels for Course and Video Activities

Describe the feature you'd like
Implement View Models for Course And Video Activities with koin

Implement Dynamic App Shortcut

Describe the feature you'd like
Implement Dynamic App Shortcut for course with maximum usage similar to like WhatsApp implementation

References
https://developer.android.com/guide/topics/ui/shortcuts

pull down to refresh in home, all course and my course pages

Display a warning dialog before ending the quiz attempt screen.

Describe the feature you'd like
There is no warning displayed when we end the quiz while attempting. There should be warning like You have not submitted the quiz, your score will not be updated
and add submit/cancel button on the warning dialog.

Write Unit test Every for Api defined in OnlineRestApi and OnlineJsonApi

Fix MyCourses Swipe to Refresh

Describe the feature you'd like
Swipe to Refresh in My Courses Fragment keeps on loading data

youtube url regex

http(?:s?):\/\/(?:www\.)?youtu(?:be\.com\/watch\?v=|\.be\/)([\w\-\_]*)(&(amp;)?‌​[\w\?‌​=]*)?

Bad current drawer item status

Describe the bug
Wrong indication of currently open screen in drawer menu

To Reproduce

Wrong indication of open screen

Expected behavior
These drawer menu should indicate currently open screen

Screenshots

Would you like to work on the issue?

• Yes
• No
• Other:

Login Activity layout error in landscape mode

Describe the bug

The login activity has layout currently for portrait and it's not properly visible in landscape mode

To Reproduce
Open the app

Expected behavior
The activity should be portrait or a new layout for landscape should be made.

Logs
None

Screenshots

Would you like to work on the issue?

• Yes
• No
• Other:

Add Tags Section to Course Activity

For reference see image below

use jsonapi-converter with retrofit

Add databinding to activities.

With the databinding library of android the boilerplate code could be reduced alot.

[ ] Add databinding to activities
[ ] Add databinding to adapters
[ ] Add databinding to fragments

Would you like to work on issue
Yes

Make Embedded Objects in CourseContent for the rest of the objects

CBOnlineApp/app/src/main/java/com/codingblocks/cbonlineapp/database/DbModel.kt

Line 127 in 70f8b30

//add rest of the embedded objects

Unable to handle Many to Many Relationship Correctly

CBOnlineApp/app/src/main/java/com/codingblocks/cbonlineapp/database/DbModel.kt

Line 58 in 52187f1

data class Instructor(

Unable to show same instructors in two courses

use androidx version of room, not the pre-androidX style (android.aarch)

setup travis and circle ci for builds

Improvise Quiz Activty

Describe the feature you'd like
There are multiple issues in the quiz so I'll be breaking into separate PR's

• Inappropriate flow of quiz - quiz has an inappropriate flow it should follow a proper flow with proper confirmation at every point

• Incorrect Shimmer Layout for Quiz

• Improve Previous Attempts leaderboard

• Improve Quiz Layout

• Incorrect Time in Quiz Attempt

• Add Submit Quiz Button in Bottom Sheet

App crashes on refreshing in All Courses

Describe the bug
App crashes on refreshing in All Courses

To Reproduce

1. Go to All Courses.
2. Refresh by swiping down.
3. App will crash.

Expected behavior
App shouldn't crash and the list should reload.

Logs

android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
        at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:6958)
        at android.view.ViewRootImpl.invalidateChildInParent(ViewRootImpl.java:1120)
        at android.view.ViewGroup.invalidateChild(ViewGroup.java:5207)
        at android.view.View.invalidateInternal(View.java:13676)
        at android.view.View.invalidate(View.java:13640)
        at android.view.View.invalidateParentIfNeeded(View.java:13829)
        at android.view.View.clearAnimation(View.java:20211)
        at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.a(SwipeRefreshLayout.java:486)
        at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.a(SwipeRefreshLayout.java:472)
        at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.setRefreshing(SwipeRefreshLayout.java:434)
        at com.codingblocks.cbonlineapp.c.b$e$b.a(AllCourseFragment.kt:176)
        at com.codingblocks.cbonlineapp.c.b$e$b.invoke(AllCourseFragment.kt:32)
        at kotlin.c.a$a.run(Thread.kt:30)

GIF

Would you like to work on the issue?

• Yes
• No

Show leaderboard in Course Consumption Page

Describe the feature you'd like
Show leaderboard in the course consumption page

Use radiobutton for quiz options

Replace the current logic with normal radiobuttons followed by radiobuttons with a custom drawable.
@aggarwalpulkit596

Refactor: Text is Hard-coded

Describe the feature you'd like
Currently, in many XML files, the text is hard-coded while it should be placed in strings.xml file.

Additional context
If placed in strings.xml then we can introduce the Hindi language too.

Would you like to work on the issue?

• Yes

bug in batches recyclerview in course activity

Describe the bug
While scrolling the bathes cards in course activity if we stop between two cards then it gets stuck there. Whereas it should move to card that is swiped more
To Reproduce

1. Go to 'bottom of course activity'
2. Scroll batches cards

Expected behavior
if we stop between two cards, then it should move to card that is swiped more
Screenrecording

Smartphone Info:

Device	Lenovo k8 note
Android Version	Oreo 8.0

Would you like to work on the issue?

• Yes
• No
• Other:

Add free label to free section of trial course in My Course Activity

Cache SVG for offline loading of course log/poster images

perf benchmark all course page scroll and optimise

App crash after login

Once the user tries to login into the app, it crashes each time the app is launched.

Dropdown in Course section not working

Describe the bug
When you see any course and go to its What will you learn section, there are cards representing each section of the course. When you click on the card, it will expand but when you click on the dropdown button, nothing happens.

There are solutions I can think of - remove the dropdown button or make it workable.

To Reproduce
Home -> Go to any Course -> What will you learn section -> Try clicking dropdown button

Expected behavior
The dropdown button should have worked.

Smartphone Info:
Device - Pixel 2 XL
Android Version - Android Q Beta

Would you like to work on the issue?

• Yes