Giter Site home page Giter Site logo

Comments (12)

thijstriemstra avatar thijstriemstra commented on May 22, 2024

hi @durimrexhaj, can you please explain in detail why and what isn't working on what version/operating system?

from videojs-record.

durimrexhaj avatar durimrexhaj commented on May 22, 2024

hiw @thijstriemstra I'm using windows and chrome Version 43.0.2357.130. Recorder doesn't get the voice. When i play video i can't here voice in chrome.

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

@durimrexhaj I haven't tested it on windows chrome, so I'll give it a try and see what's going on.

from videojs-record.

durimrexhaj avatar durimrexhaj commented on May 22, 2024

hi @thijstriemstra I have tested RecordRTC script and it worked well for me and i saw the videojs-record uses RecordRTC but I don't know why is not working with this plugin. Thanks a lot

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

@durimrexhaj, what example did you use? Or what code are you using?

from videojs-record.

pbojinov avatar pbojinov commented on May 22, 2024

I noticed the same issue on Chrome Version 43.0.2357.130 (64-bit) for OSX 10.10.3 using the examples/audio-video.html provided.

Here's the audo-video.html file hosted as is for testing purposes: http://pbojinov.github.io/videojs-record/examples/audio-video.html

The console.logs look normal

webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:92 started recording audio stream.
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:1673 sample-rate 22050
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:1674 buffer-size 4096
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:92 started recording video stream.
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:1963 canvas resolutions 320 * 240
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:1964 video width/height 320 * 240
audio-video.html:46 started recording!
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:149 Stopped recording audio stream.
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:149 Stopped recording video stream.
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:177 audio/wav -> 213 KB
audio-video.html:54 finished recording:  Blob
webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.js:177 video/webm -> 417 KB

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

capture

I've also tested the examples and noticed the same on windows, linux and osx Chrome browsers. As noted in the README:

Note that recording both audio and video in a single WebM file is currently only supported in Mozilla Firefox >= 29. On other browsers the resulting file only contains video data.

This is a limitation of Chrome because it hasn't implemented MediaRecorder yet, and Firefox has. What RecordRTC.js does is record, stop stream, make audio data blob available, then make video data blob available. In Firefox it makes a single audio/video blob available after recording.

Now, I noticed that this line https://github.com/collab-project/videojs-record/blob/master/src/js/videojs.record.js#L441 causes only video-data to be made available, the audio blob is ignored. In a perfect world Chrome would stich the audio and video together in a webm blob, just like Firefox can.

So now, I guess it would be possible to trigger 2 'finishRecord' events, one for audio and one for video, but this would only be necessary in Chrome. And then there is also the issue of being able to playback of audio and video at the same time in Chrome. Any suggestions?

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

I've commited a fix for Chrome that makes both audio and video blobs available when the finishRecord event fires.

capture

But during playback it will still only display the video stream and ignore the audio stream (because they're separate objects). I guess syncing the playback of the audio using WebAudio should be possible in that case.

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

I decided to add an extra audio element for chrome when recording audio and video that plays the recorded audio stream in sync with the video element.

Closing this ticket, please open a new one if there's still an issue.

from videojs-record.

pbojinov avatar pbojinov commented on May 22, 2024

This is great, thank you 👍

from videojs-record.

v3ss0n avatar v3ss0n commented on May 22, 2024

What is the format audio and videos are recorded with AUDIO_VIDEO flag? Is that Webm or WAV??

from videojs-record.

thijstriemstra avatar thijstriemstra commented on May 22, 2024

Try it, document it and open a pull request please.

from videojs-record.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.