colorful-tones / devrel-feedback Goto Github PK
View Code? Open in Web Editor NEWA WordPress 'Feedback' block that uses the Interactivity API to submit feedback on single posts.
A WordPress 'Feedback' block that uses the Interactivity API to submit feedback on single posts.
More feedback from @luisherranz
Avoid storing state that can be derived from other state.
const { state } = store( "...", {
state: {
get hasSucess() {
const { status } = getContext();
return status === "success";
},
get hasError() {
const { status } = getContext();
return status === "error";
},
get formMessage() {
const { status } = getContext();
if ( status === "success" ) return "Success!";
if ( status === "error" ) return "Error!";
}
},
actions: {
*submitForm( event ) {
// ...
try {
yield fetch( context.ajaxUrl, {
method: 'POST',
credentials: 'same-origin',
body: formData
}).then( r => r.text() )
context.status = "success";
} catch( error ) {
console.error( 'Error:', error );
context.status = "error";
}
},
}
});
This keeps things more declarative and avoids out-of-sync issues when the code starts getting complex.
I hope that helps ๐
Great feedback from @luisherranz
Use generators for any asynchronous operation, instead of async/await (or promises).
*submitForm( event ) {
const context = getContext();
const { ref } = getElement();
event.preventDefault();
const formData = new FormData( ref );
formData.append( 'action', 'submit_feedback' );
formData.append( 'nonce', context.nonce );
formData.append( 'postId', context.postId );
context.isFormProcessing = true;
try {
const data = yield fetch( context.ajaxUrl, {
method: 'POST',
credentials: 'same-origin',
body: formData
}).then( r => r.text() )
context.hasSuccess = true;
context.formMessage = "Success!";
} catch( error ) {
console.error( 'Error:', error );
context.hasError = true;
context.formMessage = "Error!";
}
},
This is a requirement for the Interactivity API. In your case, everything works fine, but it could cause issues with the scope.
If you want to keep using promises instead, you need to wrap all the promise callbacks with a withScope(cb) function.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.