commercetools/eslint-config

This package provides Commercetools's .eslintrc as an extensible shared config, based on Airbnb's eslint config

This repository and package is deprecated and not maintained anymore.

eslint-config's Issues

Improve readme to include detailed steps to setup eslint on empty project

PeerDependencies behaves differently in npm3 causing required packages to be missing

In npm3, peerdependencies does not automatically install packages anymore. (More detail here)

So just installing the module does not install the required dependencies, it just gives a warning. We should update the peerDependencies to dependencies.

Installing returns an ERROR EPEERINVALID

Description

When installing module using npm:

npm install --save-dev eslint-config-commercetools

I get an error EPEERINVALID:

npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/xjunajan/.nvm/versions/node/v4.5.0/bin/node" "/Users/xjunajan/.nvm/versions/node/v4.5.0/bin/npm" "install" "--save-dev" "eslint-config-commercetools"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants eslint-plugin-jsx-a11y@>=2
npm ERR! peerinvalid Peer [email protected] wants eslint-plugin-jsx-a11y@^2.2.3

Expected Behavior

Should install sub-dependencies correctly.

Can't use module because of missing dependency

Description

I can't use this module(v4.0.0) because of missing dependencies(eslint-formatter-pretty).

var your => (code) => here;

Current Behavior

I installed the module by running this script

(
  export PKG=eslint-config-commercetools;
  npm info "$PKG" peerDependencies --json | command sed 's/[\{\},]//g ; s/: /@/g' | xargs npm install --save-dev "$PKG"
)

That was meant to install all required dependencies, but missed out on eslint-formatter-pretty because it's not in peerDependencies

Possible Solution

Move eslint-formmater-pretty from devDependencies to peerDependencies

Upgrade eslint-plugin-import

There is a dependency error in the test files, where eslint requires test modules like 'tape' to be installed in the 'dependency' and not 'devDependency'.

This is fixed by adding this command ("import/no-extraneous-dependencies": ["error", {"devDependencies": ['*.test.js', '*.spec.js']}]) to the '.eslintrc' file in the test folder.

Sadly, the command is not supported yet in the current version of eslint-plugin-import, but it's scheduled to be released.

We are currently using import/no-extraneous-dependencies: [error, { devDependencies: true }]

So we check and bump up the version when it's released.

Reorganize dependencies

Description

A few general thoughts about dependencies

• eslint-formatter-pretty should not be a peer dependency
• eslint dependencies should be peerDependencies, see documentation
• There should be almost no dependencies (see how airbnb does it)
• eslint-formatter-pretty should be updated to 1.0.0

Migrate commercetools-eslint-config to NodeJS library conventions

Dependency deprecation warning: validate-commit-msg (npm)

On registry https://registry.npmjs.org/, the "latest" version (v2.14.0) of dependency validate-commit-msg has the following deprecation notice:

Check out CommitLint which provides the same functionality with a more user-focused experience.

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Affected package file(s): package.json

If you don't care about this, you can close this issue and not be warned about validate-commit-msg's deprecation again. If you would like to completely disable all future deprecation warnings then add the following to your config:

"suppressNotifications": ["deprecationWarningIssues"]

Airbnb's rules are deprecated

airbnb/base is deprecated and replaced by airbnb-base.

This also removes the React and JSX dependencies, are we using one of these in our projects? If so I would suggest to make a new repository eslint-config-base that is based on this new config set.
@PhilippSpo @hisabimbola