commschamp/comms

C++(11) library to implement custom binary communication protocols

comms's Issues

Missing member function of `comms`

Hello!

When I compile my project with comms as a submodule, this error occurs:

~/comms/install/include/comms/protocol/MsgSizeLayer.h: In member function ‘comms::ErrorStatus comms::protocol::MsgSizeLayer<TField, TNextLayer, TOptions>::writeInternalNoLength(comms::protocol::MsgSizeLayer<TField, TNextLayer, TOptions>::Field&, const TMsg&, TIter&, std::size_t, TWriter&&) const’:
~/comms/install/include/comms/protocol/MsgSizeLayer.h:467:21: error: ‘isMessageBase’ is not a member of ‘comms’

Conent of comms/protocol/MsgSizeLayer.h:

My CMakeList.txt section:

include(${PROJECT_SOURCE_DIR}/library/comms/cmake/CC_CommsExternal.cmake)
set(cc_comms_install_dir ${PROJECT_BINARY_DIR}/comms/install)
cc_comms_build_during_config(
        SRC_DIR ${PROJECT_SOURCE_DIR}/library/comms
        CMAKE_ARGS
        TAG v5.0.1
        -DCMAKE_INSTALL_PREFIX=${cc_comms_install_dir}
        -DCC_COMMS_BUILD_UNIT_TESTS=OFF
)
list(APPEND CMAKE_PREFIX_PATH ${cc_comms_install_dir})
find_package(LibComms NO_MODULE REQUIRED)

I was compiling with tag v5.0.1.

This function is declared in comms/install/include/comms/MessageBase.h, so maybe this is an unintended mistake. After adding the #include "comms/MessageBase.h" line to comms/protocol/MsgSizeLayer.h, the error seems to disappear.

So the patch can be applied quickly, hope you can fix this soon!

FYI: vcpkg

Hi Alex,

I've just updated the commschamp and commsdsl libs.
Most patches are gone now. But I needed to patch the CC_CMAKE_DIR of the commsdsl project.

microsoft/vcpkg#14521

In addition to that i've added the comms.ublox project. (the generated one)

microsoft/vcpkg#14523

It should be merged soon.