compassionch/compassion-modules

Odoo modules for Compassion

compassion-modules's Issues

Image preview not working when editing line

When editing a line of a tree view, the widget image preview disappears and shows the image. This results to this in the import letters view :

Would it be feasible to deactivate that behaviour and keep the icon when editing a line ?

[8.0] child_compassion javascript is broken

field_on_change methods are never called in javascript

res_partner_view.xml

On line 20, View seems to be invalid

Workflow changes

Following Activities miss a flow_stop flag :

• no_sub
• sub_accept
• sub_reject

Change name of file contract_workflow to sds_workflow.

[sponsorship_compassion] Improve res_partner view

Partner view is not good with buttons in the right corner. We should replace them with v8 style icons:

Module account_analytic_plans_compassion is problematic

Module account_analytic_plans_compassion causes a bunch of problems when trying to upgrade the modules of compassion. We should take time to see its use and clean the code (a lot of its code comes from module account_analytic_plans).

External Librairies

When opencv3 and zxing will be released, it could be good to make a setup script that install everything easily.
For zxing: http://mvnrepository.com/artifact/com.google.zxing with a version >= 4.7.5
For opencv, the linux repositories should be enough

Move Typo3 functionalitites to separate module

Move them to other module so that it can be in swiss repository.

Do not forget to put the documentation

Modules with a documentation:

• child_compassion
• crm_compassion
• hr_planning
• onramp_compassion
• sponsorship_compassion
• contract_compassion
• label
• message_center_compassion
• partner_compassion
• sbc_compassion
• sponsorship_tracking
• [unported]
• [travis]

In order to make a documentation (using readthedocs.org) for a repository, follow theses points and try to copy a large part of the conf.py:

1. Create a docs directory and running sphinx-quickstart inside it (https://docs.readthedocs.org/en/latest/getting_started.html)
2. 1. Modify the conf.py in order to add the path to the root directory
   2. Create a requirements.txt file for pip (with the modules used in the repository)
   3. If a module is not in pip, mock it inside the conf.py (see in sbc_compassion)
3. Use sphinx-apidoc in order to create all the rst files
4. Use the script that I have created (edit_rst_file.py in docs) in order to format the rst files
5. Compile with make html in order to check if everything is good (try to keep a small compilation time)
6. Commit to github
7. Create a new project on readthedocs
8. Import the repository
   1. Follow the steps given by the website
   2. Go to Settings->Advanced Settings
   3. Give the path to requirements.txt and conf.py
9. Choose the default branch
   1. Go to Settings->Versions
   2. Choose which branches should be build
   3. Go to Settings->Advanced Settings
   4. Choose the default branch

Add field force_template to letters_import_history

Add a Many2one field related to correspondence.template allowing to force one template to all imported letters (skips template detection and forces to use the one selected).

Module child_compassion dependency

Miss a dependency to module document.

Import lines fields partner_codega and child_code should be references

Change fields partner_codega and child_code to partner_id and child_id with link to actual records of related models. This makes easier setting the child and the partner in case the qr code detection didn't work.

Should adapt method _find_qrcode :

• https://github.com/CompassionCH/compassion-modules/blob/sbc-devel/sbc_compassion/models/import_letters_history.py#L246

Instead of returning multiple variables, the function could return the dictionary of values needed to be passed to the create called at https://github.com/CompassionCH/compassion-modules/blob/sbc-devel/sbc_compassion/models/import_letters_history.py#L254

• https://github.com/CompassionCH/compassion-modules/blob/sbc-devel/sbc_compassion/models/import_letters_history.py#L285

Variable data is never used inside the method, but is overidden and returned. Check what is the purpose of this and correct the code by either removing data from the parameters or making use of it. Also add a comment to the function to document the parameters.

[8.0] Use inheritance in tests

Tests have almost all the same setUp method and same private method for _create_contract, _create_contract_group, etc...

We should remove all this redundant code and use inheritance in tests to improve the maintainability of the code.

Need to check: Import history

From Secheron: With large zip files, one can run the detection before the end of the upload

Improved language detection

We should improve it (actually with the zip test, we reach around 2/3 of detection)

Import letters: Wizard for Import Line Review

We should create a wizard showing the image in order to ask a human being to verify the language and the template (at least for the first few months of use in order to verify the algorithm at a larger scale).

• Browse the import lines that need verification one by one
• Display image and import line data that can be edited

Rules for including a line in the review process :

• Letter does not need translation (to be sure it is really the case and avoid transmitting a letter the child won't understand)
• Default template is selected but Force default template was not activated, to be sure it wasn't a valid template not detected
• Any missing data
• ... something else ?

Missing management of gmc_state changes in sds_tracking module

gmc_state needs to be merged with sds state to be able to track for example:

• depart of a child
• a new biennial report needs to sent
• etc...

to do this properly we need to be able to create multiple workflows on a same record a reset a specific one of these workflow (https://www.odoo.com/forum/help-1/question/many-workflows-on-same-record-81693)

Language detection DPI and rotation independent

Implement again something to transform coordinates when cropping images of checkboxes in order to be able to scan in any DPI setting and avoid misaligned images errors.

Unlocalize module sponsorship_compassion

Currently, module sponsorship_compassion depends on switzerland accounting (accounts defined in module chart_account_compassion). We should remove this dependency in order to make it usable for other countries.

Label: Other barcodes

when label will be inside compassion-modules:
Right now the layout allows only a square barcode (therefore QR code), but it could be nice to add some others

Don't edit accounting modules and CH-specific modules

Those modules are moved to other repositories and should not be edited in this repository from now on. I will remove them from branch master but they are still referenced in some other branches waiting for the review to be complete.

[7.0-children] way to update child basic information

There should be a way to update child basic information (age, name, ...). Should we add the update in the get_last_case_study method or add a new method to do that (but it will need to call compassion webservice) ?

I can add this, as it is needed for the message_center in case of new child allocations.

mandate not selected on direct debit order

When the partner changed his bank account the old mandate is canceled.
But when creating a DD order, the new bank account is not selected automatically. And thus we need to look for lines without a mandate and update the payment line manually. for now it's only a few. But as partner change their bank account this might become a real hassle

Import tests language detection image

Languages cut result should be shown even if no language is detected (if template is detected)

Contract origin names is not resolved

For partner origins, and origin "Contact with Ambassador" that is not linked to a partner, _get_name produces an error. We should fix that.

Filter only sponsor partners

In sbc_compassion, when searching partners from the barcode reference, filter only those who have the "Sponsor" category, in order to avoid finding duplicates.

#156 (diff)

Label: Finding some better parameters

When the labels will be integrated:
The parameters for the labels are good enough for using them, but maybe we should try to find the perfect ones and add config for the others compassion labels

QR code detection

1. Need to verify first!
   I think that the code does not try to find the QR code on the entire page.
   If not, we should try before giving up to scan the whole page
2. If a partner puts the QR code in the opposite corner, the algorithm will believe that the page is in reverse side. Therefore we should look at the position AND the orientation of the QR code

File encoding

NppFTP plugin puts file encoding to ANSI by default (and bypasses Npp preferences!). Until this is fixed, we will have the endlines appearing in diffs.

[7.0-children] Move project_compassion

I would move class project_compassion from module sponsorship_compassion to module child_compassion, as it is linked more with children than sponsorships.