compassionch / compassion-modules Goto Github PK
View Code? Open in Web Editor NEWOdoo modules for Compassion
License: GNU Affero General Public License v3.0
Odoo modules for Compassion
License: GNU Affero General Public License v3.0
field_on_change methods are never called in javascript
On line 20, View seems to be invalid
Following Activities miss a flow_stop flag :
Change name of file contract_workflow to sds_workflow.
Module account_analytic_plans_compassion causes a bunch of problems when trying to upgrade the modules of compassion. We should take time to see its use and clean the code (a lot of its code comes from module account_analytic_plans).
When opencv3 and zxing will be released, it could be good to make a setup script that install everything easily.
For zxing: http://mvnrepository.com/artifact/com.google.zxing with a version >= 4.7.5
For opencv, the linux repositories should be enough
Move them to other module so that it can be in swiss repository.
Modules with a documentation:
In order to make a documentation (using readthedocs.org) for a repository, follow theses points and try to copy a large part of the conf.py:
Add a Many2one field related to correspondence.template allowing to force one template to all imported letters (skips template detection and forces to use the one selected).
Miss a dependency to module document.
Change fields partner_codega
and child_code
to partner_id
and child_id
with link to actual records of related models. This makes easier setting the child and the partner in case the qr code detection didn't work.
_find_qrcode
:Instead of returning multiple variables, the function could return the dictionary of values needed to be passed to the create
called at https://github.com/CompassionCH/compassion-modules/blob/sbc-devel/sbc_compassion/models/import_letters_history.py#L254
Variable data
is never used inside the method, but is overidden and returned. Check what is the purpose of this and correct the code by either removing data from the parameters or making use of it. Also add a comment to the function to document the parameters.
Tests have almost all the same setUp method and same private method for _create_contract, _create_contract_group, etc...
We should remove all this redundant code and use inheritance in tests to improve the maintainability of the code.
From Secheron: With large zip files, one can run the detection before the end of the upload
We should improve it (actually with the zip test, we reach around 2/3 of detection)
We should create a wizard showing the image in order to ask a human being to verify the language and the template (at least for the first few months of use in order to verify the algorithm at a larger scale).
Rules for including a line in the review process :
Force default template
was not activated, to be sure it wasn't a valid template not detectedgmc_state needs to be merged with sds state to be able to track for example:
to do this properly we need to be able to create multiple workflows on a same record a reset a specific one of these workflow (https://www.odoo.com/forum/help-1/question/many-workflows-on-same-record-81693)
Implement again something to transform coordinates when cropping images of checkboxes in order to be able to scan in any DPI setting and avoid misaligned images errors.
Currently, module sponsorship_compassion depends on switzerland accounting (accounts defined in module chart_account_compassion). We should remove this dependency in order to make it usable for other countries.
when label will be inside compassion-modules:
Right now the layout allows only a square barcode (therefore QR code), but it could be nice to add some others
Those modules are moved to other repositories and should not be edited in this repository from now on. I will remove them from branch master but they are still referenced in some other branches waiting for the review to be complete.
There should be a way to update child basic information (age, name, ...). Should we add the update in the get_last_case_study method or add a new method to do that (but it will need to call compassion webservice) ?
I can add this, as it is needed for the message_center in case of new child allocations.
When the partner changed his bank account the old mandate is canceled.
But when creating a DD order, the new bank account is not selected automatically. And thus we need to look for lines without a mandate and update the payment line manually. for now it's only a few. But as partner change their bank account this might become a real hassle
Languages cut result should be shown even if no language is detected (if template is detected)
For partner origins, and origin "Contact with Ambassador" that is not linked to a partner, _get_name produces an error. We should fix that.
In sbc_compassion, when searching partners from the barcode reference, filter only those who have the "Sponsor" category, in order to avoid finding duplicates.
When the labels will be integrated:
The parameters for the labels are good enough for using them, but maybe we should try to find the perfect ones and add config for the others compassion labels
NppFTP plugin puts file encoding to ANSI by default (and bypasses Npp preferences!). Until this is fixed, we will have the endlines appearing in diffs.
I would move class project_compassion from module sponsorship_compassion to module child_compassion, as it is linked more with children than sponsorships.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.