conda-forge/cylc-uiserver-feedstock

A conda-smithy repository for cylc-uiserver.

cylc-uiserver-feedstock's Issues

Bump jupyterhub to 1.4

For cylc/cylc-uiserver#216

UI not bundled with UIS

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

The bundled UI is not installed when cylc-uiserver is installed from conda-forge (version 1.0.1).

Things I've checked:

• The packaging looks correct (compare against cylc-flow)
• The UI is correctly included in the PyPi files (both the wheel and the src)
• The setuptools version is not ==61.0.0 (because this has a known bug)

Demonstration of the issue in code.

This creates envs by installing cylc-uiserver from pypi or conda-forge then checking for the existence of the UI dir in the pip logs:

set -eux                                                                                      
                                                                                              
test_env () {                                                                                 
    ENV="$1"                                                                                  
    conda run -n "$ENV"                                                                       
    if grep \                                                                                 
        'ui\/' \                                                                              
        "$CYLC_HOME_ROOT_ALT/$ENV/lib/python"3.*"/site-packages/cylc_uiserver-1.0.1.dist-info/RECORD"
    then                                                                                      
        echo SUCCEEDED                                                                        
    else                                                                                      
        echo FAILED                                                                           
    fi                                                                                        
}                                                                                             
                                     
make_env_pypi_normal () {        
    local ENV='test-pypi-normal'    
    conda env remove -n "$ENV" || true    
    conda create -y -n "$ENV"    
    conda run -n "$ENV" conda install -y python=3.7 --offline    
    conda run -n "$ENV" pip install cylc-flow==8.0rc2    
    conda run -n "$ENV" pip install cylc-uiserver    
    test_env "$ENV"              
}                                             

make_env_conda () {              
    local ENV='test-conda'       
    conda env remove -n "$ENV" || true    
    conda create -y -n "$ENV"    
    conda run -n "$ENV" conda install -y python=3.7 cylc-flow==8.0rc2 cylc-uiserver --offline    
    test_env "$ENV"              
}                                
                                 
# this will give: SUCCEEDED      
make_env_pypi_normal             
# this will give: FAILED         
make_env_conda                   

Installed packages

cylc-flow==8.0rc1
cylc-uiserver==1.0.1

Environment info

N/A

Fix URL in recipe

Simple typo, extra h before http. Doesn't need to be fixed right now, as we have a release coming in the next days anyway.

Creating issue just so we remember 👍

convert to noarch: python

We should be able to convert this feedstock to noarch: python

Here's the PR which converted cylc-flow - conda-forge/cylc-flow-feedstock#33

• Go throught the noarch checklist https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-builds
• Add the __unix psudo dependency.
• Convert to noarch.

This can be done before the 8.0rc1 release, follow the checklist in the PR description and increment the build number.

Review dependency on pytest-runner

See TODO comment in the recipe:

cylc-uiserver-feedstock/recipe/meta.yaml

Lines 24 to 26 in dd90def

	# TODO: build failed with pytest-runner only, because the setup.py of cylc-uiserver specifies this
	# version of pytest-runner. Need to make pytest-runner a dependency only for python setup.py test
	# and then remove this from requirements|host in the recipe

I have a vague recollection of fixing this in metomi-isodatetime feedstock. And I think I didn't have time to fix here as it was pointed by an external reviewer when we were ready to release our previous alpha version.

Should be easy to fix (first in cylc-uiserver I think, then in this recipe)

@conda-forge-admin, update version

Additional comment:

No response

@conda-forge-admin, update version

Additional comment:

No response

Remove upper constraint for JupyterHub (i.e., `<1.5`)

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

I have rudimentarily tested a core install of cylc-uiserver from PyPI against jupyterhub 2.2.2 and I don't see any adverse effects, but as I prefer conda packages, the upper constraint on JupyterHub is keeping the environment from being upgraded to JupyterHub 2.x which has some nice RBAC features.

Installed packages

n/a

Environment info

n/a

@conda-forge-admin, update version

Additional comment:

No response

Update maintainers

For the next release, remember to update the maintainers list removing my ID kinow 👍 (or before that too, but needs to release a new version/build)

Bump traitlets version to >5.

Bump traitlets version to >5.

cylc/cylc-uiserver#205