connordavenport/theme-manager

Theme Manager is a RoboFont extension for reading, writing, and storing custom glyph view themes.

theme-manager's Issues

Cannot export theme on RF4.3 on Monterey

Traceback:

/Applications/RoboFont.app/Contents/Resources/lib/python3.7/vanilla/py23.py:6: DeprecationWarning: The py23 module has been deprecated and will be removed. Please update your code.
Traceback (most recent call last):
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.7/vanilla/vanillaBase.py", line 514, in action_
    self.callback(sender)
  File "ThemeManager.py", line 387, in exportThemeCallback
NameError: name 'plistPath' is not defined
Traceback (most recent call last):
  File "lib/doodleDelegate.pyc", line 84, in sendEvent_
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.7/vanilla/vanillaBase.py", line 514, in action_
    self.callback(sender)
  File "ThemeManager.py", line 387, in exportThemeCallback
NameError: name 'plistPath' is not defined

ThemeManager not opening in RF v4.4b (build 2305191108)

Traceback (most recent call last):
  File "ThemeManager.py", line 635, in <module>
  File "lib/scripting/nameSpaceCallbacks.pyc", line 52, in OpenWindow
  File "ThemeManager.py", line 156, in __init__
  File "ThemeManager.py", line 551, in makeBackupTheme
TypeError: float() argument must be a string or a number, not 'NoneType'

Cannot open ThemeManager in RF4

Here's the output

/Users/robertoarista/Library/Application Support/RoboFont/plugins/ThemeManager.roboFontExt/lib/ThemeManager.py:517: DeprecationWarning: The readPlist function is deprecated, use load() instead
  themeData = readPlist(plistPath)
Traceback (most recent call last):
  File "ThemeManager.py", line 629, in <module>
    OpenWindow(ThemeManager)
  File "/Users/robertoarista/Documents/Repositories/RF_virtualApp/roboFont.test/roboFont.source/robofont/lib/scripting/nameSpaceCallbacks.py", line 51, in OpenWindow
    scriptingWindowController[key] = controller(*args, **kwargs)
  File "ThemeManager.py", line 155, in __init__
    self.makeBackupTheme()
  File "ThemeManager.py", line 545, in makeBackupTheme
    data = dataType(data)
TypeError: 'NoneType' object is not iterable

👋

Point coordinates can't be light on a dark background (they disappear or are covered by black)

I have a WIP dark theme, but I've come across a problem: point coordinate values are very difficult to read.

Unfortunately, even when I try changing their color to something like yellow or magenta, they appear to have that color but also be covered in black:

Worse, if I go to white or almost white, it completely fades away, as if the blend mode were "multiply" or something:

My guess is, this might be a RoboFont issue. Is there a good way to find out?

Traceback on Ventura

/Applications/RoboFont.app/Contents/Resources/lib/python3.7/vanilla/py23.py:6: DeprecationWarning: The py23 module has been deprecated and will be removed. Please update your code.
/Users/<user>/Library/Application Support/RoboFont/plugins/ThemeManager.roboFontExt/lib/ThemeManager.py:517: DeprecationWarning: The readPlist function is deprecated, use load() instead
Traceback (most recent call last):
  File "ThemeManager.py", line 629, in <module>
  File "lib/scripting/nameSpaceCallbacks.pyc", line 51, in OpenWindow
  File "ThemeManager.py", line 155, in _init
  File "ThemeManager.py", line 545, in makeBackupTheme
TypeError: 'NoneType' object is not iterable

Also include glyph colors palettes?

(lazy feature request)

Add license to Theme-Manager & to the themes themselves

Hey folks, Theme Manager is currently missing a license file, and so are the individual themes therein. Since they are in the Theme Manager repo, it’s conceivable they are licensed under the same terms TBD, but it’s worth checking with the theme authors, too.