Giter Site home page Giter Site logo

installer's People

Contributors

fiedsch avatar leofeyer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

installer's Issues

Throw an error if wrong config

Today I had the problem, that I couldn't get my component to be installed in the assets folder.
After long search and some help I found out, I had my "contao-component-dir": "assets" entry within config, not extras. In such cases the installer should throw an error.

Error in documentation

Your documentation show the old path for the component dir, should be corrected to

"extra": {
    "contao-component-dir": "assets"
  },

Not assets are installed when extra.component-dir is not defined.

I ran into an issue, where I forgot to define extra.component-dir in my root composer.json. No assets will be installed in this case even though the readme states "By default, the components will be installed into a components/ directory".

if ($componentDir = $this->hasComponentDir($composer, $io)) {
$this->installer = new LibraryInstaller($io, $composer, 'contao-component');
} else {
$this->installer = new NoopInstaller();
}

I wondered if we could default to assets and remove the option at some point as this directory seems to be needed for Contao's other assets anyways like js/css/img (which are hardcoded). We would probably need to check if the current root composer.json is indeed an app, so that assets won't get installed when required during development of bundles.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.