Giter Site home page Giter Site logo

Comments (15)

aschempp avatar aschempp commented on May 28, 2024

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

It would not contain anything but an empty container for the end-user to customize the application. You wanted me to add this FIXME, therefore I figured you'd have something in mind?

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

I don’t think we should add an AppBundle. AppBundle is for «real developers», similar as if you would create a new system/module in Contao 3. The app/Resources are for customization, similar to langconfig.php and initconfig.php

We still need to support AppBundle though as it is the new system/modules/z_custom.

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

How do we support it if we don't add it?

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

What do you mean? We’re supporting translations in app/Resources but also do not ship any?

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

I see. By the way, I think I can remove the FIXME entry, because its related to Contao templates only and these either lie in a bundle, in a legacy module or in /templates but never in src/AppBundle, right?

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

There sure is, in src/AppBundle/Resources/contao/templates

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

No, because following the Symfony standards, customized templates go into app/Resources and not in src/AppBundle/Resources.

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

Yeah, but:

  • Customized templates from third-party bundles (from vendor) will be in app/Resources
  • Your custom bundle (src/AppBundle) can still contain its own templates for its own frontend modules

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

No, that's not correct according to the "Symfony best practice" book.

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

You might be right, but it's all a bit messy to me and confusing because we're not a standard Symfony application… In Twig different bundles can have the same template name and it would still work (because of Bundle subfolders in app/Resources).

from standard-edition.

discordier avatar discordier commented on May 28, 2024

I'd rather not put empty directories (which must contain a .gitignore or the like to be present).
If end users want to build a custom app bundle, they most likely already know how to do so. If they do not know, they most likely don't want to build one.

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

Ok :)

from standard-edition.

tsarma avatar tsarma commented on May 28, 2024

These kind of decisions are very much appreciate in Contao 4 documentation page. Because people tends to learn Symfony in standard installations and when they come to Contao 4, like myself, they might also get confused to see some standards folders are missing!

from standard-edition.

discordier avatar discordier commented on May 28, 2024

@tsarma The documentation is community maintained, feel free to file a pull request against the docs.
For details please refer to @aschempp who is responsible for merging the docs (He is on holiday for the next two weeks though).

from standard-edition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.