Giter Site home page Giter Site logo

Do not gitignore files about standard-edition HOT 7 CLOSED

contao avatar contao commented on May 28, 2024
Do not gitignore files

from standard-edition.

Comments (7)

leofeyer avatar leofeyer commented on May 28, 2024

It would be up to the user to adjust the file then. Otherwise the repo gets flooded with a lot of new files (I e.g. have the Contao demo installed on my dev system).

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

I thought the distribution should contain configuration for everyone, not just for you ;-)

from standard-edition.

leofeyer avatar leofeyer commented on May 28, 2024

Indeed. And folders which are not part of the distribution should be ignored. Maybe someone else wants to rename the /files directory.

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

Well if that would be true, the gitignore should ignore everything except the known ones… but I guess you agree that would not make sense.

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

We discussed to keep the ignore for the following reason:

  • Both directories (files and templates) are managed from the Contao backend
  • Files that should be under version control should very likely not be placed in that folder(s)

For templates, they can be places in src/AppBundle/Resources/contao/templates. Assuming the AppBundle is loaded last in the AppKernel, any other bundle templates can be overridden.

As an example for files: You probably want to place your design files in web/layout and not in web/files/layout. They should not be manageable through the backend, but they would then be under version control.

from standard-edition.

dmolineus avatar dmolineus commented on May 28, 2024

Files outside the files folder are not accessible by the file picker and so could not be added as external CSS file.

from standard-edition.

aschempp avatar aschempp commented on May 28, 2024

That's true, I used a custom header script tag to solve that.

from standard-edition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.