Comments (3)
https://github.com/convco/convco/blob/master/src/git.rs#L167 could be faster if the for each stops at the first match.
What is the expected time? For example how long does a git log previous..HEAD -- path/
takes?
from convco.
I was wrong, the code already stopped the for_each at the first path found.
I made a fix that will probably improve performance, but i am not sure about it.
Would you be able to test #195?
Or do you know a similar public repo I could test this?
I thought there is a second improvement possible by only doing 1 diff for version, but this will not be possible as we need to make 1 diff per commit to know if the path is included.
We know make a diff to before parsing the commit to a conventional commit. It might be useful to parse the commit first and filter on commits that are breaking or increment the version. This would skip useless diff calculations.
from convco.
I tried to do some benchmarks, but i could not find a difference.
from convco.
Related Issues (20)
- v0.4.1 --from-stdin regression HOT 5
- Improve releasing HOT 4
- Missing release assets for macOS and Linux in v0.4.2 HOT 2
- bug: `convco commit` allows invalid scopes HOT 9
- Consider warning user if `convco commit` is run without any staged files HOT 4
- `version` is not working properly on `prerelease` HOT 6
- Improve patch and intent to add
- Default YAML file unavailable HOT 2
- Display commit revision for latest Tag, or first commit HOT 3
- feat: support COMMIT_EDITMSG HOT 7
- [FEAT] Support path globs for `convco version --path` HOT 6
- Better Documentation for using convco as git editor HOT 2
- Tag which is being ignored HOT 2
- a repository with sparse-checkout fails HOT 2
- `check` documents `--merges` for `changelog` HOT 1
- Arrow keys not supported for moving cursor in dialoguer input HOT 2
- Ignoring case in serde deserialization for config `types` HOT 3
- Breaking change is missing spaces in description HOT 1
- Breaking change might have duplicated headers HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from convco.