Giter Site home page Giter Site logo

Comments (3)

hdevalke avatar hdevalke commented on June 2, 2024

https://github.com/convco/convco/blob/master/src/git.rs#L167 could be faster if the for each stops at the first match.

What is the expected time? For example how long does a git log previous..HEAD -- path/ takes?

from convco.

hdevalke avatar hdevalke commented on June 2, 2024

I was wrong, the code already stopped the for_each at the first path found.
I made a fix that will probably improve performance, but i am not sure about it.

Would you be able to test #195?
Or do you know a similar public repo I could test this?

I thought there is a second improvement possible by only doing 1 diff for version, but this will not be possible as we need to make 1 diff per commit to know if the path is included.

We know make a diff to before parsing the commit to a conventional commit. It might be useful to parse the commit first and filter on commits that are breaking or increment the version. This would skip useless diff calculations.

from convco.

hdevalke avatar hdevalke commented on June 2, 2024

I tried to do some benchmarks, but i could not find a difference.

from convco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.