conversant/rtree

Hyper-Dimensional R-Tree Index in Java

rtree's Issues

The constructor function of "RTree" is protected

Hi:

It is kind of you to open your source code on github. But I would like to know why you make the constructor function of "RTree" protected?

I would like to use your RTree on my own project, but I find I could not new a RTree, because the constructor is protected.

Would you like to solve this problem?

Error in "Branch.intersects(HyperRect rect, Consumer<T> consumer)"

rtree/src/main/java/com/conversantmedia/util/collection/spatial/Branch.java

Line 197 in 0d792e3

child[i].search(rect, consumer);

This line should be

child[i].intersects(rect, consumer);

Missing variants of search and intersect APIs

Current APIs in this RTree fill in results in either statically sized T[] or functionally via Consumer (since Java 8).

It would be nice to support general resizable targets such as any java.util.Collection or resizable T[]. Perhaps extend SpatialSearch with int search(HyperRect, T[], int) for paged search as well, like in Node.

Collection version isn't exactly hard to emulate with a Consumer but is very annoying to implement for every target collection type and not available on Android older than SDK 24.

This is actually not a balanced tree！！！

The R-tree established in this project can't guarantee the balance of the tree. In fact, R-tree described by Guttman is a balanced tree in "R-TREES: A DYNAMIC INDEX STRUCTURE FOR SPATIAL SEARCHING".

Add examples to the README

Could you add some example use cases to the README? It took me a while to read the code and see how exactly to create an RTree (constructors are protected and it is not so obvious that SpatialSearches should be used) and how to use them.

RTree constructor is protected

The RTree constructor (here) have the protected atribute.
How I am suposed to instantiate it once I have imported the library?

Rect3d.getNDim() should return 3

rtree/src/main/java/com/conversantmedia/util/collection/geometry/Rect3d.java

Line 88 in 0d792e3

return 2;

Should return 3 instead

bug in branch

hi.I test the code and run some data and find some bug.
In branch.java function add should return this not child[i].return child[i] will miss some leaf.
here is code:
if(size < mMin) {
for(int i=0; i<size; i++) {
if(child[i].getRect().contains(tRect)) {
child[i] = child[i].add(t);
mbr = mbr.getMbr(child[i].getRect());
return child[i];//here should return this
}
}