convex-dev / convex Goto Github PK
View Code? Open in Web Editor NEWConvex Main Repository - Decentralised platform for the Internet of Value
Home Page: https://convex.world
License: Other
Convex Main Repository - Decentralised platform for the Internet of Value
Home Page: https://convex.world
License: Other
Since maps can be coerced to vectors, they should be coercible to sets (matching Clojure behavior by the way). Currently
(vec {:a :b}) ;; => [[:a :b]]
(set {:a :b}) ;; => Cast error
We should have a custom if statement that mirror Java / JS
if (condition) {
dosomething();
}
Suggest getting code blocks working first.
There is a potential exploit with Memory Accounting if the Account records are not fixed size:
Might not be practical (the transaction of triggering the refund of 1-2 bytes may not be economically viable), but still a risk to plug. BEst solution is probably just to make balance and allowance 64-bit
Since CVM doubles rely on actual doubles and floating math, it is possible to produce Infinity
:
(/ 1 0) ; => Infinity
(/ -1 0) ; => -Infinity
Since they are valid results, it should be accessible to the user just like NaN currently is.
Fix: Adding Infinity and -Infinity in Symbols
and register them as special symbols in Core
.
It should be possible for function application to be applied repeatedly, so that a function can be returned from another function and immediately applied.
f(a)(b)
Which should be interpreted as ((f a) b)
in Convex Lisp.
May require a rule with ZeroOrMore(FunctionParameters)
or similar, similar to how we handle InfixExtension
.
Both in literal notation and by using keyword
or symbols
, anything more than 32 chars is not understood by the CVM (syntax error and cast error respectively).
(count "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa") ;; => 33
(symbol "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa") ;; => Cast error
'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ;; => Syntax error
Is it a design decision?
The Compiler
handles the case where no argument is provided to unquote-splicing
by returning the Context
in an exceptional state: https://github.com/Convex-Dev/convex/blob/master/src/main/java/convex/core/lang/Compiler.java#L275
However, upstream execution does not envision that the Context
could indeed be in an exceptional state which throws a fatal error:
Edit: Actually, exactly the same situation with unquote
.
Currently it is possible to create an account directly with a transfer
. We should consider if this is wise, and perhaps require an explicit create-account
operation (which might require a signature for the target account)
Rationale:
set-holding
Downsides:
In Clojure, lists are not associative and do not provide random access, unlike vectors.
In Convex, what lists are and their difference from vectors is a bit confusing since you can use assoc
and get
.
(assoc (list :a :b) 0 :OK) ;; => '(:OK :b)
(get (list :a :b) 1) ;; => :b
Furthermore, it muddles the algorithmic difference between get
and nth
, where get
should be about an optimal random access whereas nth
is supposedly linear (converting any data structure to a sequence (logical list) and hoping from cell to cell).
With new embedding changes, there is a risk that some of the large composite objects could have a message size that exceeds the maximum, which would cause many nasty problems
We need to validate the maximum encoding size for every object type.
Suggested strategy:
Seems broken at present.
recur
should allow recurring with different arity of the same function.
In a low-level language like C, booleans are simply integers and can behave as such. However, in a high-level language, this should be unexpected for the sake of type safety. Even Java agrees.
So I strongly argue that the following should be illegal:
(number? true) ;; => true
(inc true) ;; => 2
Looking at the implementation of CVMBool.longValue
, it looks like it has been designed on purpose. Any rationale?
Currently we just have a simple import macro:
(import some-address :as alias)
Should extend this and consider:
refer
)convex.core
default bindingsNeed to implement staking functions in the runtime library.
Key operations:
Convex should allow 'import' as a statement to create an alias to actor / library code.
Intended usage
(import "adc7f06290972f6aafee38509cf662c42d13dcfed128dc99dc7ceb7414c71062" :as my.library)
(my.library/do-stuff 1 2 3)
Currently the command (source) of an Invoke Transaction is stored, but not its result.
When it comes to quoting and unquoting, the fact that the litteral notation for NaN
is a regular symbol creates that kind of inconsistent behavior:
'[NaN] ;; => Actually, NaN is a symbol
'[~NaN] ;; => Ok, NaN is NaN
'#{~NaN} ;; => For some reason #{(unquote NaN)}
Intuitively, I don't think you can solve this at the level of quoting/unquoting. It might be that NaN
and +-Infinity
(in the future) should be expressed through a dedicated notation. For instance, Clojure uses ##NaN
.
Currently, the Reader
accepts doubles that start with a dot:
(= .5 0.5)
While this is acceptable, it creates pathological cases with symbols since they accept dots as valid characters:
'a.5 ;; => Symbol
'+.5 ;; => Double, 0.5
def x = 1
def x = { printlnt("Hello"); 1;}
def x = 1;
def y = 2;
def z = let (x=1, y=2) { x + y };
Should be a Scrypt equivalent to call
and deploy
in Lisp.
Something like:
call actor-address function_name(arg1,arg2)
call actor-address offer 10000 function_name(arg1,arg2)
Currently convex.asset
does:
(defn balance
^{:doc {:description "Return's asset balance for owner.",
:examples [{:code "(balance asset-address owner)"}]
:type :function
:signature [{:params [asset-address owner]}]}}
[asset-address owner]
(call (address asset-address) (balance owner)))
Perhaps there should be an explicit cast (balance (address owner))
in the final line? This would allow users to be a bit looser in address formats (can use literal blobs) and mean that the SPI can assume an actual address?
Currently Strings are encoded directly as embedded objects.
We need a way to cleanly separate:
Perhaps needs a custom AString type that implements CharSequence
The following destructuring breaks the executing account:
This is due to how the CVM currently handles what we could call "non-terminal &":
(let [[a & b c d e] [1 2 3 4 5 6 7 8]] [a b c d e])
;; => [1 [2 3 4 5] 6 7 8]
This is really tricky, so tricky that it is illegal in Clojure which only tolerates &
in a terminal position (ie. [... & binding]
).
That was surprising but yes, filter
is indeed missing in Core. For a language relying so much on functional programming, it should be added.
Edit: And similarly, filterv
if a difference is ultimately implemented between map
and mapv
.
Keywords do not support namespaces but providing one in the literal notation (akin to symbols) produces this weird behavor:
(= :foo/bar
:bar)
;; true
Probable cause: According to Mike, the Reader
reuses the symbol implementation for keywords and openly discards the namespace.
We should be able to support tail calls on the CVM with a simple trampoline at virtually no excess cost (as we do with halt
and rollback
.
This should make some recursive algorithms much more practical.
Should probably be explicit (core function?)
Should be possible to execute multiple statements in a block:
{
a();
1+2;
f(a);
}
Which should translate to something like:
(do
(a)
(+ 1 2)
(f a))
Probably needs rules:
Block
which contains zero or more statementsStatementSeparator
that matches a semicolon and optional spacing.Will need to disambiguate from a map literal. Normal maps will have at one or more (odd number) commas as separators, which should be clear. {}
might be tricky.
@kroezone what do you have in mind for the syntax? Here's a Python-ish syntax:
Convex Lisp | Convex Scrypt | Python |
---|---|---|
(def x 1) |
def x: 1 |
x = 1 |
(defn inc [x] (+ x 1)) |
defn inc(x): x + 1 |
def inc(x): x + 1 |
(let [x 1 y 2] (+ x y)) |
let x = 1 y = 2 in: x + y |
- |
(inc 1) |
inc(1) |
inc(1) |
(do (println "Foo") 1) |
do: println("Foo") 1 |
- |
Unlike in other languages, those two functions cast NaN and +-Infinity to 0 producing this kind of inconsistent behavior:
(= 1 (inc NaN)) ;; A
(= NaN (+ 1 NaN)) ;; B
This is due to the fact that in Java, casting those to long
indeed produces 0. Indeed:
(= 0 (long NaN)) ;; Valid by itself, expected on the JVM
However, B is the right way to handle it. Other math functions seem to behave well because they don't cast doubles to longs (they do the opposite if needed), meaning that those special values are left intact and follow proper float arithmetics.
The CVM will require special handling for non-embedded Strings that exceed a certain length (similar to Blob / BlobTree).
Need to implement:
Scrypt should probably have a statement equivalent to the usual (let [...] ....)
form in Lisp
Examples:
let (x=1) x+2;
let (a=1, b=a+1) {a * b;};
(1 + let (b=10) b*b)
Might need to think a bit about whether semicolons are mandatory. Probably not? We should perhaps think of this as a let expression rather than a statement?
Currently NFT actor seems to accept transfers of NFTs to itself:
(import convex.nft-tokens :as nft)
(call nft (create-token nil nil))
=> 0
(call nft (create-token nil nil))
=> 1
(call nft (create-token nil nil))
=> 2
(asset/balance nft *address*)
=> #{1,2,0}
(asset/transfer nft [nft #{1 2}] nil)
(asset/balance nft *address*)
=> #{0}
Would expect the transfer (penultimate line) to fail?
The length of a input hexstring for a Blob
should be of even length. However, it seems the Reader
is buggy and can't handle odd length at all:
0xfff
ERROR (UNDECLARED)
'xfff' is undeclared.
This is certainly confusing for the user.
On a similar note, fix to #54 works but the cast error remains cryptic to the user. Maybe hinting that a hexstring must be of even length? Otherwise it gives the impression that strings in general cannot be cast to blobs.
(blob "f")
ERROR (CAST)
Cast error: Can't convert f of class convex.core.data.StringShort to class class convex.core.data.ABlob.
Either from the sandbox or directly on the CVM:
(fn ([]) ([a]))
;; => (fn (fn [] nil) (fn [a] nil))
Result is an invalid form, evaluating it produces:
Compile: fn instance requires a vector of parameters but got form: (fn [] nil)
Namely:
(= NaN NaN)
;; True
The standard defines that this must be always false.
Using scientific notation mEx
, all common languages allow m
to be an integer.
Eg. 5e2
Convex Reader
understands only double m
:
5.0e2 ;; => OK
5e2 ;; => Error, "e2" is undeclared
Related to #53 , I have a hard time understanding how the Reader
escapes/unescapes things. For example, trying these in the sandbox (as is) or directly evaling on the CVM (manually escaping since talking to the JVM):
"\\" ;; Fine
"\"" ;; Fine
"\b" ;; Syntax error
"\n" ;; Syntax error
Either I am confused or there is something to clarify ;)
Convex should make use of a PKCS #12 key store
Key points:
Need to enable reduce functionality for BlobMaps that operates in-order.
What should happen with:
(long 0xFF) ;; 255?
(long 0x1000) ;; 4096>
(long 0xFFFFFFFFFFFFFFFF) ;; -1?
(long 0xFFFFFFFFFFFFFFFFFF) ;; argument error?
Behaviour is currently undefined, seems to be an issue.
PROBLEM: When writing EDN, Blob
outputs its content as a number in hexadecimal notation, meaning that the EDN reader interprets it as a long or a bigint (eg. Clojure's BigInt
). While it somewhat works, it is highly uncomfortable. For instance, Clojure's BigInt
do not support bitwise operations and any meaningful work becomes tedious.
FIX:
a) Output an actual hexstring, a proper string. Currently prevented by #53. Not perfect but arguably more amenable than a large number.
b) Output a vector of individual bytes. Technically accurate but can be slow for bigger data (especially in Clojure). On the other hand, data stored on chain should not be huge.
Weird title, but this is not legal scientific notation, the exponent must be an integer:
1.0e5.1234
The Reader
gets confused and returns the decimal part of that kind of exponent instead of detecting an invalid number:
0.1234
Operations like those fail in Clojure which is arguable more coherent. The fact that chars are somewhat numbers look more a leaky abstraction leading to counter-intuitive results (unless one is accustomed to C).
(+ \a 42) ;; => 139
(inc \a) ;; => 98
(max \ù 42) ;; => ù
Both actor?
and account?
should be used with an argument that is castable to an address, as described in their docstring. However, while account?
throws when this is not the case, actor?
actually accepts all kind of arguments.
Not a huge deal but inconsistent, so preferably both would behave the same (either solution).
Otherwise it might make it slightly harder for beginners to grasp the difference between actor?
, account?
, and address?
.
As reminded by this line (https://github.com/Convex-Dev/convex/blob/master/src/main/java/convex/core/data/AString.java#L17), quotes are not double-escaped when writing EDN.
This means that if a string contains quotes, its output disrupts the whole EDN string which cannot be read back (not accurately at least).
I can PR a simple fix however:
How is it managed API-wise when the result of a transaction is such a string, in JSON? .toString
seems to suffer from the same problem. Is it relevant? I cannot find the answer in the codebase but it seems to behave well.
Isn't it a problem at the level of the Reader
? For instance, the code example from actor?
in core-metadata.doc
:
Source file:
(actor? \"1Ba377262D7637068C8a84b732e30d3Ff62bA891\")
After reading the file, Java string, single-escaped quotes become double-escaped:
"\"(actor? \\\"1Ba377262D7637068C8a84b732e30d3Ff62bA891\\\")\""
After feeding to Reader
, single-escaped again:
#object[convex.core.data.StringShort 0x1f11cb95 "(actor? \"1Ba377262D7637068C8a84b732e30d3Ff62bA891\")"]
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.