cormachogan/vsphere-csi-helmchart

Helm Chart for vSphere CSI Driver

vsphere-csi-helmchart's Issues

Why is the controller running on a master? (and CPI?)

After diving into the templates in other issues, it occurs to me that the controller pod is being configured to run on a master, and IMO it should not be. Do we know why this is the case?

For a point of comparison, Pure Storage CSI does not: https://hub.helm.sh/charts/purestorage/pure-csi

Also there is this "CPI" pod that is also running on the masters (all of them, as a daemonset).

values.yaml has duplicate keys

vsphere-csi-helmchart/charts/vsphere-csi/values.yaml

Lines 162 to 173 in ed3da60

	podAnnotations: {}
	podSecurityContext: {}
	# fsGroup: 2000
	securityContext: {}
	# capabilities:
	# drop:
	# - ALL
	# readOnlyRootFilesystem: true
	# runAsNonRoot: true
	# runAsUser: 1000

Also not sure which pods/deployments these settings apply to, is it for all pods created by the chart?

Reset gh-pages branch

I tried to do a PR for this, but it won't let me

I would suggest resetting your gh-pages branch completely...

git checkout master
git branch -D gh-pages # remove local branch
git checkout --orphan gh-pages
git rm -rf charts README.md
git commit -m 'Reset gh-pages'
git push -f origin gh-pages

This, of course assumes your github remote is named origin :)

That way there is not an out-of-date copy of everything in gh-pages...

Add global variables for CPI and CSI

Allow the use of config.global parameters to feed same values - such as VC, username, password into both CPI and CSI helm charts.

0.0.3 release is not in index.yaml

Not sure exactly how it all works together, but the index.yaml does not have the 0.0.3 release.... however 0.0.2 points to the 0.0.3 tgz, so its effectively the same, right? Just thought I'd let you know there was some funkiness there.

vsphere-csi-node should be prevented from running on Windows nodes

Log events:

Events:
  Type     Reason          Age                  From                    Message
  ----     ------          ----                 ----                    -------
  Normal   Scheduled       11m                  default-scheduler       Successfully assigned vsphere/vsphere-csi-node-2tf4c to den3w6kubew01
  Normal   Pulling         11m                  kubelet, den3w6kubew01  Pulling image "quay.io/k8scsi/csi-node-driver-registrar:v1.2.0"
  Warning  Failed          11m                  kubelet, den3w6kubew01  Failed to pull image "quay.io/k8scsi/csi-node-driver-registrar:v1.2.0": rpc error: code = Unknown desc = failed to register layer: re-exec error: exit status 1: output: Failed to safefile.OpenRelative failed in Win32: open \\?\C:\ProgramData\docker\windowsfilter\9d6d17d1c2eb7dfddc430b9c5699f528b6581bf1e4f871e8b8cf84758a03fb05: The filename, directory name, or volume label syntax is incorrect. (0x1f) .\
  Normal   Pulling         11m                  kubelet, den3w6kubew01  Pulling image "gcr.io/cloud-provider-vsphere/csi/release/driver:v2.0.0"
  Warning  Failed          11m                  kubelet, den3w6kubew01  Failed to pull image "gcr.io/cloud-provider-vsphere/csi/release/driver:v2.0.0": rpc error: code = Unknown desc = image operating system "linux" cannot be used on this platform
  Normal   Pulling         11m                  kubelet, den3w6kubew01  Pulling image "quay.io/k8scsi/livenessprobe:v1.1.0"
  Warning  Failed          11m                  kubelet, den3w6kubew01  Failed to pull image "quay.io/k8scsi/livenessprobe:v1.1.0": rpc error: code = Unknown desc = failed to register layer: re-exec error: exit status 1: output: Failed to safefile.OpenRelative failed in Win32: open \\?\C:\ProgramData\docker\windowsfilter\c686e29ee6cefb5ce53dc4891503b1105dfe1e1fc1fce4190c90823cf5d783eb: The filename, directory name, or volume label syntax is incorrect. (0x1f) .\
  Normal   BackOff         11m (x2 over 11m)    kubelet, den3w6kubew01  Error: ImagePullBackOff
  Normal   BackOff         11m (x2 over 11m)    kubelet, den3w6kubew01  Error: ImagePullBackOff
  Normal   SandboxChanged  11m (x3 over 11m)    kubelet, den3w6kubew01  Pod sandbox changed, it will be killed and re-created.
  Normal   BackOff         104s (x43 over 11m)  kubelet, den3w6kubew01  Back-off pulling image "quay.io/k8scsi/csi-node-driver-registrar:v1.2.0"

namespace is not set correctly (hard coded to kube-system) on several resources

We try to keep kube-system from being filled up with a bunch of third party resources, so I was using

--set config.namespace=vsphere

... but stuff didnt start up because some things (secret) were created in the specified namespace, while others (deployment/vsphere-csi-controller; daemonset/vsphere-csi-node; serviceAccount/vsphere-csi-controller)

Specifically, the csi-controller couldn't start cause it couldn't find the secret.

Issues with startup: vsphere-csi-controller 5/6 Error - csi-resizer crashing

I tried to install this and got...

[tmcneely@DVA-C02ZG12HLVDV vsphere-csi-helmchart] (⎈ |admin@den3test:vsphere)$ k get po
NAME                                      READY   STATUS              RESTARTS   AGE
vsphere-cpi-4cfzk                         0/1     ContainerCreating   0          3m7s
vsphere-cpi-d5vl5                         0/1     ContainerCreating   0          3m7s
vsphere-cpi-xl8bj                         0/1     ContainerCreating   0          3m7s
vsphere-csi-controller-55d85c9cd4-5vmqc   5/6     Error               5          3m7s
vsphere-csi-node-6f5dd                    3/3     Running             0          3m7s
vsphere-csi-node-874h8                    3/3     Running             0          3m7s
vsphere-csi-node-fcjsc                    3/3     Running             0          3m7s
vsphere-csi-node-fhvxm                    3/3     Running             0          3m7s
vsphere-csi-node-s577v                    3/3     Running             0          3m7s
vsphere-csi-node-t7nrw                    3/3     Running             0          3m7s

---

The vsphere-cpi pods are stuck on:

Events:
  Type     Reason       Age                  From                                Message
  ----     ------       ----                 ----                                -------
  Normal   Scheduled    2m58s                default-scheduler                   Successfully assigned vsphere/vsphere-cpi-4cfzk to den3l6kubem02.davita.corp
  Warning  FailedMount  55s                  kubelet, den3l6kubem02.davita.corp  Unable to attach or mount volumes: unmounted volumes=[vsphere-config-volume], unattached volumes=[vsphere-config-volume cloud-controller-manager-token-rqf9n]: timed out waiting for the condition
  Warning  FailedMount  50s (x9 over 2m58s)  kubelet, den3l6kubem02.davita.corp  MountVolume.SetUp failed for volume "vsphere-config-volume" : configmap "cloud-config" not found

Apparently we need a configMap named cloud-config? Is that something missing from the helm chart or? I have a guess that this is somewhat the same contents as the secret/vsphere-config-secret?

---

The csi-controller is stuck on CrashBackoffLoop on csi-resizer:

[tmcneely@DVA-C02ZG12HLVDV vsphere-csi-helmchart] (⎈ |admin@den3test:vsphere)$ k logs vsphere-csi-controller-55d85c9cd4-5vmqc csi-resizer
I0911 00:04:17.062052       1 main.go:61] Version : v0.3.0-0-g150071d
I0911 00:04:17.063050       1 connection.go:151] Connecting to unix:///csi/csi.sock
I0911 00:04:17.063663       1 common.go:111] Probing CSI driver for readiness
F0911 00:04:17.066109       1 main.go:72] failed to check if plugin supports node resize: error getting node capabilities: rpc error: code = Unimplemented desc = unknown service csi.v1.Node

Release new Version with additional values.yaml

Is it possible to release the new version of the chart with the new additional values like "csiController"?