coruus/canright-aes-sboxes

David Canright's tiny AES S-boxes

canright-aes-sboxes's Issues

Unmasked S-Box - Unassigned signal in module GF_Inv_4

Hello !
I believe the unmasked version of your AES Sbox is missing a signal assignment : on line 74-76, you do the following
assign sd = d[1] ^ d[0];
GF_MULS_2 pmul(d, sd, b, sb, p);
GF_MULS_2 qmul(d, sd, a, sa, q);
but due to the optimization you added the signal d is no longer assigned. I made it work by simply adding
assign d = {c[0], c[1]};
but I trust you might have a more elegant solution.
All the best !
P.S. : thanks for your work, it has been really enjoyable and instructive to read :)