cosimo/varnish-geoip

Varnish VCL "plugin" that geolocates client IP addresses (requires geoip)

varnish-geoip's Issues

[ Wishlist ] Please port to VMOD changes on Varnish 4

Hi.

Since Varnish 4, the VMODs need to be changed, since the old sess struct has been split, some data is in vrt_ctx->req, and some is in vrt_vtx->req->sp.

varnishdCommand failed with error code 106
Message from C-compiler:
./vcl.7z2OalIg.c:1258:44: warning: ‘struct sess’ declared inside parameter list [enabled by default]
 void vcl_geoip_send_synthetic(const struct sess *sp) {
                                            ^
./vcl.7z2OalIg.c:1258:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
./vcl.7z2OalIg.c: In function ‘vcl_geoip_send_synthetic’:
./vcl.7z2OalIg.c:1260:5: warning: passing argument 1 of ‘VRT_r_client_ip’ from incompatible pointer type [enabled by default]
     vcl_string *ip = VRT_IP_string(sp, VRT_r_client_ip(sp));
     ^
./vcl.7z2OalIg.c:431:8: note: expected ‘const struct vrt_ctx *’ but argument is of type ‘const struct sess *’
 VCL_IP VRT_r_client_ip(const struct vrt_ctx *);
[140 lines truncated]
Running C-compiler failed, exit 1
VCL compilation failed
Error: vcl.load root:dc384c58-0338-411b-8be8-2b306ca075fc /etc/varnish/default.vcl failed
 failed!

Document examples of the X-Geo-IP header.

What will this header look like? What format is it in? What happens when you can only get some information? What happens if the IP is invalid (e.g. a LAN ip)?

DB Modification Checks

Would be nice if it periodically checked if the DB has been updated such that it closed and opened the latest DB such that restarts are not required for DB updates.

Fallback country if lookup fails

Internally, we use "A6" as special fallback code to mean "failed country lookup".
We should implement something like it.

Failed for varnish ld libGeoIP

error message like:

Message from dlopen:
Compiled VCL program failed to load:
./vcl.pmCq19vo.so: undefined symbol: GeoIP_open_type
Running dlopen failed, exit 1

VCL compilation failed

---

i installed geoip like:

$ ll /usr/lib/libGeoIP.*
-rw-r--r-- 1 root root 1345150 Jul 13 16:21 /usr/lib/libGeoIP.a
-rwxr-xr-x 1 root root 921 Jul 13 16:21 /usr/lib/libGeoIP.la
lrwxrwxrwx 1 root root 17 Jul 13 16:21 /usr/lib/libGeoIP.so -> libGeoIP.so.1.6.5
lrwxrwxrwx 1 root root 17 Jul 13 16:21 /usr/lib/libGeoIP.so.1 -> libGeoIP.so.1.6.5
-rwxr-xr-x 1 root root 655553 Jul 13 16:21 /usr/lib/libGeoIP.so.1.6.5

$ ll /usr/include/GeoIP*
-rw-r--r-- 1 root root 20586 Jul 13 16:21 /usr/include/GeoIP.h
-rw-r--r-- 1 root root 2460 Jul 13 16:21 /usr/include/GeoIPCity.h

@cosimo thk for your attention.