cossacklabs/rd_themis

Themis module for Redis database

rd_themis's Issues

examples and release prep

python/ruby/go

encrypt on client, decrypt on select in db
encrypt on insert, decrypt on client

Readme fixes

• Mention dependencies, link to building Themis page in Themis GH Wiki, mention SHUnit
• Change themis -> rd_themis in Redis commands
• Explain use cases better, link examples properly

Simplify Themis building for RD_Themis

Simplify by adding Themis rep (pointing at release tag) as a submodule and build it there, statically linked.
Do is as an option in MAKEFILE.

Figure out using RedisModule_StringDMA instead of RedisModule_Call

The high-level API (i.e. RedisModule_Call) is slower than the low-level calls. Redis' SET and GET commands can be implemented with the API's RedisModule_StringDMA with the added bonus that you get back a reference rather than a copy.

Fix memory leak

Memory leak: when not using RedisModule_AutoMemory, use RedisModule_FreeCallReply. Missing around LoC: 33, 73, 152, 183

Command syntax more redis-style

1. rd_themis.cset / rd_themis.cget , rd_themis.mset / rd_themis.mget
2. Make data last positional argument

Correct error code returning

Use the REDISMODULE_ERRORMSG_WRONGTYPE define instead of REDISMODULE_ERR, LoC: 51, 170

Try async BlockClient

When doing substantial processing, it is possible to use the RedisModule_BlockClient family to offload it to a thread and free the server's main event loop. Dunno if that would help in this case, but perhaps worth testing.