coteh/hacka-news-web

:computer: A web interface for Hacker News. Uses hacka-news npm module. EJS + Semantic UI

hacka-news-web's Issues

Change expiry date of theme cookie

Change expiry date of cookie that holds the information for the current theme so that the expiry date is either a very long time away or no expiry date at all.

Remove outline around title menu item on mobile

The menu item containing the title text on mobile has a white outline that is undesired.

Add browser-sync for development purposes

https://github.com/BrowserSync/browser-sync

Regular theme on mobile should have an orange-colored menu

This will require fiddling around with Semantic UI’s theme/site CSS to ensure that orange colored settings are applied and not overridden by other Semantic UI CSS.

Use Semantic dividers (or divided grid) for news feed items

Regarding the news feed items, switch over from traditional hr dividers to either Semantic dividers or divided or celled grids.

Move menu items to a drawer menu if screen width is small enough

Perhaps do this in two phases:

1. Create the drawer menu first, moving all the menu items onto it
2. Then, add the ability to switch between the new drawer menu and the original menu depending on width of page (using media queries or some other method)

Switch to Fomantic UI

Semantic UI is dead and Fomantic UI seems to be taking the torch.

https://github.com/fomantic/Fomantic-UI

Handle stories not loading (Create an error page)

At the moment, the cli will display an error message from the hacka-news module that is produced when stories cannot load, but does not render a page for this error condition. Thus, it will hang. Fix this problem by rendering an error page that tells the user that stories could not load.

Both mobile and desktop show at the same time when browser width is 767px

I suspect the media queries will need some adjusting.

Currently, it is set up like this: style.css

@media (min-width: 768px) {
    .mobile-menu {
        display: none !important;
    }
}

@media (max-width: 767px) {
    .desktop-menu {
        display: none !important;
    }
    .stories {
        margin: 5em 1em 0em 1em;
    }
}

If there is no article link for story, then link to comments instead

Add prettier

Fix gulp install on heroku failing

At the moment, when deploying to heroku, it errors out on the semantic-ui install and the output is similar to what is depicted in this issue: Semantic-Org/Semantic-UI#4292

In the output of the run below, I tried using a shrinkwrap to override gulp-prompt's dependency of inquirer to the newest version of 3.2.3, but it did not work. This error will also come up all the same if I use a package-lock.

remote: -----> Building dependencies
remote:        Installing node modules (package.json + shrinkwrap)
remote:
remote:        > [email protected] install /tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/semantic-ui
remote:        > gulp install
remote:
remote:        [04:03:22] Using gulpfile /tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/semantic-ui/gulpfile.js
remote:        [04:03:22] Starting 'install'...
remote:        [04:03:22] Starting 'run setup'...
remote:        25l? Set-up Semantic UI (Use arrow keys)
remote:        ❯ Automatic (Use default locations and all components)
remote:        Express (Set components and output folder)
remote:        Custom (Customize all src/dist values) [04:03:22] 'run setup' errored after 39 ms
remote:        [04:03:22] SyntaxError: Invalid regular expression: /.{1,0}/: numbers out of order in {} quantifier
remote:        at new RegExp (<anonymous>)
remote:        at breakLines (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/screen-manager.js:108:15)
remote:        at module.exports.ScreenManager.render (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/screen-manager.js:55:22)
remote:        at Prompt.render (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/list.js:103:15)
remote:        at Prompt._run (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/list.js:74:8)
remote:        at Prompt.run (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/base.js:57:8)
remote:        at Object.<anonymous> (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/ui/prompt.js:84:12)
remote:        at module.exports (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/run-async/index.js:15:21)
remote:        at AnonymousObservable.__subscribe (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/utils.js:16:7)
remote:        at AnonymousObservable.tryCatcher (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/rx-lite/rx.lite.js:63:31)
remote:        [04:03:22] 'install' errored after 44 ms
remote:        [04:03:22] SyntaxError in plugin 'run-sequence(run setup)'
remote:        Message:
remote:        Invalid regular expression: /.{1,0}/: numbers out of order in {} quantifier
remote:        Stack:
remote:        SyntaxError: Invalid regular expression: /.{1,0}/: numbers out of order in {} quantifier
remote:        at new RegExp (<anonymous>)
remote:        at breakLines (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/screen-manager.js:108:15)
remote:        at module.exports.ScreenManager.render (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/screen-manager.js:55:22)
remote:        at Prompt.render (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/list.js:103:15)
remote:        at Prompt._run (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/list.js:74:8)
remote:        at Prompt.run (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/prompts/base.js:57:8)
remote:        at Object.<anonymous> (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/ui/prompt.js:84:12)
remote:        at module.exports (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/run-async/index.js:15:21)
remote:        at AnonymousObservable.__subscribe (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/inquirer/lib/utils/utils.js:16:7)
remote:        at AnonymousObservable.tryCatcher (/tmp/build_32d85e6c5ff35acee9556d5f57715041/node_modules/rx-lite/rx.lite.js:63:31)