cottonmc/cottonenergy

The Energy API.

cottonenergy's Issues

Let's Talk: EMP

The EMP system is something we haven't discussed much yet. It's an IC2-style voltage shutdown, but we don't have much of a standard for what it should do, and a few folks think we shouldn't have it. Our options:

• Keep it as-is. There's no requirement for it to do anything currently, so mods can just ignore it or have config disable it. It's a void, so it can just be empty.
• Establish a standard for what an EMP should do. This could be divisive, as enforcing a code of conduct on a power API would make people less likely/willing to use it.
• Remove it entirely. I'm personally against this option, since it would limit a few creative uses for it. EMPs could be used for a lot of different systems, both in magic and tech, so I think it's better to keep around then remove.

Let's talk about units!

The Tesla repo had a wonderfully productive, serious, and definitely-not-silly discussion about naming, and I think it's about that time for us too. Speaking about our energy without a unit is starting to become bothersome. Does anyone have a suggestion for the energy unit name, and its abbreviation?

Let's Talk: Flavors!?

We've been talking on the discord for a little while and we've decided that we want to try experimenting with flavored packets. I wanna make this for organizing logistics.

• Do we/how should we register flavors? Should they have namespaced Identifiers?
• Should WU-capables provide a list of acceptable flavors? What part of the structure should that list go on?
• What other properties should flavors have built-in? Should they get their own abstract/interface?

Review: Cotton Energy First Draft

I just pushed the first draft of the energy API. It still needs a proper name, but I wanna get people's thoughts:

• Is the API missing anything major? Is it clear enough what it does?
• Do any methods need to be renamed? Is anything confusing?
• Are the packet sizes good? Do they need to be re-adjusted?
• Do the javadocs make sense? Is there anything missing from them?

fabric.mod.json specifies a mixin 'cotton.common.json' but that isnt provided. Throws error on launch, no crash.

List of things I noticed

• Packet accepts any value, even if it's larger or smaller than the types min/max values. IMO it should be capped to the max value and be set to 0 if the value is smaller than the min value. All unused energy should be returned to whoever tried to set it.

• Energystorage has a int getCurrentEnergy() method that returns the amount of the blocks primary energy type and a EnergyType getPrimaryEnergyType method. I would suggest that we replace them with a Map<EnergyType, Integer>. This would allow one block to store multiple kinds of energy. (e.g. A battery that can store different Voltages)