cozy/cozy-banks

A Banks Aggregator on Cozy

Cozy Banks

Cozy Banks is the personal financial management application available on Cozy. It helps you gain understanding of your personal finances, and much more . As the first digital home on the market, Cozy helps all users with applications and connectors regain control, streamline and maximize their digital lives.

With Cozy Banks, you can easily:

• Have all your bank accounts in one place
• Get an comprehensive overview of all your expenses with one-click access to your bills
• Directly access your health insurance reimbursements
• Enjoy all the features for free

• Developing
• Account Types
• Bills Matching
• Brand Dictionnary
• Categorization
• Category
• Code Conventions
• Credentials
• Data Fetching
• Demo
• Notification
• Override Cordova Config
• Perfs
• Services
• Tracking
• Feature requests

Feature requests

We love getting feedback, do not hesitate if you have any. Please use the forum for any feature requests.

cozy-banks's Issues

The method should throw if the bill can't be added.

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 127 to 131 in a4e8a1e

	// TODO The method should throw if the bill can't be added.
	log('debug', `Adding bill ${bill._id} to operation ${operation._id}`)
	if (!bill._id) {

---

This issue was generated by todo based on a TODO comment in a4e8a1e when #1496 was merged. cc @cozy.

Move revocation check to cozy client

cozy-banks/src/ducks/client/mobile/mobile.js

Lines 75 to 80 in 0552776

	// TODO: the revocation check via cozy-pouch-link should not be
	// done in the app. We should find a way to have this in a shared
	// repository, possibly in cozy-client or cozy-pouch-link
	onSyncError: async () => {
	checkForRevocation(client)
	}

---

This issue was generated by todo based on a TODO comment in 0552776 when #1610 was merged. cc @cozy.

Clean up fixtures

We have a lot of files in the fixtures. Some of them must be out of date.

Use selectors for chart data

cozy-banks/src/ducks/chart/selectors.js

Lines 47 to 51 in 8d96e5a

	// TODO should be done via selectors
	return filteredTransactions.filter(
	transaction => getCategoryId(transaction) === categoryId
	)
	}

---

This issue was generated by todo based on a TODO comment in 8d96e5a when #1606 was merged. cc @cozy.

Used optimization split chunks for services

Since we have several services in Banks with several entrypoints we end up
with several bundles whose content is mostly shared code. It would be good
to use webpack's optimization.splitChunks.

It is not supported yet in webpack 4 but will be in webpack 5.

PR that implements functionality: webpack/webpack#8575
Example of using split chunks: https://webpack.js.org/plugins/split-chunks-plugin/#split-chunks-example-1

So we will be able to significantly lower the total size of the banks bundle
when we use webpack 5.

Remove bluebird

We have some dependencies that could be easily removed. The benefits would be less renovate PRs to take care of and maybe lighter bundles (thus this will certainly not very significant).

• bluebird: this is used only in the bills linker. This could be easily replaced by native promises
• others?

Can't launch the application for development

I would like to try out working on cozy-banks source code but I fail to start the application.

With yarn watch:browser

$ yarn watch:browser
...
ℹ ｢wds｣: Project is running at http://localhost:8282/
...
WARNING in react-is
  Multiple versions of react-is found:
...
ℹ ｢wdm｣: Compiled with warnings.

In http://localhost:8282/, I get many errors in the console and a blank page:

With cozy-scripts start

$ npx cozy-scripts start --hot --browser
...
App successfully compiled!
  Your application:    http://banks.cozy.tools:8080
  Your local Cozy:     http://cozy.tools:8080
  CouchDB:             http://localhost:5984/_utils
  MailHog:             http://localhost:8025
  Dev assets:          http://localhost:8888
...
ERROR in multi webpack-dev-server/client?http://localhost:8888/ webpack/hot/dev-server /home/c
assou/.npm/_npx/6860/lib/node_modules/cozy-scripts/node_modules/babel-polyfill/lib/index.js /h
ome/cassou/.npm/_npx/6860/lib/node_modules/cozy-scripts/utils/reactExposer.js ./src/targets/br
owser/index.jsx                                                                              
Module not found: Error: Can't resolve '~/projects/cozy-banks/src/targets
/browser/index.jsx' in '~/projects/cozy-banks'                          
 @ multi webpack-dev-server/client?http://localhost:8888/ webpack/hot/dev-server /home/cassou/
.npm/_npx/6860/lib/node_modules/cozy-scripts/node_modules/babel-polyfill/lib/index.js /home/ca
ssou/.npm/_npx/6860/lib/node_modules/cozy-scripts/utils/reactExposer.js ./src/targets/browser/
index.jsx app[4]                                                                             

ERROR in   Error: Child compilation failed:
  Entry module not found: Error: Can't resolve '~/projects/cozy-banks/src
  /targets/browser/index.ejs' in '~/projects/cozy-banks':               
  Error: Can't resolve '~/projects/cozy-banks/src/targets/browser/index.e
  js' in '~/projects/cozy-banks'                                        

`addBillToOperation` should throw if the bill can't be added.

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 127 to 131 in a31e2e6

	// TODO The method should throw if the bill can't be added.
	log('debug', `Adding bill ${bill._id} to operation ${operation._id}`)
	if (!bill._id) {

---

This issue was generated by todo based on a TODO comment in a31e2e6. It's been assigned to @drazik because they committed the code.

Update test methodology for TransactionSelectDates

Following #426.

We should not have time-sensitive test that needs to be updated every month.

Categorisation colors

When switching between months, the color of each category changes, which makes it hard to track down the changes in proportions from one month to another.
Each category (e.g. transport) should have an assigned, constant (possibly customisable) color.

Move statusBar module to cozy-ui

cozy-banks/src/ducks/bar/statusBar.js

Lines 3 to 8 in e03c10b

	// TODO Move this module to cozy-ui
	import { getCssVariableValue } from 'cozy-ui/react/utils/color'
	export const luminosity = hex => {
	if (hex.length == 4) {

---

This issue was generated by todo based on a TODO comment in e03c10b when #1119 was merged. cc @cozy.

replace by import { getCSSVariableValue } from 'cozy-ui/transpiled/utils/colors'...

cozy-banks/src/components/Chart/LineChart.jsx

Lines 7 to 12 in af97784

	// TODO replace by import { getCSSVariableValue } from 'cozy-ui/transpiled/utils/colors'
	// when https://github.com/cozy/cozy-ui/issues/1153 is solved
	const getCSSPropertyValue = memoize(varName => {
	const computedStyle = getComputedStyle(document.body)
	return computedStyle.getPropertyValue(varName)
	})

---

This issue was generated by todo based on a TODO comment in af97784 when #1564 was merged. cc @cozy.

Filter bills upfront so `result` param is not necessary

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 462 to 465 in a31e2e6

	// TODO Filter bills upfront so `result` param is not necessary
	const unlinkedBills = this.getUnlinkedBills(result)
	log(
	'debug',

---

This issue was generated by todo based on a TODO comment in a31e2e6. It's been assigned to @drazik because they committed the code.

Extraction des opérations

Bonjour

Avez vous dans votre roadmap (je n'en ai pas trouvé) prévu de mettre à disposition une extraction des données. J'utilise un logiciel (HomeBank qui est openSource) pour gérer mes différents comptes. Je me balade donc sur les sites de mes différents comptes pour extraire sur chacun d'eux mes opérations afin de les importer dans le logiciel.

Il existe entre autres les formats qif et ofx.

J'ai bien tenté de regarder le code pour voir si ma demande à un sens mais je fais plutôt du Cobol (on ne rigole pas !!!).

Je continuerais d'utiliser vos services quelque soit votre réponse ;)

Merci pour votre boulot et bonne continuation.

Diviser une dépense

Afin d'affecter une catégorie à chaque partie d'une dépense (par exemple un achat d'alimentation + culture), on doit pouvoir diviser une dépense en définissant des sous-totaux.

Suppression de compte bancaire non pérenne

Bonjour,
Merci pour cette application très utile. Je constate cependant un bug : lorsque je souhaite supprimer un compte en banque de la liste des comptes qui sont affichés (Paramêtres -> Comptes -> [compte concerné] -> Effacer -> Confirmer la suppression), il réapparaît le lendemain. La suppression n'est pas pérenne.
Merci

Filter bills upfront so `result` param is not necessary

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 462 to 465 in a4e8a1e

	// TODO Filter bills upfront so `result` param is not necessary
	const unlinkedBills = this.getUnlinkedBills(result)
	log(
	'debug',

---

This issue was generated by todo based on a TODO comment in a4e8a1e when #1496 was merged. cc @cozy.

User agent in config.xml should be automatically updated

We should use the same method as in Assistant Fi to automatically
update the user agent used in the config.xml for Cordova.

Use the same names as the bills matchingCriterias

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 266 to 269 in a4e8a1e

	// TODO Use the same names as the bills matchingCriterias
	defaults(options, { amountDelta: DEFAULT_AMOUNT_DELTA })
	defaults(options, {
	minAmountDelta: options.amountDelta,

---

This issue was generated by todo based on a TODO comment in a4e8a1e when #1496 was merged. cc @cozy.

Use InputGroup.Unit

After next UI upgrade.

cozy-banks/src/ducks/transfers/steps/Amount.jsx

Lines 32 to 37 in 9f781d1

	// TODO remove if https://github.com/cozy/cozy-ui/pull/1113 is merged
	const InputGroupUnit = ({ children }) => (
	<Bold className="u-ph-1">{children}</Bold>
	)
	class _ChooseAmount extends React.PureComponent {

---

This issue was generated by todo based on a TODO comment in 9f781d1 when #1430 was merged. cc @cozy.

Utiliser les hooks de cozy-app-publish

Nous avons la dernière version de cozy-app-publish nous pouvons donc passer par les hooks mise en place pour unifier la configuration.

Utiliser un seul document settings au lieu d'une collection

Actuellement nous sauvegardons les préférences de l’utilisateur et d'autres informations dans un document io.cozy.bank.settings. Pour pouvoir récupérer ce document nous récupérons une collection de io.cozy.bank.settings et on prend le 1er document (on espère qu'il y en a qu'un seul)

On peut voir ce type de code:

export const getSettingsFromCollection = col =>
  merge(DEFAULTS_SETTINGS, get(col, 'data[0]'))

Je propose que l'on nomme ce document plutôt que l'id soit généré par couchdb.

On pourrait alors demander à la stack seulement un document plutôt qu'une collection.

Move mobile helpers to handle push tokens to cozy-client

cozy-banks/src/ducks/mobile/push.js

Lines 41 to 46 in 282daf5

	// TODO move this to cozy-client
	const updateRegistrationToken = (client, token) => {
	// Updates local and remote information
	const clientInfos = client.stackClient.oauthOptions
	client.stackClient.updateInformation({
	...clientInfos,

---

This issue was generated by todo based on a TODO comment in 282daf5 when #1438 was merged. cc @cozy.

Find out why our models parent class and Document from cozy-doctypes are differe...

cozy-banks/scripts/visualizer/src/server/index.js

Lines 12 to 17 in 2daf3f7

	// TODO Find out why our models parent class and Document from cozy-doctypes are different
	Document.registerClient(cozyClient)
	Bill.registerClient(cozyClient)
	class DryLinker extends Linker {
	commitChanges() {

---

This issue was generated by todo based on a TODO comment in 2daf3f7 when #1440 was merged. cc @cozy.

Remove display flex on Content after cozy-ui fixed it

cozy-banks/src/components/App.styl

Lines 2 to 5 in e6bcb05

	// TODO should not be necessary, the Main component in cozy-ui should
	// already have that
	// See https://github.com/cozy/cozy-ui/issues/1156
	display flex !important

---

This issue was generated by todo based on a TODO comment in e6bcb05 when #1568 was merged. cc @cozy.

Problème de publication avec un numéro contenant beta

Lorsque l'on modifie le numéro dans le fichier package.json avec par exemple '0.7.11-beta.2' la publication d'une version de dev echoue.

Voir le build travis pour plus d'information https://travis-ci.org/cozy/cozy-banks/builds/411628431

Compare locales to check if they are complete

Greg has made a script doing just that.

cozy/cozy-libs#602 (review)

The method should throw if the bill can't be added

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 186 to 190 in a4e8a1e

	// TODO The method should throw if the bill can't be added
	log(
	'debug',
	`Adding bill ${bill._id} as a reimbursement to operation ${

---

This issue was generated by todo based on a TODO comment in a4e8a1e when #1496 was merged. cc @cozy.

security holding package

Hi,

it seems you have accidentally added yarn.lock but this is not the real package on npmjs.

https://github.com/cozy/cozy-banks/blob/master/package.json#L211

See https://npmjs.org/yarn.lock

You might want to remove it using yarn remove yarn.lock.

Add information manually

Well, because I don't live in France

Tests log too much

There is too much logs in the tests, it is distracting and could potentially
hide buggy and/or undesirable behavior.

Ways to mitigate:

import logger from 'cozy-logger'

logger.setLevel('error')

jest.spyOn(console, 'warn').mockImplementation() # only for some test suites/test files

Extract this from this function, this is not its role to also add

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 310 to 314 in a31e2e6

	// TODO Extract this from this function, this is not its role to also add
	// the reimbursement
	if (creditOperation && debitOperation) {
	promises.push(
	this.addReimbursementToOperation(bill, debitOperation, creditOperation)

---

This issue was generated by todo based on a TODO comment in a31e2e6. It's been assigned to @drazik because they committed the code.

Déplacement d'une catégorie

La sous-catégorie "retrait d'espèces" dans les catégorisations des mouvements fait partie de la catégorie "à catégoriser" mais je trouverai plus logique qu'elle apparaisse dans "Dépenses vie courante".

De façon plus générale, il serait pratique de pouvoir créer / modifier des catégories en plus de celles existant par défaut.

Assurance vie non remontée - Connecteur Crédit Mutuel

Bonjour,

J'espère que c'est le bon repo pour faire ce signalement de bug :)
En connectant mes différents comptes bancaires, j'ai remarqué que celui du Crédit Mutuel remonte bien tous mes produits bancaires sauf un : une assurance vie. C'est étonnant, j'en ai deux et la première apparaît sans problème.

Pouvez-vous y faire quelque chose, où est-ce lié à Linxo ?

Merci d'avance,
Cordialement,

Translations case inconsistencies

We have a lot of inconsistencies in translations keys case. We have UpperCamelCase, camelCase and snake_case in it. We must clean it.

Text in nav tabs (mobile) is too close to icon

An update of cozy-ui should fix the problem (drive no longer has the problem).

Drop cozy-client-js in services

Currently in services we use a cozy-client-js instance given by cozy-konnector-libs. We should use a cozy-client instance.

It seems to be pretty simple: https://github.com/cozy/cozy-store/blob/master/src/targets/services/installSuggestion.js#L24-L28

But we need to make sure that all models' methods we are using are implemented to work with cozy-client. Some efforts were done in this direction (see cozy/cozy-libs#455) but not everything seems to work.

Extract this from this function, this is not its role to also add

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 310 to 314 in a4e8a1e

	// TODO Extract this from this function, this is not its role to also add
	// the reimbursement
	if (creditOperation && debitOperation) {
	promises.push(
	this.addReimbursementToOperation(bill, debitOperation, creditOperation)

---

This issue was generated by todo based on a TODO comment in a4e8a1e when #1496 was merged. cc @cozy.

Use Infos instead of ErrorCard

cozy-banks/src/components/ErrorCard/index.jsx

Lines 9 to 14 in bc98c2b

	// TODO Move ErrorCard to cozy-ui
	const ErrorCard = ({
	breakpoints,
	title,
	content,
	buttonLabel,

---

This issue was generated by todo based on a TODO comment in bc98c2b when #1573 was merged. cc @cozy.

[meta] Perf build

Baseline: 2421ko

• Remove duplicate lib via webpack aliasing : 2317ko

• Do not bundle all d3 inside build : 2179ko

First PR perf : #907

Possible candidates for size reduction:

• Removing moment from chart.js

  • Another approach taken by chartJS is to add the feature to have adapters to be able to replace moment by another library. chartjs/Chart.js#4303. This normally would allow us to use date-fns.
  • Remove completely moment via webpack chartjs/Chart.js#4303 (comment)

• Only import what we need from cozy-ui, verify tree shaking for cozy-ui

• Cozy Authentication build ? Why is it so big ? Transpile it.

• Localforage ?

• Cozy stack client db.json (issue here, cozy/cozy-client#109)

Move utils to Cozy-client

We have interesting utils that could be moved to cozy-client. See #1573 (comment)

Use the same names as the bills matchingCriterias

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 266 to 269 in a31e2e6

	// TODO Use the same names as the bills matchingCriterias
	defaults(options, { amountDelta: DEFAULT_AMOUNT_DELTA })
	defaults(options, {
	minAmountDelta: options.amountDelta,

---

This issue was generated by todo based on a TODO comment in a31e2e6. It's been assigned to @drazik because they committed the code.

How to write our own bank providers?

Hi devs!

I wanted to try out Cozy Banks, but noticed you don't really support many banks outside of France. I wrote a data-crawler for one of my banks in Poland, and wanted to integrate and contribute it.

But I can't see any of the providers in the repository.

Where can we find the code behind the providers, and how can we contribute?

I'm sure crowdsourcing the providers would be a much better way to cover lots and lots of banks.

Cheers!

Do not pass templateData to global template function

cozy-banks/src/ducks/notifications/Notification.js

Lines 123 to 128 in e60ec45

	// TODO Do not pass templateData to global template function
	// templateData is passed to the global template function for now but it should change
	// at some point since it is the stack that will do this part and it will
	// not receive the application specific templateData
	// To prevent this it would be good to also extract the *parts* inside bank-layout and
	// compile them with the templateData.

---

This issue was generated by todo based on a TODO comment in e60ec45 when #1577 was merged. cc @cozy.

Use Stack component from UI

cozy-banks/src/ducks/settings/Debug.jsx

Lines 17 to 22 in 3866140

	// TODO move this to ui
	// See https://github.com/cozy/cozy-ui/issues/1096
	const Stack = ({ children }) => <div className="u-stack">{children}</div>
	const Versions = () => {
	const versions = typeof __VERSIONS__ !== 'undefined' ? __VERSIONS__ : {}

---

This issue was generated by todo based on a TODO comment in 3866140 when #1394 was merged. cc @cozy.

`addReimbursementToOperation` should throw if the bill can't be added

cozy-banks/src/ducks/billsMatching/Linker/Linker.js

Lines 186 to 190 in a31e2e6

	// TODO The method should throw if the bill can't be added
	log(
	'debug',
	`Adding bill ${bill._id} as a reimbursement to operation ${

---

This issue was generated by todo based on a TODO comment in a31e2e6. It's been assigned to @drazik because they committed the code.

Display issue with the pie chart

I have a problem with the text displayed when I move the mouse pointer on the different pie charts: the text is mixed with the text bellow and is not readable. See attached screen shot.

I use Firefox 61.0.1 on macOS High Sierra. Tell me if you need more details.
Thanks for Cozy.

chore: Cleanup utility classes

Some cleanup utility classes have been moved to cozy-ui.

See src/styles/utilities.styl.

Better handling of errors

• Add a message into the div filled by React that would be displayed in case of runtime error during app initialization

This is the approach adopted by whatsapp web. When loading the page you can see "You need Firefox > 56 etc..." and then it disappears.

Le bouton Inclure les revenus de la vue Catégorisation ne rafraîchit pas le graphe

Bonjour,
Dans cozy-banks (version mobile et Android) le switch permettant d'Inclure les revenus ne rafraîchit pas le graphe lorsqu'il change d'état.
Scénario:

1. Ouvrir Cozy-banks sur la vue Catégorisation (Inclure les revenus est désactivé)
2. Cliquer sur Inclure les revenus pour l'activer.

Résultat :
Le bouton change d'état mais le graphique affiche toujours la même information

Résultat attendu:
Le bouton change d'état et le graphique affiche la répartition en incluant les revenus.
By-pass:
3. Ouvrir une catégorie
4. Revenir en arrière avec le bouton précédent
=> Le graphique est maintenant à jour