cpmpercussion/imps

IMPSy - the Interactive Musical Prediction SYstem

imps's Issues

review and test command line arguments

CLI args don't seem to always work

consider expanding messaging protocol to include other controllers - what are the possibilities?

Error with TensorFlow Call

I've tried running the predictive_music_model.py recently and got the error below. It was working at the NIME workshop in June, but suddenly kicked this up. I cloned the latest version and reinstalled all the requirements in a virtual environment.

Edit: I'm on Windows 10

`C:...\imps-master>python predictive_music_model.py --dimension=3 --log

Importing Keras and MDRNN.
Using TensorFlow backend.
Traceback (most recent call last):
File "predictive_music_model.py", line 39, in
import empi_mdrnn
File "C:...\imps-master\empi_mdrnn_init_.py", line 16, in
tf.logging.set_verbosity(tf.logging.INFO) # set logging.
AttributeError: module 'tensorflow' has no attribute 'logging'`

use poetry style packaging

switch to poetry style packaging for consistency and testing.

implement some kind of basic CI testing

should just install poetry packages and run a basic CLI command to check all versions are working.

Time predictions can be negative

The MDN model inside the IMPS system can potentially generate negative or zero time predictions (although these have probably been rare in my usage).

In particular the request_rnn_prediction function in predictive_music_model.py does nothing to prevent this.

imps/predictive_music_model.py

Line 136 in 5707ca0

def request_rnn_prediction(input_value):

The best thing to do here is probably to adjust request_rnn_prediction to have a minimum bound on time prediction (probably zero) similarly to the approach in proc_generated_touch in the model

consider doing a GUI - what are the requirements for this project

need requirements and implementation ideas for a GUI update

save weights in tflite files

this could be a useful default behaviour or a switch in the training command

review CLI commands to have one basic command

there should be one basic command imps with options to choose the sub command (run, convert, train)