craigh / downloads Goto Github PK
View Code? Open in Web Editor NEWRemake of the old PN Downloads module
Remake of the old PN Downloads module
Currently when viewing a download detail it shows you this:
Category: Base System
But if your category tree is more complex, it should show you something like this:
Category: / Root / MyModule / Base System
with each path element being a clickable link to the category. This would be a nice addition which would make the location of a download clearer.
Hi,
Similar to Up/Download?, I would like to see the ability for users to view the actual download page of an item, but not allow them to download. Presently, the furthest they can get is the listing of items. I would like to see them go one click further. This is particularly frustrating for Web Spiders to index the content.
Thanks!
Change History
comment:1 Changed 2 years ago by daddysupa
Please note I use directory based shorturls
comment:2 in reply to: ↑ description Changed 2 years ago by daddysupa
Replying to daddysupa:
Hi,
Similar to Up/Download?, I would like to see the ability for users to view the actual download page of an item, but not allow them to download. Presently, the furthest they can get is the listing of items. I would like to see them go one click further. This is particularly frustrating for Web Spiders to index the content.
Thanks!
Please note I use directory based shorturls
If a user without permissions of administration try to upload a file with an invalid extension the module shows the message "No authorization!" when it must show "The extension of the submitted file is not allowed!"
It occurs because in function "Downloads_userapi_prepare_upload", if the extension of the uploaded file isn't in the allowed extensions array calls the function "Downloads_adminapi_remove_download" that requires administration permissions.
Comment from EZcomments not working.
It is possible to assign the hook, then is possible to write comment and to send comment. Displaied message is "Success".
Commend is not listed under page.. Checked in the table, and 'modname' column is empty.
The module is being flagged as being "Incompatible" with Zikula 1.4.0. Therefore, it being blocked from being installed.
need checkbox in edit controller and filter in the API. user should filter out all inactive items.
Zikula 1.3.10 and Downloads 3.1.4 :
While editing an existing download to upload a new file with the same name as the existing file, the module will remove the file but not upload the new one.
I have to do the uploading of the new file again to make the download-link work.
Implement subscriber hooks.
Calling "index.php?module=downloads&type=admin&func=main" after update to 3.1.0 leads to; Fatal error: Call to a member function get() on a non-object in /www/htdocs/w00e9ed8/zikula/modules/Downloads/lib/Downloads/Controller/Admin.php on line 31
It would be very nice and hepfull to have "themeswitcher" like block
for downloads module. That can work like this:
1.user creates block
2.chooses category from doenloads which contest will be shown.
block shows:
dropdown menu with download items.
when item is selected item image is shown above dropdown menu (just like in themeswitcher case)
actuall bottum for download (like switch theme case for switching)
When uploading larger files it's annoying not to know whats happening. Only the OS (M$ or OS X) counter is helpfull to monitor the progress of an upload.
A simple upload monitor would be helpfull.
Maybe just scan the database each second for the uploaded filesize and display this in a small ajax window like "xxx.x MB uploaded"
Theres no need for a real % view as normally a user knows the size of his file and then is happy to be able to watch the progress.
Feature Request:
Currently only Admins can perform uploads. I would like to grant permission for a group (editors) to allow them to upload without granting admin level permissions on the module.
Content editors don't need access to the module settings but need to be able to add and edit content. Category level permissions for groups would be even better. :-)
My Editor group has permissions "Downloads::Add",*,Admin but gets an empty category list in Downloads_userapi_catSelectList because of this new permission check:
if (pnSecAuthAction(0, 'Downloads::Category', "Add::$cid", ACCESS_ADD))
This is missing in the docs and the permission-help, they speak only of a permission "Downloads::Add".
Please either document this new permission rules or change it back to "Downloads::Add" only
When adding a new download, i am getting the following error message:
File: /var/www/vhosts/xxx.net/httpdocs/cms/modules/Downloads/pnuserapi.php
Line: 2948
Message: Wrong or missing argument passed to the function
Resulting in the fact I cannot add any download and not use the module.
Zikula 1.1.1, Downloads version 2.4
Change History
comment:1 Changed 2 years ago by STING
When clicking on the option "Downloads waiting for approval", i get the following message:
File: /var/www/vhosts/xxx.net/httpdocs/cms/modules/Downloads/pnadminapi.php
Line: 153
Message: Database query failed!Unknown column 'pn_modid' in 'field list'
Seems the DB table hasn't been created properly.
I used UpDownloads? on 0.764 prior to Downloads.
comment:2 Changed 2 years ago by Lindbergh
Status changed from new to assigned
Type changed from defect to task
Component changed from common to pninit
The Db is not upgraded properly. How did you do the update?
A quick fix is to:
Add "ORDER BY $dl_categories_column[title]"
to the following functions select statement:
Downloads_userapi_categoryhandler() and Downloads_userapi_categoryhandler1()
Not sure you need this to be configurable, and you may be rewriting to have Downloads work with Zikulas category system. This would be much better.
Hi,
Used the pnTemp both inside and outside of web root. The image is generated in the folder, but does not display on screen.
Change History
comment:1 Changed 2 years ago by Lindbergh
Status changed from new to assigned
You are the first one indicating this problem. I cannot reproduce this. Please let me know more details about your server enviroment.
comment:2 Changed 2 years ago by daddysupa
When I enable captcha, here is the path generated for the image:
i beleive the double
comment:3 Changed 2 years ago by Lindbergh
The path to the image does not help. You can get support at www.cmods-dev.de in our support forums. ets discuss there.
comment:4 Changed 2 years ago by daddysupa
I tried cmods, seen people with similar issue with no resolution. Please note the same setup for formicula captcha works 100% ok. Not sure what's the difference in your implementation.
PHP5, Apache 2.
As mentioned the captcha image is generated in the right folder, but not displayed. I get the place holder with the path revealing my web server directory path (risk), and if i try to download it, it comes up as a 0 btye file.
Not I do have modsecurity installed.
Thanks,
supa
Lösung:Ändere in der pnuserapi.php Zeile 962 von Downloads folgendes:
Security check
if (pnSecAuthAction(0, 'Downloads::Category', "Add::$cid", ACCESS_ADD))
zu
Security check
if (pnSecAuthAction(0, 'Downloads::Category', "Add::$cid", ACCESS_OVERVIEW))
probably should add the search api...
If I gave permission
Group| Downloads::Category| 3::| add
it is not working.
I want to have permission adding for one categorie without moderation and others with moderation for a special group
Change History
comment:1 Changed 23 months ago by rallek
Ich habe mich heute noch einmal mit den Permissions beschäftigt. Aus meiner Sicht sollte es für die Komponente "Downloads::" die Instanz "CategoryID::FileID" geben. Das ersetzt dann die Komponente "Downloads:Add:" und ändert die Kategorie "Downoads::Category" (Abgeschaut bei Dizkus)
"Downloads::Category" sollte sich auf Anlegen und Ändern der Kategorien beziehen und später durch das Categories-Modul ersetzt werden.
Please create a block based on this forum topic: http://community.zikula.org/module-Forum-viewtopic-topic-58997-start-0.htm
Block should have a possibility to show the downloads based on the category and there should be also a possibility to show all the relevant properties (title, link, description, version, file size)
Thanks,
Martin
I got some feedback from my visitors that the download-button is a little bit "hidden" and not to recognize as it.
Maybe you can use a more significant button like the one in the screenshot.
Einige meiner Besucher haben mir mitgeteilt, dass der Dowload-Button kaum als solcher zu erkennen ist.
Wäre schön, wenn das z.B. so gelöst werden könnte wie im angefügten Screenshot.
After upgrading from 3.0.0 (?) to 3.1.3 I get the following fatal error when attempting to view
index.php?module=Downloads&type=user&func=view&lang=en&category=2
Before you ask, yes I am on core version 1.3.3.
Fatal error: Call to undefined method Downloads_Entity_Categories::get0() in /var/www/html/projects/BP/lib/Zikula/EntityAccess.php on line 45
Call Stack
1 0.0000 235240 {main}( ) ../index.php:0
2 0.1787 7003208 ModUtil::func( ) ../index.php:78
3 0.1787 7003336 ModUtil::exec( ) ../ModUtil.php:1161
4 0.1890 7090408 call_user_func ( ) ../ModUtil.php:1082
5 0.1890 7090440 Downloads_Controller_User->view( ) ../ModUtil.php:1082
6 0.3306 8206184 Zikula_View->fetch( ) ../User.php:95
7 0.3309 8208464 Zikula_View->_fetch( ) ../View.php:724
8 0.3319 8363104 include( '/var/www/html/projects/BP/ztemp/view_compiled/Downloads/user/view--t_BPMaster-l_en.php' ) ../View.php:2827
9 0.3526 8414184 Zikula_EntityAccess->offsetGet( ) ../View.php:49
To reproduce:
Hi,
I did an import of my UpDownload?. Copied the screenshots over, but they still don't display. I originally had my pnTemp outside the webroot, and thought that might be the cause, but also tried it inside the webroot with no luck. Any ideas?
Change History
comment:1 Changed 2 years ago by Lindbergh
Status changed from new to assigned
Same as for your previous problem. I need more information. I've just tested an update from UpDownload? to Downloads and it works on my test system.
comment:2 Changed 2 years ago by daddysupa
I just updated the captcha issue.
For the screenshot it's a similar issue, where i can upload the screenshot but it is not displayed, with the same zero byte file downloaded.
for file upload, it does not work.
I believe this and the captcha issue has to do with revealing the local webserver path. If you check formicula's implementation is does not reveal the local webserver path in the URL for the captcha folder, whether if it is or is not in webroot or higher.
Thanks,
supa
Hooks should either be completely removed or fully implemented. the current implementation is useless.
A full implementation would allow the admin to use the Tag module or BBSmile or whatever.
If rendering caching for the site is switched ON, then view and display functions show wrong pages (those which are previously cached).
This is because in view and display user functions Cache_id is not set.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.