crankycyclops/discountcodeurl

Magento 2 module that applies a discount code automatically via URL

discountcodeurl's Issues

I can't get it to work

Hello,
I can't get it to work

what to insert in the URL Parameter field?

Thank you

URL parameter name may conflict with other modules

Interesting scenario: We chose "code" for the URL parameter name. Unfortunately, if you create a new email template and load an existing template, the POST request uses the same parameter name. This causes an error message "Discount code XXX is invalid", where XXX is the ID code of the loaded template. Of course, because there is no such discount code. Triggered in FrontControllerInterface.php line 227.

Maybe is would be a good idea to limit the detection of URL parameters to GET requests, and to make sure that the area code is not "adminhtml". The short-term remedy is to use a unique name for the URL parameter, which could be a problem.

This was with Magento 2.4.2-p2 and 2.4.3.

PHP 8 Compatibility

It would be awesome if this module would also support PHP 8.

Any plans to check for PHP 7.4?

Do you plan to check for PHP 7.4 compatibility? Magento 2.4 wants PHP 7.4.