crazyhitty/capstone-project

Udacity android nanodegree p7

capstone-project's Issues

Add searching functionality.

More update?

Hello,is this app still in development?
Will you update this app in future?

Update RxJava and RxAndroid

Update these dependencies to their latest versions.

Implement Dagger 2

Use dagger 2 for dependency injection.

Link: https://google.github.io/dagger/android.html

Add category support

Add categories sorting for posts and show category w/ upvote count in post details.

Implement Single Responsibility Principle

https://academy.realm.io/posts/donn-felker-solid-part-1/

Integrate App Shortcuts API

User profile Toolbar title is not setting as soon as the activity is opened.

Toolbar title still remains "Predator" and changes to user's name only after user details are loaded completely.

Notification content not appearing on some pre nougat devices

Optimize user onboarding and loading experience

Improve the user experience for intro screens. Currently the intro screens look very bland and boring.

If I could offer some feedback, and this may just be my personal preference, I felt some parts of the app hampered me from getting to the content quickly. The intro screen contained quite a lot of plain text, where it might be better to use images, or a blend, to get the message across more quickly. I found some of the loading messages a bit long too. When loading an item on the "Collection" page, for instance, there is a widget that appears for around half a second that says "Success!" - but I'm thinking "why not just load the content if it was retrieved successfully, rather than wait an extra half second to see this message?"

Basically, from my perspective, the less time I spend looking at intro screens and loading messages the better.

Above feedback provided by @PPartisan on Android Nanodegree Students slack group.

Integrate Constrain layout

Replace existing viewgroups in layout files with ConstraintLayout.

Show version badges

1. For Google play.
2. For master branch.
3. For beta branch.

Use this to create a new badge: http://shields.io/#your-badge

---

Example badge code:

[![Goolgle play badge](https://img.shields.io/badge/Google%20play-v0.36-green.svg)](https://play.google.com/store/apps/details?id=com.crazyhitty.chdev.ks.predator)

Example badge preview:

Scrolling issue in users profile where user's tagline/desc is missing.

Sort by upvote

Latest update intended to add post sorting by upvote has no effect on Nexus 7 tablet (2013) or Nexus 5 phone.

Default sort order appears to be the same and I don't see any sort options in settings.

After updating on both devices, I removed/reinstalled with the same result.

As an aside, it would be nice to be able to see the vote count for each listing in the summary view as shown in this screenshot from Feline for Product Hunt:

Add tests

Add proper tests for the presenters.

Rename repository name

Rename it from "Capstone Project" to "Predator for Product Hunt"

Add calendar based search

Implement chrome custom tabs

Use this pattern to integrate chrome custom tabs in the application: https://developer.chrome.com/multidevice/android/customtabs

Also, integrate chrome custom tabs in commenting.

Use activity alias in manifest for better shortcut support

Use DiffUtils for updating recycler view

Link: https://geoffreymetais.github.io/code/diffutil/

Update comment data structure

Use tree instead of arraylist while managing comments.

Add users profile screen

Add a screen where users can view profile of other users.

Fix Widget UI

Widget's text font/color is wrong.

Create git version tags

https://git-scm.com/book/en/v2/Git-Basics-Tagging

Post vote count not updating on refreshing the post details screen.

Sort by vote count

Like your app, but would be much more useful IMO if it sorted the day's PH listings by vote count (highest to lowest) by default.

Cheers.

Android 6.0.1, Nexus 5

Application crashes on pre-nougat devices when sharing a post from post details screen.

Application crashes whenever user shares any post from its details screen.

Exception android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want?
android.app.ContextImpl.startActivity (ContextImpl.java:677)
android.app.ContextImpl.startActivity (ContextImpl.java:664)
android.content.ContextWrapper.startActivity (ContextWrapper.java:331)
com.crazyhitty.chdev.ks.predator.core.postDetails.PostDetailsPresenter.sharePostDetails (PostDetailsPresenter.java:550)
com.crazyhitty.chdev.ks.predator.ui.activities.PostDetailsActivity.onOptionsItemSelected (PostDetailsActivity.java:484)
android.app.Activity.onMenuItemSelected (Activity.java:2964)
android.support.v4.app.FragmentActivity.onMenuItemSelected (FragmentActivity.java:408)
android.support.v7.app.AppCompatActivity.onMenuItemSelected (AppCompatActivity.java:195)
android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected (WindowCallbackWrapper.java:113)
android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected (WindowCallbackWrapper.java:113)
android.support.v7.app.ToolbarActionBar$2.onMenuItemClick (ToolbarActionBar.java:69)
android.support.v7.widget.Toolbar$1.onMenuItemClick (Toolbar.java:206)
android.support.v7.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected (ActionMenuView.java:776)
android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected (MenuBuilder.java:822)
android.support.v7.view.menu.MenuItemImpl.invoke (MenuItemImpl.java:156)
android.support.v7.view.menu.MenuBuilder.performItemAction (MenuBuilder.java:969)
android.support.v7.view.menu.MenuBuilder.performItemAction (MenuBuilder.java:959)
android.support.v7.widget.ActionMenuView.invokeItem (ActionMenuView.java:623)
android.support.v7.view.menu.ActionMenuItemView.onClick (ActionMenuItemView.java:154)
android.view.View.performClick (View.java:5265)
android.view.View$PerformClick.run (View.java:21534)
android.os.Handler.handleCallback (Handler.java:815)
android.os.Handler.dispatchMessage (Handler.java:104)
android.os.Looper.loop (Looper.java:207)
android.app.ActivityThread.main (ActivityThread.java:5728)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:789)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:679)

The crash indicates that the application is starting the sharing intent without FLAG_ACTIVITY_NEW_TASK flag. But the code already has it implemented. Weird bug, I guess. Will try to move sharing functionality from Presenter logic to Activity itself.

Improve comments UI/UX

Currently, it is way too simple and it's difficult to read in some scenarios. Also, add usernames with comments and ability to view user profile from the comments section.

Update app versioning/code system

Use this concept: https://proandroiddev.com/configuring-android-project-version-name-code-b168952f3323

Abstract database layer

Database and presenters should have one more layer in b/w them.

Yes, he means that you should add one more abstraction layer. Because some day you might want to migrate to another database, if you don't hide behind another class, then you will find your self with a lot of stuff that has to be changed. For example when parse went down, a lot of people had parse all over the place, which was bad for them and it took them a while until they replace all of the parse stuff with an alternative solution.
But if they had "hide" parse behind another layer, then everything would be fine/it would require less work in order to replace it.

Source

Add Dark/Amoled theme support.

Application should support 3 type of basic themes:

• Light
• Dark
• Amoled Dark

Integrate CI

Ability to open user's personal website from user profile.

Add a menu button through which user can open any user's personal website. If no website is available, just show error text via a short toast.

Fix Vote count column typo in posts_table in database

Currently it is vote_vount. Rename it to vote_count.

Split PostDetails and About screen with TabLayout and ViewPager

Instead of showing everything in a single listing, split them into two separate entities so that the UI becomes less cluttered.

Add pinch to zoom functionality when viewing the media in full screen.

Images/Gifs should be zoomable via pinch gesture in full-screen mode.