creately/sakota

Proxies js objects and records all changes made on an object without modifying the object

sakota's Issues

Violates proxy handler invariants when proxying frozen objects

When frozen objects are proxied, the proxy should also act similar to a frozen object. When the proxy violates these invariants a TypeError will be thrown. Example: modifying an existing value on a proxy with a frozen target will throw an error. Decide whether to stick to the standard behavior or look for a workaround so that frozen objects can be proxied.

Wrap code inside foreach callback with a describe block

sakota/src/__tests__/index.spec.ts

Lines 158 to 181 in 4436e10

	].forEach(f => {
	let c: any;
	beforeEach(() => {
	c = f();
	});
	it('should apply the change on the proxy', () => {
	const proxy = Sakota.create(c.target);
	c.action(proxy);
	expect(proxy).toEqual(c.result as any);
	});
	it('should record all applied changes', () => {
	const proxy = Sakota.create(c.target);
	c.action(proxy);
	expect(proxy.__sakota__.getChanges()).toEqual(c.change);
	});
	it('should not modify the proxy target', () => {
	const proxy = Sakota.create(freeze(c.target));
	c.action(proxy);
	});
	});

These beforeEach blocks will run for all items on the array. Wrap with a describe block so that it is isolated. It works fine with this bug because the c variable is different in each case.