creative-workflow/capistrano-pm2

This is a pm2 handler for capistrano 3.x.

capistrano-pm2's Issues

app_status JSON.parse fails if pm2 process not running

Basically, up until PM2 2.4.0, calling jlist would emit a whole bunch of text relating to the pm2 daemon start up if it was not already running. As that text was not json, and capistrano-pm2 passes the output to json.parse it fails.

Discussion regarding the issue is here: Unitech/pm2#281

Basically as of 2.4.0, there's a -s flag which silences the non-json output and ensures this gem works correctly.

I've seen you're not really actively maintaining this but I've made PR #5 to address the issue. It means pm2 2.4.0 would be required as earlier versions do not support the argument.

Update app_status function for latest pm2 version 1.1.1

It appears that the pm2 jlist command no longer (at least in version 1.1.1) takes an application name as a command line argument as per the help pm2 jlist -h. This is a problem, then, because the jlist JSON output is simply an array of objects representing ALL the processes. The app_status method as it currently stands does not account for this format.

Here is an abbreviated example of the jlist JSON output from pm2 v1.1.1

[
  {
    "pid": 0,
    "name": "pm2-test",
    "pm2_env": {
      "status": "stopped"
    }
  }
]

I've overwritten the app_status function in my particular Rake task.

I would like to submit a pull request to update this. Would you be OK with that?