creatuity/magento-quality-tools

Default version of quality tools configuration used in Magento 2 projects in Creatuity

magento-quality-tools's Issues

[IDEA] Task number validator

As a developer I'd like to have a GrumPHP task which verifies whether my task number from commit message fits with the branch name .
Example :
Commit message : [PROJECTX-123] Add new feature
Branch name: feature/PROJECTX-124-new-feature
We should catch that and inform a developer that the task number is not ok.
This should work with all "task" type branches like bugifx/feature

Prepare v1.0.3 release when bitExpert/phpstan-magento will release new version

https://github.com/bitExpert/phpstan-magento/tags

It will be probably v0.26.0 or v0.25.1

It will incorporate fix for Extension Attributes from dev-master branch.

Validation of branch names

The regex for checking branch names doesn't work correctly. For example, it allows using this branch name :
bugfix/PROJECTCODE-123-lazy-loading-is-not-working=with-promo-banner-module
which shouldn't be passed

Introduce front-end tasks

We should introduce some tasks to handle front-end code quality - for example - eslint.
In this issue, we can collect the ideas for what tasks we can implement into the tool.
Existing tasks in the GrumPHP https://github.com/phpro/grumphp/blob/master/doc/tasks.md - it means that we can easily implement them. If you have another idea - it's also good, this tool is easily extensibility so we can create and add our own task :)