credentials/irma_js

Legacy IRMA web JavaScript library, see https://github.com/privacybydesign/irmajs

irma_js's Issues

Use error codes in callbacks (irma.js)

Callbacks currently provide a textual (human-readable) string in English with an error message (around here, for example). This should be an error code instead, because:

• it makes it possible to differentiate in the application between clicking "cancel" and hitting a timeout
• translation becomes easier

See:
https://github.com/credentials/irma_sms_issuer/blob/master/src/main/webapp/common.js#L114

IRMA is not defined

Hey there im trying to get the example given in the README working but I get the following error:

Uncaught ReferenceError: IRMA is not defined
    at init (verify.js:21)
    at HTMLDocument.<anonymous> (verify.js:49)
    at mightThrow (jquery.js:3534)
    at process (jquery.js:3602)

So I tried to import it with import * as IRMA from "./client/irma";. This however made it so I cant call on the clicked method:

index.html:10 Uncaught ReferenceError: isclicked is not defined
    at HTMLButtonElement.onclick (index.html:10)

I also get the following error:

Uncaught SyntaxError: Unexpected token export

Any help?

Opening the Irma app on IOS from '_blank' removes the original webpage

Open a link on an iPhone to a new page targeted as '_blank', when you issue a Irma session from this page the js changes the window location to irma://. This makes IOS 'replace' the content of this _blank page with the Irma app. The _blank page is then gone and with it the page you logged into. If you open a link manually to the same page everything is fine.

The problem is at:

https://github.com/privacybydesign/irma_js/blob/6747669b2ed50e0d8ad8198b1914b458abfec2cf/client/irma.js#L590

A fix can be to change it to open a new window before any async call with window.open() and store the windowReference in a global var. Then in the callback set the location of the windowReference to the irma:// location.