cristianbote/hnpwa-vanilla

Hacker News PWA implemented using no framework just javascript

hnpwa-vanilla's Issues

Get error 401 (invalid credentials) after run npm run serve

Hi @cristianbote, it has been long time I don't check this project. I would like to test in locally by run npm run serve but Firebase give response error HTTP Error 401 like below:

Error: HTTP Error: 401, Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.

Is that I'm missing something? I have tried to set up a Firebase project with the name hnpwa-vanilla and firebase give the project id name: hnpwa-vanilla-a2008. I run command explicitly firebase serve -p 8080 --project hnpwa-vanilla-a2008 and it still gives response HTTP error 401.

html injection

hnpwa-vanilla/src/core/dom-api.js

Lines 18 to 25 in aca303b

	function ifStringSetText(val, el) {
	if (!!val && !!val.match) {
	el.innerHTML = val;
	return true;
	}
	return false;
	}

innerHTML might be an issue if the title of the post is something like:

PWA suffers <em onmouseover="alert('hi')"> html injection attack!

Internet Explorer 11

Nice work 💯

To qualify does this need to support IE 11? 😭

Could use https://github.com/developit/unfetch

Missing script for npm run serve and run-prod

Is there a global cli tool that is implied in the README.md? I can't npm run serve or npm run-prod because neither is present in package.json.

➜  hnpwa-vanilla git:(master) ✗ npm run serve
npm ERR! missing script: serve

➜  hnpwa-vanilla git:(master) ✗ cat package.json | jq .scripts
{
  "build-sw": "node sw-build.js",
  "html-minify": "node html-minify.js",
  "copy-assets": "node copy-assets.js",
  "bundle": "microbundle --output public --target browser --format cjs",
  "build-prod": "rm -rf public; npm run bundle; npm run copy-assets; npm run build-sw; npm run html-minify",
  "deploy": "npm run build-prod; firebase deploy"
}

Running in local and please update README.md

Hi Cristian, thanks for your awesome hnpwa-vanilla repo. I just want to learn the code and how it works, but when I do npm run dev as per documentation it doesn't work. I check in package.json and it doesn't contain "scripts": { "dev": "bla bla bla" }. I go to your commit history and it shows that you replace several dependecies with microbundle and you remove the scripts { "dev": "bla bla bla" }. I go to microbundle repository and do as per documentation:

1. npm i -D microbundle
2. In package.json I add dev env in scripts: "scripts": { "build": "microbundle", "dev": "microbundle watch" }
3. npm run dev but it just bundling and didn't show the URL that I must hit in browser.

Could you please give the solution about this with update README.md. Thanks a lot.

Do not open /item links in new window

Sometimes, the story url is basically comments. Just don't open it, in a new window.

(feature) Dark mode

It wasn't a thing back then, it is now.

Make sure `<pre>` has `overflow: auto` so the block is scrollable

Make title clickable in item-view

Pff, this should've been caught in testing.

Firebase: not found

not sure what this means: sh: 1: firebase: not found

Add ga

Routing back button

Routing does not work when you click on the back or forward button.

Should have at least basic seo support

Meaning, update the item view with the content title.

Render comments view incrementally

Long comments threads take too long to render. Should have a better experience.
A few options could include:

• Collapsed threads
• Lazy render the other
• Have a thread skeleton render first

Figure it out!

Dark mode color issues

• Octocat is not visible in amoled dark mode.
• Link text blends in too well with other text such as username.

Value of page param doesn't change.

Hi @cristianbote, I try hnpwa-vanilla live site doesn't update the value of param page each time I move to the next page. Here is the demo video related to the value of page param doesn't change.