cronos-labs/play-unreal-plugin

Unreal Engine plugin repo for GameFi

play-unreal-plugin's Issues

Probem: missing support of blackscout, cronoscan apis

expose these apis

blackscout
cronoscan

Problem: ue4 not responding when chain is not reachable

ue4 editor is not responding, when server is not reachable.

check whether server is reachable first or
make it stop faster

Problem: Include defi-wallet-core-rs cpp bindings and libraries without building

defi-wallet-core-rs is a submodule of this project. The problem is users need to clone and compile it, I found this was very time consuming.

Please consider to include the bindings and libraries without building defi-wallet-core-rs.

Problem: recreate erc20, erc721, erc1155 instance for each call

keep as member of the actor
reuse it

Problem: missing example for unreal engine 4

add unreal engine 4 plugin

Problem: incorrect tokenid in tokenuri

Solution: use tokenid correctly

Problem: defi-wallet-core-rs cpp bindings and libraries are not up to date

Problem: no automated tests

UE has this testing facility: https://docs.unrealengine.com/4.27/en-US/TestingAndOptimization/Automation/

It should be possible to add use it on CI such as GH Actions, see this repo/article for reference with Jenkins:
https://github.com/Floating-Island/UE4-TDD-CI_Testing

Problem: missing support of wallet-connect

add wallet-connect from game-sdk-extras

Problem: no linting

apply linting with
https://ue4-style-guide.readthedocs.io/en/latest/gettingstarted.html

and reformat blueprints
refactoring for found issues

ChainSafe Integrate testing on Android

Unreal Engine sample game with a Chain plugin

Unreal Engine plugin docs similar to https://chainsafe.github.io/game-docs/

Unreal Engine plugin repo similar to https://github.com/ChainSafe/web3.unity

Problem: missing api for tokenuri download and texture generation

add ue4 plugin apis for uri downloading

ChainSafe Integrate testing on iOS

https://chainsafe.github.io/game-docs/mobile/

Problem: missing support NFT binding for cosmos

add NFT binding for cosmos

Problem: missing document for installation

add installation document

Problem: missing support of cronos NFT

add NFT api for cronos

Problem: can not be opened in mac monterey xcode update

fix "cannot load dylib" issue

Problem: missing of release github action

add github release action

GameFi web page with docs + showcase (resources, existing games etc.)

Problem: sample code and plugin bundled together

It may good to separate and add additional documentation/explanation.
A reference from @ricky321q:

• plugin: https://github.com/Ankr-network/game-unreal-sdk
• sample code: https://github.com/Ankr-network/game-unreal-demo

Problem: not merged to main branch

feature/47 branch not merged the main

Problem: inconsistent code style

perhaps this one can be adapted: https://github.com/Allar/ue5-style-guide ?
it has an automated linter

Problem: missing WalletConnect support on mobile

it should open an app link instead of showing a QR code

Problem: missing login api

add login api

Crypto.com Pay integration in Unreal Engine (Pay Checkout plugin?)

Problem: missing dylib in mac

add loading dylib in module

Problem: missing support of ue5

add example for ue5 with the same c++ source for plugin

Problem: missing transfer apis of tokens

add transfer , approve for the token in ue4

Problem: demo plugin not updated

update latest version

Problem: missing OSS docs

Problem: not using latest play-cpp-sdk

update latest version

Problem: missing support of wallet-connect apis

support wallet-connect and qr display

Problem: missing graceful shutdown

to shutdown tokio::runtime gracefully

1. create unreal game engine instance
2. override exit instance
3. close tokio runtime - that would be delete opaque wallet pointer, that will drop tokio::runtime, it will gracefully close all pending calls.

Problem: missing CI pipelines

It may be a bit tricky, but at least some basic building could potentially be checked: https://github.com/adamrehn/ue4-ci-helpers/tree/master/ue4helpers

In https://www.unrealengine.com/en-US/marketplace-guidelines#263 it mentions a few rules for compilation:

2.6.3.a Code plugins must generate no errors or consequential warnings.
2.6.3.b Plugins will be distributed with the binaries built by Epic’s compilation toolchain, (...)
Engine\Build\BatchFiles\RunUAT.bat BuildPlugin -Plugin=[Path to .uplugin file, must be outside engine directory] -Package=[Output directory] -Rocket

perhaps it could at least run that batch script for building a plugin

Problem: missing documentation for apis

add automatic documentation using sphinx-doc

Problem: sample project is using ue4

replace contents with ue5
ensure that plugin still usable with ue4

Problem: demo not updated

Solution: update demo

Problem: code style inconsistent

use this rule to format

find . -name "*.h" -o -name "*.cpp" -o -name "*.cc" | xargs clang-format -i -style="{SortIncludes: Never}"

Problem: Missing setup documents

Seems the setup documents are missing, when I do make, I can not build it successfully.

Problem: unreal demo not using json rpc with cronos

query NFT and display
add other json rpc calls into blueprint
display information in UI widget

rpc url: https://evm-dev-t3.cronos.org
cronos chainid: 338

it will use testnet3 , user don't have to install own devnet..

Problem: missing guide for dylib loading

add dylib workaround to readme

Unity integration docs using ChainSafe plugin

Problem: missing support of gitbook doxygen workflow

add sphinx workflow, so that document is generated automatically.

Problem: security guideline is not followed when publishing artifacts on GH Releases

Follow security guideline.

Is there a plan to follow the security team’s guideline? One thing is to have the “two-pairs-of-eyes” review process that can perhaps be forced via the GH Action protected environments: https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments

Problem: not supporting ue5

export MACOSX_DEPLOYMENT_TARGET=10.15
cargo build...
and recompile defi-wallet-core

Problem: not using cronos-play icon and banner

use cronos-play icon and banner

Problem: missing update dll for windows

update dll for windows