crossplane-contrib/crossplane-migrator

Migrates Crossplane YAML manifests to new formats

crossplane-migrator's Issues

math.type: Required value: math transform type is required - type Multiplay is missing

pld p&t:

          transforms:
          - math:
              multiply: 1024
            type: math

crossplane-migrator new-pipeline-composition -i database/sqlinstance/composition-mariadb.yaml -o xx.yaml

after migration:

          transforms:
          - math:
              multiply: 1024
            type: math

error:
crossplane: error: cannot render composite resource: pipeline step "patch-and-transform" returned a fatal result: invalid Function input: resources[0].patches[3].transforms[0].math.type: Required value: math transform type is required

                transforms:
                - math:
                    multiply: 1024
                    type: Multiply
                  type: math

Archive repo with the release of Crossplane 1.15

With PR crossplane/crossplane#5275, the functionality of this binary will be merged into the Crossplane CLI.

DeploymentRuntimeConfig does not create serviceAccounts

With ControllerConfig, if a user specified a spec.serviceAccountName Crossplane would create one for you. With the DeploymentRuntimeConfig, this is no longer the case.

We should think of options of handling this to make it easy for users to migrate:

• - adding a warning when converting
• - adding a CLI option to create a ServiceAccount object with a namespace

new-pipeline-composition: `spec.environment` wrongly pushed down entirely to function

Currently the new-pipeline-composition command takes the whole spec.environment and moves it down to spec.pipeline[0].environment, but that's not correct, only spec.environment.patches should be pushed down at the Function level, while the rest should be kept at the Composition level.

This is most probably due to the drift between the vendored Input and the actual Resources expected by function-patch-and-transform.

Add in missing Patch types

crossplane-contrib/function-patch-and-transform#19 might require patch types to be present. Crossplane-migrator should add a patch type if it can determine it.

I believe the only patch type that isn't required is FromCompositeFieldPath , so this might be a small effort.