crossplane-contrib/x-generation

generate compositions from crossplane provider crds

x-generation's Issues

Support Environment Configs

What problem are you facing?

Support generating manifests with EnvironmentConfig support

How could Crossplane help solve your problem?

Add support for top level environment config, (patches, selectors, etc.) and setting ToEnvironmentFieldPath and FromEnvironmentFieldPath.

Make it possible to patch spec.providerConfigRef.name

If I understand the functions right, it's not possible now to create patches like:

overrideFieldsInClaim:
  - claimPath: spec.claimRef.namespace
    managedPath: spec.providerConfigRef.name

It would be great if it would be possible.

relative paths in generator-config.yaml

What problem are you facing?

I wan't to maintain my provider and the xresources in the same git repository and build both in my ci environment. For this, I don't set filesystem paths in the generator-config.yaml. At the moment, it's not possible to use relative paths pointing to the crd directory. They have to be absolut paths beginning with /. It would be great if relative paths were possible.

Strange behaviour when installing this

What happened?

I try to use this tool - but had problems installing it (as for now I only want to use/try it ;-) I think the behaviour is strange, and some information in the docs how to start would be really nice.

How can we reproduce it?

This fails:

go install github.com/crossplane-contrib/[email protected]
go: github.com/crossplane-contrib/[email protected]: module github.com/crossplane-contrib/[email protected] found, but does not contain package github.com/crossplane-contrib/x-generation

This succeeds:

go install github.com/crossplane-contrib/x-generation/[email protected]

but ...

pkg --help
Usage of pkg:
  -configFile string
        path where global config file can be found (default: ./generator-config.yaml) (default "./generator-config.yaml")
  -inputName string
        input filename to search for in current directory (default "generate.yaml")
  -inputPath string
        input filename to search for in current directory (default "/Users/.../go/1.19.0/pkg")
  -outputPath string
        path where output files are created (default: same directory as input file)
  -scriptName string
        script filename to execute against input file(s) (default: generate.jsonnet or specified in each input file)
  -scriptPath string
        path where script files are loaded from  (default "/.../go/1.19.0/pkg/mod/github.com/crossplane-contrib/[email protected]/pkg/functions")

... I don't like the name of the command installed ... somehow misleading or not intuitive?

Maybe it was my fault when installing it (but that's where to docs could pick me up where i stand... Thank you!

"properties" property and default value are not handled correctly

What happened?

The patches created for CRDs with a "properties" property and a default value are not handled correctly.

"properties" properties are nor patched, for default values, a patch that should not exist is created.

How can we reproduce it?

Try to generate a composition for kafka.aws.crossplane.io_configurations

What environment did it happen in?

Crossplane version: